-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_iam_policy: Do not iterate over all IAM Policies when ARN supplied #25538
Conversation
…es bug where tags are not retrieved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccIAMPolicyDataSource_' PKG=iam ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 3 -run=TestAccIAMPolicyDataSource_ -timeout 180m
=== RUN TestAccIAMPolicyDataSource_arn
=== PAUSE TestAccIAMPolicyDataSource_arn
=== RUN TestAccIAMPolicyDataSource_arnTags
=== PAUSE TestAccIAMPolicyDataSource_arnTags
=== RUN TestAccIAMPolicyDataSource_name
=== PAUSE TestAccIAMPolicyDataSource_name
=== RUN TestAccIAMPolicyDataSource_nameTags
=== PAUSE TestAccIAMPolicyDataSource_nameTags
=== RUN TestAccIAMPolicyDataSource_nameAndPathPrefix
=== PAUSE TestAccIAMPolicyDataSource_nameAndPathPrefix
=== RUN TestAccIAMPolicyDataSource_nameAndPathPrefixTags
=== PAUSE TestAccIAMPolicyDataSource_nameAndPathPrefixTags
=== RUN TestAccIAMPolicyDataSource_nonExistent
=== PAUSE TestAccIAMPolicyDataSource_nonExistent
=== CONT TestAccIAMPolicyDataSource_arn
=== CONT TestAccIAMPolicyDataSource_nameAndPathPrefix
=== CONT TestAccIAMPolicyDataSource_name
--- PASS: TestAccIAMPolicyDataSource_arn (16.40s)
=== CONT TestAccIAMPolicyDataSource_nameTags
--- PASS: TestAccIAMPolicyDataSource_nameAndPathPrefix (16.45s)
=== CONT TestAccIAMPolicyDataSource_arnTags
--- PASS: TestAccIAMPolicyDataSource_name (20.14s)
=== CONT TestAccIAMPolicyDataSource_nonExistent
--- PASS: TestAccIAMPolicyDataSource_arnTags (12.70s)
=== CONT TestAccIAMPolicyDataSource_nameAndPathPrefixTags
--- PASS: TestAccIAMPolicyDataSource_nameTags (16.21s)
--- PASS: TestAccIAMPolicyDataSource_nameAndPathPrefixTags (12.79s)
--- PASS: TestAccIAMPolicyDataSource_nonExistent (121.90s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iam 145.937s
Needs a CHANGELOG entry. |
Needs documentation, too :) |
.changelog/25538.txt
Outdated
``` | ||
|
||
```release-note:bug | ||
data-source/aws_iam_policy: Now loads tags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space.
data-source/aws_iam_policy: Now loads tags. | |
data-source/aws_iam_policy: Now loads tags. |
This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
No longer iterates over all IAM Policies in
aws_iam_policy
data source when ARN is supplied. Also fixes bug where tags are not retrieved.Closes #25533.
Closes #25537.
Closes #19878.
Output from acceptance testing: