Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_gamelift_game_session_queue: add notification_target argument #25544

Conversation

Hinidu
Copy link
Contributor

@Hinidu Hinidu commented Jun 23, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
$ make testacc TESTS=TestAccGameLiftGameSessionQueue PKG=gamelift

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/gamelift Issues and PRs that pertain to the gamelift service. labels Jun 23, 2022
@Hinidu Hinidu changed the title Add notification_target argument to aws_gamelift_game_session_queue resource/aws_gamelift_game_session_queue: add notification_target argument Jun 23, 2022
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 25, 2022
@Hinidu Hinidu force-pushed the gamelift_game_session_queue_notification_target branch from 2090699 to 27056ea Compare June 27, 2022 15:49
@Hinidu Hinidu force-pushed the gamelift_game_session_queue_notification_target branch from 27056ea to 3c164b5 Compare June 29, 2022 13:03
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccGameLiftGameSessionQueue_' PKG=gamelift ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/gamelift/... -v -count 1 -parallel 2  -run=TestAccGameLiftGameSessionQueue_ -timeout 180m
=== RUN   TestAccGameLiftGameSessionQueue_basic
--- PASS: TestAccGameLiftGameSessionQueue_basic (40.57s)
=== RUN   TestAccGameLiftGameSessionQueue_tags
--- PASS: TestAccGameLiftGameSessionQueue_tags (57.93s)
=== RUN   TestAccGameLiftGameSessionQueue_disappears
--- PASS: TestAccGameLiftGameSessionQueue_disappears (15.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/gamelift	124.565s

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jul 1, 2022
@ewbankkit
Copy link
Contributor

@Hinidu Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit aa54611 into hashicorp:main Jul 1, 2022
@github-actions github-actions bot added this to the v4.22.0 milestone Jul 1, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/gamelift Issues and PRs that pertain to the gamelift service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants