r/aws_default_vpc_dhcp_options: Fix v4.20.0 regression with TypeList vs. TypeString

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25561.

Prior to the fix

% make testacc TESTARGS='-run=TestAccVPCDefaultVPCDHCPOptions_serial/v4.20.0_regression' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCDefaultVPCDHCPOptions_serial/v4.20.0_regression -timeout 180m
=== RUN   TestAccVPCDefaultVPCDHCPOptions_serial
=== RUN   TestAccVPCDefaultVPCDHCPOptions_serial/v4.20.0_regression
    vpc_default_vpc_dhcp_options_test.go:87: Step 2/2 error: Error running pre-apply refresh: exit status 1
        
        Error: missing expected [
        
          with aws_default_vpc_dhcp_options.test,
          on terraform_plugin_test.tf line 2, in resource "aws_default_vpc_dhcp_options" "test":
           2: resource "aws_default_vpc_dhcp_options" "test" {
        
    testing_new.go:73: Error retrieving state, there may be dangling resources: exit status 1
        Failed to marshal state to json: missing expected [
--- FAIL: TestAccVPCDefaultVPCDHCPOptions_serial (45.27s)
    --- FAIL: TestAccVPCDefaultVPCDHCPOptions_serial/v4.20.0_regression (45.27s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	49.169s
FAIL
make: *** [testacc] Error 1

Now

% make testacc TESTARGS='-run=TestAccVPCDefaultVPCDHCPOptions_serial' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCDefaultVPCDHCPOptions_serial -timeout 180m
=== RUN   TestAccVPCDefaultVPCDHCPOptions_serial
=== RUN   TestAccVPCDefaultVPCDHCPOptions_serial/basic
=== RUN   TestAccVPCDefaultVPCDHCPOptions_serial/owner
=== RUN   TestAccVPCDefaultVPCDHCPOptions_serial/v4.20.0_regression
--- PASS: TestAccVPCDefaultVPCDHCPOptions_serial (83.04s)
    --- PASS: TestAccVPCDefaultVPCDHCPOptions_serial/basic (13.57s)
    --- PASS: TestAccVPCDefaultVPCDHCPOptions_serial/owner (13.09s)
    --- PASS: TestAccVPCDefaultVPCDHCPOptions_serial/v4.20.0_regression (56.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	87.122s

[YakDriver]

Looks good! 🎉

% make testacc TESTARGS='-run=TestAccVPCDefaultVPCDHCPOptions_serial/v4.20.0_regression' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCDefaultVPCDHCPOptions_serial/v4.20.0_regression -timeout 180m
=== RUN   TestAccVPCDefaultVPCDHCPOptions_serial
=== RUN   TestAccVPCDefaultVPCDHCPOptions_serial/v4.20.0_regression
--- PASS: TestAccVPCDefaultVPCDHCPOptions_serial (49.04s)
    --- PASS: TestAccVPCDefaultVPCDHCPOptions_serial/v4.20.0_regression (49.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	50.394s

[github-actions]

This functionality has been released in v4.20.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.