-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add spread_level to aws_placement_group resource #25615
add spread_level to aws_placement_group resource #25615
Conversation
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEC2PlacementGroup_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccEC2PlacementGroup_ -timeout 180m
=== RUN TestAccEC2PlacementGroup_basic
=== PAUSE TestAccEC2PlacementGroup_basic
=== RUN TestAccEC2PlacementGroup_disappears
=== PAUSE TestAccEC2PlacementGroup_disappears
=== RUN TestAccEC2PlacementGroup_tags
=== PAUSE TestAccEC2PlacementGroup_tags
=== RUN TestAccEC2PlacementGroup_partitionCount
=== PAUSE TestAccEC2PlacementGroup_partitionCount
=== RUN TestAccEC2PlacementGroup_spreadLevel
=== PAUSE TestAccEC2PlacementGroup_spreadLevel
=== CONT TestAccEC2PlacementGroup_basic
=== CONT TestAccEC2PlacementGroup_partitionCount
--- PASS: TestAccEC2PlacementGroup_basic (17.84s)
=== CONT TestAccEC2PlacementGroup_tags
--- PASS: TestAccEC2PlacementGroup_partitionCount (18.93s)
=== CONT TestAccEC2PlacementGroup_disappears
--- PASS: TestAccEC2PlacementGroup_disappears (11.92s)
=== CONT TestAccEC2PlacementGroup_spreadLevel
--- PASS: TestAccEC2PlacementGroup_spreadLevel (15.57s)
--- PASS: TestAccEC2PlacementGroup_tags (37.03s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 58.965s
@silvaalbert Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #25614
Output from acceptance testing: