-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Successfully allow changing of set_identifier on route53_record (no more entries dropped from state!) #25620
Successfully allow changing of set_identifier on route53_record (no more entries dropped from state!) #25620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRoute53Record_' PKG=route53 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 2 -run=TestAccRoute53Record_ -timeout 180m
=== RUN TestAccRoute53Record_basic
=== PAUSE TestAccRoute53Record_basic
=== RUN TestAccRoute53Record_underscored
=== PAUSE TestAccRoute53Record_underscored
=== RUN TestAccRoute53Record_disappears
=== PAUSE TestAccRoute53Record_disappears
=== RUN TestAccRoute53Record_Disappears_multipleRecords
=== PAUSE TestAccRoute53Record_Disappears_multipleRecords
=== RUN TestAccRoute53Record_Basic_fqdn
=== PAUSE TestAccRoute53Record_Basic_fqdn
=== RUN TestAccRoute53Record_Basic_trailingPeriodAndZoneID
=== PAUSE TestAccRoute53Record_Basic_trailingPeriodAndZoneID
=== RUN TestAccRoute53Record_txtSupport
=== PAUSE TestAccRoute53Record_txtSupport
=== RUN TestAccRoute53Record_spfSupport
=== PAUSE TestAccRoute53Record_spfSupport
=== RUN TestAccRoute53Record_caaSupport
=== PAUSE TestAccRoute53Record_caaSupport
=== RUN TestAccRoute53Record_dsSupport
=== PAUSE TestAccRoute53Record_dsSupport
=== RUN TestAccRoute53Record_generatesSuffix
=== PAUSE TestAccRoute53Record_generatesSuffix
=== RUN TestAccRoute53Record_wildcard
=== PAUSE TestAccRoute53Record_wildcard
=== RUN TestAccRoute53Record_failover
=== PAUSE TestAccRoute53Record_failover
=== RUN TestAccRoute53Record_Weighted_basic
=== PAUSE TestAccRoute53Record_Weighted_basic
=== RUN TestAccRoute53Record_WeightedToSimple_basic
=== PAUSE TestAccRoute53Record_WeightedToSimple_basic
=== RUN TestAccRoute53Record_Alias_elb
=== PAUSE TestAccRoute53Record_Alias_elb
=== RUN TestAccRoute53Record_Alias_s3
=== PAUSE TestAccRoute53Record_Alias_s3
=== RUN TestAccRoute53Record_Alias_vpcEndpoint
=== PAUSE TestAccRoute53Record_Alias_vpcEndpoint
=== RUN TestAccRoute53Record_Alias_uppercase
=== PAUSE TestAccRoute53Record_Alias_uppercase
=== RUN TestAccRoute53Record_Weighted_alias
=== PAUSE TestAccRoute53Record_Weighted_alias
=== RUN TestAccRoute53Record_Geolocation_basic
=== PAUSE TestAccRoute53Record_Geolocation_basic
=== RUN TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== PAUSE TestAccRoute53Record_HealthCheckID_setIdentifierChange
=== RUN TestAccRoute53Record_HealthCheckID_typeChange
=== PAUSE TestAccRoute53Record_HealthCheckID_typeChange
=== RUN TestAccRoute53Record_Latency_basic
=== PAUSE TestAccRoute53Record_Latency_basic
=== RUN TestAccRoute53Record_typeChange
=== PAUSE TestAccRoute53Record_typeChange
=== RUN TestAccRoute53Record_nameChange
=== PAUSE TestAccRoute53Record_nameChange
=== RUN TestAccRoute53Record_setIdentifierChangeBasicToWeighted
=== PAUSE TestAccRoute53Record_setIdentifierChangeBasicToWeighted
=== RUN TestAccRoute53Record_setIdentifierRenameGeolocationContinent
=== PAUSE TestAccRoute53Record_setIdentifierRenameGeolocationContinent
=== RUN TestAccRoute53Record_setIdentifierRenameGeolocationCountryDefault
=== PAUSE TestAccRoute53Record_setIdentifierRenameGeolocationCountryDefault
=== RUN TestAccRoute53Record_setIdentifierRenameGeolocationCountrySpecified
=== PAUSE TestAccRoute53Record_setIdentifierRenameGeolocationCountrySpecified
=== RUN TestAccRoute53Record_setIdentifierRenameGeolocationCountrySubdivision
=== PAUSE TestAccRoute53Record_setIdentifierRenameGeolocationCountrySubdivision
=== RUN TestAccRoute53Record_setIdentifierRenameFailover
=== PAUSE TestAccRoute53Record_setIdentifierRenameFailover
=== RUN TestAccRoute53Record_setIdentifierRenameLatency
=== PAUSE TestAccRoute53Record_setIdentifierRenameLatency
=== RUN TestAccRoute53Record_setIdentifierRenameMultiValueAnswer
=== PAUSE TestAccRoute53Record_setIdentifierRenameMultiValueAnswer
=== RUN TestAccRoute53Record_setIdentifierRenameWeighted
=== PAUSE TestAccRoute53Record_setIdentifierRenameWeighted
=== RUN TestAccRoute53Record_aliasChange
=== PAUSE TestAccRoute53Record_aliasChange
=== RUN TestAccRoute53Record_empty
=== PAUSE TestAccRoute53Record_empty
=== RUN TestAccRoute53Record_longTXTrecord
=== PAUSE TestAccRoute53Record_longTXTrecord
=== RUN TestAccRoute53Record_MultiValueAnswer_basic
=== PAUSE TestAccRoute53Record_MultiValueAnswer_basic
=== RUN TestAccRoute53Record_doNotAllowOverwrite
=== PAUSE TestAccRoute53Record_doNotAllowOverwrite
=== RUN TestAccRoute53Record_allowOverwrite
=== PAUSE TestAccRoute53Record_allowOverwrite
=== CONT TestAccRoute53Record_basic
=== CONT TestAccRoute53Record_HealthCheckID_setIdentifierChange
--- PASS: TestAccRoute53Record_basic (140.66s)
=== CONT TestAccRoute53Record_setIdentifierRenameFailover
--- PASS: TestAccRoute53Record_HealthCheckID_setIdentifierChange (200.09s)
=== CONT TestAccRoute53Record_allowOverwrite
--- PASS: TestAccRoute53Record_setIdentifierRenameFailover (169.78s)
=== CONT TestAccRoute53Record_doNotAllowOverwrite
--- PASS: TestAccRoute53Record_allowOverwrite (173.87s)
=== CONT TestAccRoute53Record_MultiValueAnswer_basic
--- PASS: TestAccRoute53Record_doNotAllowOverwrite (129.88s)
=== CONT TestAccRoute53Record_longTXTrecord
--- PASS: TestAccRoute53Record_MultiValueAnswer_basic (152.69s)
=== CONT TestAccRoute53Record_empty
--- PASS: TestAccRoute53Record_longTXTrecord (107.06s)
=== CONT TestAccRoute53Record_aliasChange
--- PASS: TestAccRoute53Record_empty (141.64s)
=== CONT TestAccRoute53Record_setIdentifierRenameWeighted
--- PASS: TestAccRoute53Record_aliasChange (192.89s)
=== CONT TestAccRoute53Record_setIdentifierRenameMultiValueAnswer
--- PASS: TestAccRoute53Record_setIdentifierRenameWeighted (170.38s)
=== CONT TestAccRoute53Record_setIdentifierRenameLatency
--- PASS: TestAccRoute53Record_setIdentifierRenameMultiValueAnswer (195.79s)
=== CONT TestAccRoute53Record_setIdentifierChangeBasicToWeighted
--- PASS: TestAccRoute53Record_setIdentifierRenameLatency (193.38s)
=== CONT TestAccRoute53Record_setIdentifierRenameGeolocationCountrySubdivision
--- PASS: TestAccRoute53Record_setIdentifierChangeBasicToWeighted (222.60s)
=== CONT TestAccRoute53Record_setIdentifierRenameGeolocationCountrySpecified
--- PASS: TestAccRoute53Record_setIdentifierRenameGeolocationCountrySubdivision (198.73s)
=== CONT TestAccRoute53Record_setIdentifierRenameGeolocationCountryDefault
--- PASS: TestAccRoute53Record_setIdentifierRenameGeolocationCountrySpecified (216.82s)
=== CONT TestAccRoute53Record_setIdentifierRenameGeolocationContinent
--- PASS: TestAccRoute53Record_setIdentifierRenameGeolocationCountryDefault (220.79s)
=== CONT TestAccRoute53Record_typeChange
--- PASS: TestAccRoute53Record_setIdentifierRenameGeolocationContinent (246.98s)
=== CONT TestAccRoute53Record_nameChange
--- PASS: TestAccRoute53Record_typeChange (216.16s)
=== CONT TestAccRoute53Record_Latency_basic
--- PASS: TestAccRoute53Record_Latency_basic (168.89s)
=== CONT TestAccRoute53Record_wildcard
--- PASS: TestAccRoute53Record_nameChange (257.25s)
=== CONT TestAccRoute53Record_Alias_elb
--- PASS: TestAccRoute53Record_Alias_elb (162.25s)
=== CONT TestAccRoute53Record_WeightedToSimple_basic
--- PASS: TestAccRoute53Record_wildcard (214.51s)
=== CONT TestAccRoute53Record_Alias_s3
--- PASS: TestAccRoute53Record_Alias_s3 (148.74s)
=== CONT TestAccRoute53Record_Weighted_basic
--- PASS: TestAccRoute53Record_WeightedToSimple_basic (223.05s)
=== CONT TestAccRoute53Record_Geolocation_basic
--- PASS: TestAccRoute53Record_Weighted_basic (155.57s)
=== CONT TestAccRoute53Record_failover
--- PASS: TestAccRoute53Record_Geolocation_basic (156.79s)
=== CONT TestAccRoute53Record_Alias_uppercase
--- PASS: TestAccRoute53Record_failover (150.81s)
=== CONT TestAccRoute53Record_HealthCheckID_typeChange
--- PASS: TestAccRoute53Record_Alias_uppercase (152.17s)
=== CONT TestAccRoute53Record_Weighted_alias
--- PASS: TestAccRoute53Record_HealthCheckID_typeChange (200.58s)
=== CONT TestAccRoute53Record_Alias_vpcEndpoint
--- PASS: TestAccRoute53Record_Weighted_alias (324.49s)
=== CONT TestAccRoute53Record_dsSupport
--- PASS: TestAccRoute53Record_dsSupport (145.12s)
=== CONT TestAccRoute53Record_generatesSuffix
--- PASS: TestAccRoute53Record_Alias_vpcEndpoint (457.70s)
=== CONT TestAccRoute53Record_caaSupport
--- PASS: TestAccRoute53Record_generatesSuffix (152.56s)
=== CONT TestAccRoute53Record_Disappears_multipleRecords
--- PASS: TestAccRoute53Record_caaSupport (129.09s)
=== CONT TestAccRoute53Record_Basic_trailingPeriodAndZoneID
--- PASS: TestAccRoute53Record_Basic_trailingPeriodAndZoneID (110.22s)
=== CONT TestAccRoute53Record_Basic_fqdn
--- PASS: TestAccRoute53Record_Disappears_multipleRecords (210.58s)
=== CONT TestAccRoute53Record_underscored
--- PASS: TestAccRoute53Record_underscored (143.81s)
=== CONT TestAccRoute53Record_spfSupport
--- PASS: TestAccRoute53Record_Basic_fqdn (161.21s)
=== CONT TestAccRoute53Record_txtSupport
--- PASS: TestAccRoute53Record_spfSupport (139.97s)
=== CONT TestAccRoute53Record_disappears
--- PASS: TestAccRoute53Record_txtSupport (161.70s)
--- PASS: TestAccRoute53Record_disappears (134.65s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/route53 3833.998s
@handlerbot Thanks for the contribution 🎉 👏. |
@ewbankkit Thank you so much for the fast review, I know everyone's super slammed over there! Q: In your understanding, will this go out with this week's release, or will we catch next week's release train? |
@handlerbot Yes, this will be released in v4.21.0, planned for sometime later today (6/30). |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #7998
Output from acceptance testing: