Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase SageMaker ProjectCreatedTimeout and ProjectDeletedTimeout to 15 minutes #25638

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Jun 30, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25637

Output from acceptance testing:

bruno@pop-os ~/G/terraform-provider-aws (e/#25637-increase-sagemaker-project-timeouts)> make testacc TESTS=TestAccSageMakerProject_ PKG=sagemaker                                                                                            (base) 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMakerProject_'  -timeout 180m
=== RUN   TestAccSageMakerProject_basic
=== PAUSE TestAccSageMakerProject_basic
=== RUN   TestAccSageMakerProject_description
=== PAUSE TestAccSageMakerProject_description
=== RUN   TestAccSageMakerProject_tags
=== PAUSE TestAccSageMakerProject_tags
=== RUN   TestAccSageMakerProject_disappears
=== PAUSE TestAccSageMakerProject_disappears
=== CONT  TestAccSageMakerProject_basic
=== CONT  TestAccSageMakerProject_disappears
=== CONT  TestAccSageMakerProject_description
=== CONT  TestAccSageMakerProject_tags
--- PASS: TestAccSageMakerProject_disappears (155.77s)
--- PASS: TestAccSageMakerProject_basic (196.02s)
--- PASS: TestAccSageMakerProject_tags (288.13s)
--- PASS: TestAccSageMakerProject_description (291.51s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  291.577s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XS Managed by automation to categorize the size of a PR. labels Jun 30, 2022
@bschaatsbergen bschaatsbergen changed the title Bump SageMaker ProjectCreatedTimeout and ProjectDeletedTimeout to 15 minutes Increase SageMaker ProjectCreatedTimeout and ProjectDeletedTimeout to 15 minutes Jun 30, 2022
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 1, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@bschaatsbergen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 04f9b24 into hashicorp:main Jul 1, 2022
@github-actions github-actions bot added this to the v4.22.0 milestone Jul 1, 2022
@bschaatsbergen bschaatsbergen deleted the e/#25637-increase-sagemaker-project-timeouts branch July 1, 2022 14:20
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timeout support for aws_sagemaker_project
2 participants