-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix max size of html in cognito risk config and typo in docs #25645
Fix max size of html in cognito risk config and typo in docs #25645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @TakumiHaruta 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCognitoIDPRiskConfiguration_' PKG=cognitoidp ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 2 -run=TestAccCognitoIDPRiskConfiguration_ -timeout 180m
=== RUN TestAccCognitoIDPRiskConfiguration_exception
=== PAUSE TestAccCognitoIDPRiskConfiguration_exception
=== RUN TestAccCognitoIDPRiskConfiguration_client
=== PAUSE TestAccCognitoIDPRiskConfiguration_client
=== RUN TestAccCognitoIDPRiskConfiguration_compromised
=== PAUSE TestAccCognitoIDPRiskConfiguration_compromised
=== RUN TestAccCognitoIDPRiskConfiguration_disappears_userPool
=== PAUSE TestAccCognitoIDPRiskConfiguration_disappears_userPool
=== CONT TestAccCognitoIDPRiskConfiguration_exception
=== CONT TestAccCognitoIDPRiskConfiguration_disappears_userPool
--- PASS: TestAccCognitoIDPRiskConfiguration_disappears_userPool (20.99s)
=== CONT TestAccCognitoIDPRiskConfiguration_compromised
--- PASS: TestAccCognitoIDPRiskConfiguration_exception (40.00s)
=== CONT TestAccCognitoIDPRiskConfiguration_client
--- PASS: TestAccCognitoIDPRiskConfiguration_compromised (19.75s)
--- PASS: TestAccCognitoIDPRiskConfiguration_client (19.03s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 67.601s
@TakumiHaruta Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #25644
Output from acceptance testing: