Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tgw transit_gateway_cidr_blocks validation #25673

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

wedge-jarrad
Copy link
Contributor

Transit gateway service quotas list 5 as the maximum CIDR blocks per transit gateway and it is not adjustable. https://docs.aws.amazon.com/vpc/latest/tgw/transit-gateway-quotas.html

API docs specify a minimum CIDR block of /24 or /64 for IPv4 and IPv6, respectively. It does not specify a maximum size. https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_TransitGatewayRequestOptions.html

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25316

Output from acceptance testing:

Tests not run because it seems that all of the little tests are tied together into one huge test.

Transit gateway service quotas list 5 as the maximum CIDR blocks per transit
gateway and it is not adjustable.

API docs specify a minimum CIDR block of /24 or /64 for IPv4 and IPv6,
respectively. It does not specify a maximum size.
@github-actions github-actions bot added service/transitgateway Issues and PRs that pertain to the transitgateway service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed service/transitgateway Issues and PRs that pertain to the transitgateway service. labels Jul 4, 2022
@github-actions github-actions bot added the service/transitgateway Issues and PRs that pertain to the transitgateway service. label Jul 4, 2022
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 5, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Screen Shot 2022-07-05 at 9 38 38 AM

Screen Shot 2022-07-05 at 9 41 00 AM

@ewbankkit
Copy link
Contributor

@wedge-jarrad Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 9d4e290 into hashicorp:main Jul 5, 2022
@github-actions github-actions bot added this to the v4.22.0 milestone Jul 5, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/transitgateway Issues and PRs that pertain to the transitgateway service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transit_gateway_cidr_blocks - too many list items
2 participants