b/aws_route53_resolver_endpoint

[rnsc]

Adding the IP address to the hash to avoid deduplication when using multiple IPs in the same subnet.

The following code:

resource "aws_route53_resolver_endpoint" "test" {
  name      = "r53-resolver-inbound"
  direction = "INBOUND"

  security_group_ids = ["sg-12345"]

  ip_address {
    subnet_id = "subnet-12345"
    ip        = "172.31.64.13"
  }

  ip_address {
    subnet_id = "subnet-12345"
    ip        = "172.31.64.14"
  }

  tags = {
    Name = "route53resolver"
  }
}

Without the fix:

  # aws_route53_resolver_endpoint.test will be created
  + resource "aws_route53_resolver_endpoint" "test" {
      + arn                = (known after apply)
      + direction          = "INBOUND"
      + host_vpc_id        = (known after apply)
      + id                 = (known after apply)
      + name               = "r53-resolver-inbound"
      + security_group_ids = [
          + "sg-12345",
        ]
      + tags               = {
          + "Name" = "route53resolver"
        }
      + tags_all           = {
          + "Name" = "route53resolver"
        }

      + ip_address {
          + ip        = "172.31.64.14"
          + ip_id     = (known after apply)
          + subnet_id = "subnet-12345"
        }
    }

With the fix:

  # aws_route53_resolver_endpoint.test will be created
  + resource "aws_route53_resolver_endpoint" "test" {
      + arn                = (known after apply)
      + direction          = "INBOUND"
      + host_vpc_id        = (known after apply)
      + id                 = (known after apply)
      + name               = "r53-resolver-inbound"
      + security_group_ids = [
          + "sg-12345",
        ]
      + tags               = {
          + "Name" = "route53resolver"
        }
      + tags_all           = {
          + "Name" = "route53resolver"
        }

      + ip_address {
          + ip        = "172.31.64.13"
          + ip_id     = (known after apply)
          + subnet_id = "subnet-12345"
        }
      + ip_address {
          + ip        = "172.31.64.14"
          + ip_id     = (known after apply)
          + subnet_id = "subnet-12345"
        }
    }

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9626

Output from acceptance testing:

$ make testacc TESTS=TestAccRoute53ResolverEndpoint PKG=route53

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53ResolverEndpoint'  -timeout 180m
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	2.916s [no tests to run]

[rnsc]

Small mistake on my end, I renamed the branch because of a typo, but of course that closes the PR 😓

[github-actions]

Welcome @rnsc 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[rnsc]

Hello @ewbankkit ,
Is it possible to fix the label on this PR, I think it's wrong due to the branch name?
Thanks

[YakDriver]

LGTM 🎉

% make testacc TESTS=TestAccRoute53ResolverEndpoint_ PKG=route53resolver
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run='TestAccRoute53ResolverEndpoint_'  -timeout 180m
=== RUN   TestAccRoute53ResolverEndpoint_basic
=== PAUSE TestAccRoute53ResolverEndpoint_basic
=== RUN   TestAccRoute53ResolverEndpoint_disappears
=== PAUSE TestAccRoute53ResolverEndpoint_disappears
=== RUN   TestAccRoute53ResolverEndpoint_tags
=== PAUSE TestAccRoute53ResolverEndpoint_tags
=== RUN   TestAccRoute53ResolverEndpoint_updateOutbound
=== PAUSE TestAccRoute53ResolverEndpoint_updateOutbound
=== CONT  TestAccRoute53ResolverEndpoint_basic
=== CONT  TestAccRoute53ResolverEndpoint_tags
=== CONT  TestAccRoute53ResolverEndpoint_updateOutbound
=== CONT  TestAccRoute53ResolverEndpoint_disappears
--- PASS: TestAccRoute53ResolverEndpoint_basic (97.25s)
--- PASS: TestAccRoute53ResolverEndpoint_disappears (103.35s)
--- PASS: TestAccRoute53ResolverEndpoint_tags (139.26s)
--- PASS: TestAccRoute53ResolverEndpoint_updateOutbound (437.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	439.664s

[github-actions]

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.