Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssm/parameter: Add insecure_value argument #25721

Merged
merged 2 commits into from
Jul 7, 2022
Merged

ssm/parameter: Add insecure_value argument #25721

merged 2 commits into from
Jul 7, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jul 6, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9090

Output from acceptance testing:

% make testacc TESTS=TestAccSSMParameter PKG=ssm                            
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20 -run='TestAccSSMParameter'  -timeout 180m
--- PASS: TestAccSSMParameter_disappears (85.04s)
--- PASS: TestAccSSMParametersByPathDataSource_withRecursion (100.87s)
--- PASS: TestAccSSMParametersByPathDataSource_basic (101.10s)
--- PASS: TestAccSSMParameter_Overwrite_tags (101.64s)
--- PASS: TestAccSSMParameter_Overwrite_noOverwriteTags (102.34s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnCreation (102.75s)
--- PASS: TestAccSSMParameter_basic (115.85s)
--- PASS: TestAccSSMParameter_DataType_ec2Image (117.20s)
--- PASS: TestAccSSMParameter_Secure_key (117.55s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnUpdate (157.26s)
--- PASS: TestAccSSMParameterDataSource_basic (169.01s)
--- PASS: TestAccSSMParameterDataSource_fullPath (84.10s)
--- PASS: TestAccSSMParameter_Overwrite_basic (173.72s)
--- PASS: TestAccSSMParameter_Overwrite_updateToTags (178.85s)
--- PASS: TestAccSSMParameter_Secure_keyUpdate (181.05s)
--- PASS: TestAccSSMParameter_fullPath (89.29s)
--- PASS: TestAccSSMParameter_Secure_basic (94.79s)
--- PASS: TestAccSSMParameter_Overwrite_cascade (204.42s)
--- PASS: TestAccSSMParameter_Secure_insecureChangeSecure (217.89s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToStandard (218.18s)
--- PASS: TestAccSSMParameter_tags (221.95s)
--- PASS: TestAccSSMParameter_tier (223.69s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToAdvanced (224.31s)
--- PASS: TestAccSSMParameter_Overwrite_updateDescription (127.35s)
--- PASS: TestAccSSMParameter_updateType (129.49s)
--- PASS: TestAccSSMParameter_changeNameForcesNew (122.50s)
--- PASS: TestAccSSMParameter_Secure_insecure (153.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	256.932s

@github-actions github-actions bot added service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Jul 6, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jul 6, 2022
ewbankkit
ewbankkit approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSSMParameter' PKG=ssm ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 2  -run=TestAccSSMParameter -timeout 180m
=== RUN   TestAccSSMParameterDataSource_basic
=== PAUSE TestAccSSMParameterDataSource_basic
=== RUN   TestAccSSMParameterDataSource_fullPath
=== PAUSE TestAccSSMParameterDataSource_fullPath
=== RUN   TestAccSSMParameter_basic
=== PAUSE TestAccSSMParameter_basic
=== RUN   TestAccSSMParameter_tier
=== PAUSE TestAccSSMParameter_tier
=== RUN   TestAccSSMParameter_Tier_intelligentTieringToStandard
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringToStandard
=== RUN   TestAccSSMParameter_Tier_intelligentTieringToAdvanced
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringToAdvanced
=== RUN   TestAccSSMParameter_Tier_intelligentTieringOnCreation
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringOnCreation
=== RUN   TestAccSSMParameter_Tier_intelligentTieringOnUpdate
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringOnUpdate
=== RUN   TestAccSSMParameter_disappears
=== PAUSE TestAccSSMParameter_disappears
=== RUN   TestAccSSMParameter_Overwrite_basic
=== PAUSE TestAccSSMParameter_Overwrite_basic
=== RUN   TestAccSSMParameter_Overwrite_cascade
=== PAUSE TestAccSSMParameter_Overwrite_cascade
=== RUN   TestAccSSMParameter_Overwrite_tags
=== PAUSE TestAccSSMParameter_Overwrite_tags
=== RUN   TestAccSSMParameter_Overwrite_noOverwriteTags
=== PAUSE TestAccSSMParameter_Overwrite_noOverwriteTags
=== RUN   TestAccSSMParameter_Overwrite_updateToTags
=== PAUSE TestAccSSMParameter_Overwrite_updateToTags
=== RUN   TestAccSSMParameter_tags
=== PAUSE TestAccSSMParameter_tags
=== RUN   TestAccSSMParameter_updateType
=== PAUSE TestAccSSMParameter_updateType
=== RUN   TestAccSSMParameter_Overwrite_updateDescription
=== PAUSE TestAccSSMParameter_Overwrite_updateDescription
=== RUN   TestAccSSMParameter_changeNameForcesNew
=== PAUSE TestAccSSMParameter_changeNameForcesNew
=== RUN   TestAccSSMParameter_fullPath
=== PAUSE TestAccSSMParameter_fullPath
=== RUN   TestAccSSMParameter_Secure_basic
=== PAUSE TestAccSSMParameter_Secure_basic
=== RUN   TestAccSSMParameter_Secure_insecure
=== PAUSE TestAccSSMParameter_Secure_insecure
=== RUN   TestAccSSMParameter_Secure_insecureChangeSecure
=== PAUSE TestAccSSMParameter_Secure_insecureChangeSecure
=== RUN   TestAccSSMParameter_DataType_ec2Image
=== PAUSE TestAccSSMParameter_DataType_ec2Image
=== RUN   TestAccSSMParameter_Secure_key
=== PAUSE TestAccSSMParameter_Secure_key
=== RUN   TestAccSSMParameter_Secure_keyUpdate
=== PAUSE TestAccSSMParameter_Secure_keyUpdate
=== RUN   TestAccSSMParametersByPathDataSource_basic
=== PAUSE TestAccSSMParametersByPathDataSource_basic
=== RUN   TestAccSSMParametersByPathDataSource_withRecursion
=== PAUSE TestAccSSMParametersByPathDataSource_withRecursion
=== CONT  TestAccSSMParameterDataSource_basic
=== CONT  TestAccSSMParameter_Secure_keyUpdate
--- PASS: TestAccSSMParameterDataSource_basic (27.67s)
=== CONT  TestAccSSMParametersByPathDataSource_withRecursion
--- PASS: TestAccSSMParameter_Secure_keyUpdate (34.31s)
=== CONT  TestAccSSMParametersByPathDataSource_basic
--- PASS: TestAccSSMParametersByPathDataSource_withRecursion (14.91s)
=== CONT  TestAccSSMParameter_fullPath
--- PASS: TestAccSSMParametersByPathDataSource_basic (14.54s)
=== CONT  TestAccSSMParameter_Secure_key
--- PASS: TestAccSSMParameter_fullPath (16.18s)
=== CONT  TestAccSSMParameter_Overwrite_noOverwriteTags
--- PASS: TestAccSSMParameter_Secure_key (18.41s)
=== CONT  TestAccSSMParameter_changeNameForcesNew
--- PASS: TestAccSSMParameter_Overwrite_noOverwriteTags (15.95s)
=== CONT  TestAccSSMParameter_Overwrite_updateDescription
--- PASS: TestAccSSMParameter_changeNameForcesNew (29.57s)
=== CONT  TestAccSSMParameter_DataType_ec2Image
--- PASS: TestAccSSMParameter_Overwrite_updateDescription (29.93s)
=== CONT  TestAccSSMParameter_Secure_insecureChangeSecure
--- PASS: TestAccSSMParameter_Secure_insecureChangeSecure (37.72s)
=== CONT  TestAccSSMParameter_Secure_insecure
--- PASS: TestAccSSMParameter_DataType_ec2Image (53.08s)
=== CONT  TestAccSSMParameter_Secure_basic
--- PASS: TestAccSSMParameter_Secure_basic (16.22s)
=== CONT  TestAccSSMParameter_Tier_intelligentTieringOnCreation
--- PASS: TestAccSSMParameter_Secure_insecure (40.15s)
=== CONT  TestAccSSMParameter_Overwrite_tags
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnCreation (16.99s)
=== CONT  TestAccSSMParameter_Overwrite_cascade
--- PASS: TestAccSSMParameter_Overwrite_tags (16.27s)
=== CONT  TestAccSSMParameter_Overwrite_basic
--- PASS: TestAccSSMParameter_Overwrite_cascade (35.85s)
=== CONT  TestAccSSMParameter_disappears
--- PASS: TestAccSSMParameter_Overwrite_basic (28.58s)
=== CONT  TestAccSSMParameter_Tier_intelligentTieringOnUpdate
--- PASS: TestAccSSMParameter_disappears (11.17s)
=== CONT  TestAccSSMParameter_tags
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnUpdate (25.45s)
=== CONT  TestAccSSMParameter_tier
--- PASS: TestAccSSMParameter_tags (42.20s)
=== CONT  TestAccSSMParameter_Tier_intelligentTieringToAdvanced
--- PASS: TestAccSSMParameter_tier (42.74s)
=== CONT  TestAccSSMParameter_updateType
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToAdvanced (42.68s)
=== CONT  TestAccSSMParameter_basic
--- PASS: TestAccSSMParameter_updateType (30.06s)
=== CONT  TestAccSSMParameter_Overwrite_updateToTags
--- PASS: TestAccSSMParameter_basic (18.04s)
=== CONT  TestAccSSMParameterDataSource_fullPath
=== CONT  TestAccSSMParameter_Tier_intelligentTieringToStandard
--- PASS: TestAccSSMParameterDataSource_fullPath (14.83s)
--- PASS: TestAccSSMParameter_Overwrite_updateToTags (32.12s)
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToStandard (44.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	396.515s

@YakDriver YakDriver merged commit 5c7a69d into main Jul 7, 2022
@YakDriver YakDriver deleted the f-ssm-insecure-parameter-value branch July 7, 2022 12:30
@github-actions github-actions bot added this to the v4.22.0 milestone Jul 7, 2022
github-actions bot pushed a commit that referenced this pull request Jul 7, 2022
Update CHANGELOG.md for #25721
f0d8281
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/ssm Issues and PRs that pertain to the ssm service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.22.0
Development

Successfully merging this pull request may close these issues.

Don't mark non SecureString SSM parameters as sensitive
2 participants
@YakDriver @ewbankkit