feat: add ability to set domain controller count on aws_directory_service_directory resource

[teddylear]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25050.
Closes #16455.
Closes #15186.

Description

Add domain_controller_count to aws_directory_service_directory

Output from acceptance testing:

terraform-provider-aws on  f-aws_directory_service_directory-domain-controller-count via 🐹 v1.17.3 took 2s
[I] ➜ make testacc TESTS=TestAccDSDirectoryNumberDomainControllerCount PKG=ds

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ds/... -v -count 1 -parallel 20 -run='TestAccDSDirectoryNumberDomainControllerCount'  -timeout 180m
=== RUN   TestAccDSDirectoryNumberDomainControllerCount
=== PAUSE TestAccDSDirectoryNumberDomainControllerCount
=== CONT  TestAccDSDirectoryNumberDomainControllerCount
--- PASS: TestAccDSDirectoryNumberDomainControllerCount (2435.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ds 2438.964s

[teddylear]

@ewbankkit Is there anything you want me to change here? Or are you just making more updates on top of this. I'm fine with either approach.

[ewbankkit]

@teddylear Thanks; all is good. I am using your PR as a springboard to add the directory multi-Region support - it too needs the adjustable number of domain controllers.
Just waiting for some long running acceptance tests to pass...

[ewbankkit]

LGTM 🚀.

% ACCTEST_TIMEOUT=720m AWS_ALTERNATE_REGION=us-east-2 make testacc TESTARGS='-run=TestAccDSRegion_' PKG=ds ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ds/... -v -count 1 -parallel 1  -run=TestAccDSRegion_ -timeout 720m
=== RUN   TestAccDSRegion_basic
=== PAUSE TestAccDSRegion_basic
=== RUN   TestAccDSRegion_disappears
=== PAUSE TestAccDSRegion_disappears
=== RUN   TestAccDSRegion_tags
=== PAUSE TestAccDSRegion_tags
=== RUN   TestAccDSRegion_desiredNumberOfDomainControllers
=== PAUSE TestAccDSRegion_desiredNumberOfDomainControllers
=== CONT  TestAccDSRegion_desiredNumberOfDomainControllers
--- PASS: TestAccDSRegion_desiredNumberOfDomainControllers (9050.20s)
=== CONT  TestAccDSRegion_basic
--- PASS: TestAccDSRegion_basic (5998.06s)
=== CONT  TestAccDSRegion_tags
--- PASS: TestAccDSRegion_tags (6223.99s)
=== CONT  TestAccDSRegion_disappears
--- PASS: TestAccDSRegion_disappears (9711.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ds	31046.548s
% make testacc TESTARGS='-run=TestAccDSDirectory_desiredNumberOfDomainControllers' PKG=ds ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ds/... -v -count 1 -parallel 1  -run=TestAccDSDirectory_desiredNumberOfDomainControllers -timeout 180m
=== RUN   TestAccDSDirectory_desiredNumberOfDomainControllers
=== PAUSE TestAccDSDirectory_desiredNumberOfDomainControllers
=== CONT  TestAccDSDirectory_desiredNumberOfDomainControllers
--- PASS: TestAccDSDirectory_desiredNumberOfDomainControllers (3294.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ds	3301.685s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccDSSharedDirectory_basic' PKG=ds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ds/... -v -count 1 -parallel 20  -run=TestAccDSSharedDirectory_basic -timeout 720m
=== RUN   TestAccDSSharedDirectory_basic
=== PAUSE TestAccDSSharedDirectory_basic
=== CONT  TestAccDSSharedDirectory_basic
--- PASS: TestAccDSSharedDirectory_basic (1899.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ds	1903.529s

[github-actions]

This functionality has been released in v4.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.