Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_budgets_budget: Add PlannedBudgetLimits support #25766

Closed
wants to merge 2 commits into from

Conversation

joeig
Copy link
Contributor

@joeig joeig commented Jul 11, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16798

Output from acceptance testing:

% make testacc TESTS=TestAccBudgetsBudget_plannedLimits PKG=budgets
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/budgets/... -v -count 1 -parallel 20 -run='TestAccBudgetsBudget_plannedLimits'  -timeout 180m
=== RUN   TestAccBudgetsBudget_plannedLimits
=== PAUSE TestAccBudgetsBudget_plannedLimits
=== CONT  TestAccBudgetsBudget_plannedLimits
--- PASS: TestAccBudgetsBudget_plannedLimits (47.15s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/budgets    48.794s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/budgets Issues and PRs that pertain to the budgets service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Jul 11, 2022
joeig added a commit to joeig/terraform-provider-aws that referenced this pull request Jul 11, 2022
@joeig joeig changed the title [WIP] r/aws_budgets_budget: Add PlannedBudgetLimits support r/aws_budgets_budget: Add PlannedBudgetLimits support Jul 11, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @joeig 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 20, 2022
@joeig joeig force-pushed the f-aws_budgets_budget-planned branch from 99add04 to 21ee723 Compare August 21, 2022 09:14
@ewbankkit
Copy link
Contributor

@joeig Thanks for the contribution 🎉 👏.
These changes have been rolled into #27474.

@joeig joeig deleted the f-aws_budgets_budget-planned branch October 31, 2022 19:54
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/budgets Issues and PRs that pertain to the budgets service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_budgets_budget: ability to create a recurring budget with setting PlannedBudgetLimits
3 participants