Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_s3_account_public_access_block - new data source #25781

Merged
merged 6 commits into from
Jul 15, 2022
Merged

d/aws_s3_account_public_access_block - new data source #25781

merged 6 commits into from
Jul 15, 2022

Conversation

sasidhar-aws
Copy link
Contributor

@sasidhar-aws sasidhar-aws commented Jul 12, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23783

Output from acceptance testing:

make testacc TESTS=TestAccS3ControlAccountPublicAccessBlockDataSource PKG=s3control
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run='TestAccS3ControlAccountPublicAccessBlockDataSource'  -timeout 180m
=== RUN   TestAccS3ControlAccountPublicAccessBlockDataSource_basic
=== PAUSE TestAccS3ControlAccountPublicAccessBlockDataSource_basic
=== CONT  TestAccS3ControlAccountPublicAccessBlockDataSource_basic
--- PASS: TestAccS3ControlAccountPublicAccessBlockDataSource_basic (34.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	38.429s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3control Issues and PRs that pertain to the s3control service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 12, 2022
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

github-actions[bot]
github-actions bot reviewed Jul 12, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @sasidhar-aws 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@sasidhar-aws sasidhar-aws changed the title d/aws_s3_account_public_access_block - new data source [WIP] d/aws_s3_account_public_access_block - new data source Jul 12, 2022
@sasidhar-aws sasidhar-aws marked this pull request as draft July 12, 2022 03:45
GlennChia
GlennChia suggested changes Jul 14, 2022
View reviewed changes
Copy link
Collaborator

@GlennChia GlennChia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first PR! Requesting small changes, let me know if you have questions!

internal/service/s3control/account_public_access_block_data_source.go Outdated Show resolved Hide resolved
internal/service/s3control/account_public_access_block_data_source_test.go Outdated Show resolved Hide resolved
internal/service/s3control/account_public_access_block_data_source_test.go Outdated Show resolved Hide resolved
internal/service/s3control/account_public_access_block_data_source_test.go Outdated Show resolved Hide resolved
internal/service/s3control/account_public_access_block_data_source_test.go Outdated Show resolved Hide resolved
website/docs/d/s3_account_public_access_block.html.markdown Outdated Show resolved Hide resolved
GlennChia
GlennChia suggested changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@GlennChia GlennChia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style changes requested

internal/service/s3control/account_public_access_block_data_source_test.go Outdated Show resolved Hide resolved
internal/service/s3control/account_public_access_block_data_source_test.go Outdated Show resolved Hide resolved
website/docs/d/s3_account_public_access_block.html.markdown Outdated Show resolved Hide resolved
@sasidhar-aws @GlennChia
Apply suggestions from code review
a0b63ce 
Co-authored-by: Glenn <31919569+GlennChia@users.noreply.github.com>
@sasidhar-aws sasidhar-aws changed the title [WIP] d/aws_s3_account_public_access_block - new data source d/aws_s3_account_public_access_block - new data source Jul 15, 2022
@sasidhar-aws sasidhar-aws marked this pull request as ready for review July 15, 2022 14:48
GlennChia
GlennChia approved these changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@GlennChia GlennChia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 15, 2022
ewbankkit
ewbankkit approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccS3ControlAccountPublicAccessBlockDataSource_' PKG=s3control ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3  -run=TestAccS3ControlAccountPublicAccessBlockDataSource_ -timeout 180m
=== RUN   TestAccS3ControlAccountPublicAccessBlockDataSource_basic
=== PAUSE TestAccS3ControlAccountPublicAccessBlockDataSource_basic
=== CONT  TestAccS3ControlAccountPublicAccessBlockDataSource_basic
--- PASS: TestAccS3ControlAccountPublicAccessBlockDataSource_basic (24.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	32.373s

@ewbankkit
Copy link
Contributor 

% make golangci-lint
==> Checking source code with golangci-lint...

@ewbankkit
Copy link
Contributor

@sasidhar-aws Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 2d06bd4 into hashicorp:main Jul 15, 2022
@ewbankkit ewbankkit added the new-data-source Introduces a new data source. label Jul 15, 2022
@github-actions github-actions bot added this to the v4.23.0 milestone Jul 15, 2022
@github-actions
Copy link

This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions GitHub Actions github-actions left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

@GlennChia GlennChia GlennChia approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3control Issues and PRs that pertain to the s3control service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.23.0
Development

Successfully merging this pull request may close these issues.

Data source for aws_s3_account_public_access_block
4 participants
@sasidhar-aws @ewbankkit @GlennChia @justinretzolk