-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_vpc_route_table: retry read on new resource #25793
Conversation
We are seeing failures when trying to read a newly created resource. We should retry reads in those cases to allow for eventual consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @patrickdillon 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
@patrickdillon Thanks for the contribution 🎉 👏. For the terraform-provider-aws/internal/service/ec2/vpc_route_table.go Lines 188 to 190 in 518f833
So instead of modifying terraform-provider-aws/internal/service/ec2/wait.go Lines 699 to 706 in 518f833
This will ensure that the new route table is successfully read back twice in a row before declaring that the resource is ready. |
This reverts commit d94464d.
…bleReady' and 'WaitRouteTableDeleted'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccVPCRouteTable_basic\|TestAccVPCRouteTable_ipv6' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccVPCRouteTable_basic\|TestAccVPCRouteTable_ipv6 -timeout 180m
=== RUN TestAccVPCRouteTable_basic
=== PAUSE TestAccVPCRouteTable_basic
=== RUN TestAccVPCRouteTable_ipv6ToEgressOnlyInternetGateway
=== PAUSE TestAccVPCRouteTable_ipv6ToEgressOnlyInternetGateway
=== CONT TestAccVPCRouteTable_basic
=== CONT TestAccVPCRouteTable_ipv6ToEgressOnlyInternetGateway
--- PASS: TestAccVPCRouteTable_basic (21.01s)
--- PASS: TestAccVPCRouteTable_ipv6ToEgressOnlyInternetGateway (40.82s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 44.885s
@patrickdillon Thanks for the contribution 🎉 👏. |
@ewbankkit Thanks for taking care of this! |
This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
We are seeing failures to read a newly created Route Table:
#22927 instituted retry logic for route table associations. I'm just applying that same logic here.
We should retry reads in those cases to alow for eventual consistency.
Community Note
Closes #25791
Output from acceptance testing: