Add custom timeout block to aws_db_instance_automated_backups_replication
#25796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lication` resource docs
github-actions
bot
added
needs-triage
sftim
reviewed
Jul 15, 2022
website/docs/r/db_instance_automated_backups_replication.markdown
Outdated
Show resolved
Hide resolved
ewbankkit
added
enhancement
… Group in acceptance test configurations: 'InvalidVPCNetworkStateFault: Cannot create the DB Instance because db subnet group has not been specified which is required for a private DBInstance creation'.
github-actions
bot
added
tests
ewbankkit
approved these changes
Jul 15, 2022
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRDSInstanceAutomatedBackupsReplication_' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3 -run=TestAccRDSInstanceAutomatedBackupsReplication_ -timeout 180m
=== RUN TestAccRDSInstanceAutomatedBackupsReplication_basic
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_basic
=== RUN TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod
=== RUN TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted
=== CONT TestAccRDSInstanceAutomatedBackupsReplication_basic
=== CONT TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted
=== CONT TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_basic (1305.62s)
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted (1345.83s)
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod (1365.04s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 1369.226s
|
@bschaatsbergen Thanks for the contribution 🎉 👏. |
|
Thank you @bschaatsbergen & @ewbankkit ! |
|
This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #25776
Output from acceptance testing: