r/aws_ecs_service: add triggers attribute to force update in-place

[obataku]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13931 #13528

Output from acceptance testing:

TODO

[github-actions]

Welcome @obataku 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[obataku]

would like some input regarding this approach to resolving the aforementioned issues and guidance with the PR process. thanks!

[obataku]

bump?

[tony-engineering]

+1

[YakDriver]

This makes perfect sense. At present, the force_new_deployment argument will only cause a new deployment if there are also changes to the capacity_provider_strategy. If you want a new deployment without those changes, this is a solution used elsewhere.

[YakDriver]

LGTM 🎉

% make testacc TESTS=TestAccECSService_ PKG=ecs                          
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSService_'  -timeout 180m
--- PASS: TestAccECSService_PlacementStrategy_missing (7.03s)
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (55.16s)
--- PASS: TestAccECSService_iamRole (71.14s)
--- PASS: TestAccECSService_DeploymentValues_minZeroMaxOneHundred (97.94s)
--- PASS: TestAccECSService_DeploymentControllerType_external (44.82s)
--- PASS: TestAccECSService_DeploymentValues_basic (104.16s)
--- PASS: TestAccECSService_deploymentCircuitBreaker (105.90s)
--- PASS: TestAccECSService_clusterName (106.01s)
--- PASS: TestAccECSService_PlacementConstraints_emptyExpression (106.14s)
--- PASS: TestAccECSService_forceNewDeployment (121.77s)
--- PASS: TestAccECSService_forceNewDeploymentTriggers (123.29s)
--- PASS: TestAccECSService_basic (125.27s)
--- PASS: TestAccECSService_renamedCluster (130.23s)
--- PASS: TestAccECSService_familyAndRevision (143.08s)
--- PASS: TestAccECSService_PlacementStrategy_basic (147.82s)
--- PASS: TestAccECSService_PlacementStrategy_unnormalized (81.46s)
--- PASS: TestAccECSService_LaunchTypeFargate_basic (193.95s)
--- PASS: TestAccECSService_LaunchTypeEC2_network (110.21s)
--- PASS: TestAccECSService_executeCommand (93.87s)
--- PASS: TestAccECSService_alb (248.66s)
--- PASS: TestAccECSService_multipleTargetGroups (249.23s)
--- PASS: TestAccECSService_loadBalancerChanges (252.00s)
--- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (153.12s)
--- PASS: TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState (175.60s)
--- PASS: TestAccECSService_Tags_managed (89.69s)
--- PASS: TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum (34.52s)
--- PASS: TestAccECSService_LaunchTypeFargate_waitForSteadyState (157.43s)
--- PASS: TestAccECSService_disappears (189.93s)
--- PASS: TestAccECSService_healthCheckGracePeriodSeconds (291.13s)
--- PASS: TestAccECSService_Tags_propagate (111.49s)
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (195.77s)
--- PASS: TestAccECSService_LaunchTypeFargate_platformVersion (172.75s)
--- PASS: TestAccECSService_basicImport (201.58s)
--- PASS: TestAccECSService_PlacementConstraints_basic (83.94s)
--- PASS: TestAccECSService_replicaSchedulingStrategy (77.56s)
--- PASS: TestAccECSService_Tags_basic (113.02s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (274.41s)
--- PASS: TestAccECSService_ServiceRegistries_basic (161.40s)
--- PASS: TestAccECSService_ServiceRegistries_container (161.00s)
--- PASS: TestAccECSService_ServiceRegistries_changes (287.61s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod (418.60s)
--- PASS: TestAccECSService_CapacityProviderStrategy_multiple (879.55s)
--- PASS: TestAccECSService_CapacityProviderStrategy_update (1007.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	1009.677s

[github-actions]

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.