-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/iam_role_policy: add plan time validation to role argument #26082
r/iam_role_policy: add plan time validation to role argument #26082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccIAMRolePolicy_' PKG=iam ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 3 -run=TestAccIAMRolePolicy_ -timeout 180m
=== RUN TestAccIAMRolePolicy_basic
=== PAUSE TestAccIAMRolePolicy_basic
=== RUN TestAccIAMRolePolicy_disappears
=== PAUSE TestAccIAMRolePolicy_disappears
=== RUN TestAccIAMRolePolicy_policyOrder
=== PAUSE TestAccIAMRolePolicy_policyOrder
=== RUN TestAccIAMRolePolicy_namePrefix
=== PAUSE TestAccIAMRolePolicy_namePrefix
=== RUN TestAccIAMRolePolicy_generatedName
=== PAUSE TestAccIAMRolePolicy_generatedName
=== RUN TestAccIAMRolePolicy_invalidJSON
=== PAUSE TestAccIAMRolePolicy_invalidJSON
=== RUN TestAccIAMRolePolicy_Policy_invalidResource
=== PAUSE TestAccIAMRolePolicy_Policy_invalidResource
=== CONT TestAccIAMRolePolicy_basic
=== CONT TestAccIAMRolePolicy_generatedName
=== CONT TestAccIAMRolePolicy_policyOrder
--- PASS: TestAccIAMRolePolicy_policyOrder (33.08s)
=== CONT TestAccIAMRolePolicy_namePrefix
--- PASS: TestAccIAMRolePolicy_basic (41.99s)
=== CONT TestAccIAMRolePolicy_disappears
--- PASS: TestAccIAMRolePolicy_generatedName (42.08s)
=== CONT TestAccIAMRolePolicy_invalidJSON
--- PASS: TestAccIAMRolePolicy_invalidJSON (1.82s)
=== CONT TestAccIAMRolePolicy_Policy_invalidResource
--- PASS: TestAccIAMRolePolicy_Policy_invalidResource (11.44s)
--- PASS: TestAccIAMRolePolicy_disappears (19.29s)
--- PASS: TestAccIAMRolePolicy_namePrefix (38.02s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iam 81.339s
@anGie44 Thanks for the contribution 🎉 👏. |
thanks for the review @ewbankkit !...and fixing the linting error 😅 |
This functionality has been released in v4.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #26081
Output from acceptance testing: