-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_backup_vault: Add force_destroy
argument
#26199
Conversation
Acceptance test output: % make testacc TESTARGS='-run=TestAccBackupVault_' PKG=backup ACCTEST_PARALLELISM=1 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/backup/... -v -count 1 -parallel 1 -run=TestAccBackupVault_ -timeout 180m === RUN TestAccBackupVault_basic === PAUSE TestAccBackupVault_basic === RUN TestAccBackupVault_disappears === PAUSE TestAccBackupVault_disappears === RUN TestAccBackupVault_tags === PAUSE TestAccBackupVault_tags === RUN TestAccBackupVault_withKMSKey === PAUSE TestAccBackupVault_withKMSKey === CONT TestAccBackupVault_basic --- PASS: TestAccBackupVault_basic (17.52s) === CONT TestAccBackupVault_tags --- PASS: TestAccBackupVault_tags (37.63s) === CONT TestAccBackupVault_withKMSKey --- PASS: TestAccBackupVault_withKMSKey (17.59s) === CONT TestAccBackupVault_disappears --- PASS: TestAccBackupVault_disappears (11.44s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/backup 88.100s
Acceptance test output: % make testacc TESTARGS='-run=TestAccBackupVault_forceDestroy' PKG=backup ACCTEST_PARALLELISM=1 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/backup/... -v -count 1 -parallel 1 -run=TestAccBackupVault_forceDestroy -timeout 180m === RUN TestAccBackupVault_forceDestroyEmpty === PAUSE TestAccBackupVault_forceDestroyEmpty === CONT TestAccBackupVault_forceDestroyEmpty --- PASS: TestAccBackupVault_forceDestroyEmpty (23.93s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/backup 31.410s
…oint'. Acceptance test output: % make testacc TESTARGS='-run=TestAccBackupVault_forceDestroyWithRecoveryPoint' PKG=backup ACCTEST_PARALLELISM=1 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/backup/... -v -count 1 -parallel 1 -run=TestAccBackupVault_forceDestroyWithRecoveryPoint -timeout 180m === RUN TestAccBackupVault_forceDestroyWithRecoveryPoint === PAUSE TestAccBackupVault_forceDestroyWithRecoveryPoint === CONT TestAccBackupVault_forceDestroyWithRecoveryPoint --- PASS: TestAccBackupVault_forceDestroyWithRecoveryPoint (110.64s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/backup 114.576s
Hello! Usecase: in `backup_aws_vault`, if you set the variable `vault_name` with a string of more than 50 characters, instead of a length error, it raises: `"must consist of lowercase letters, numbers, and hyphens."` I think it should raise something along the line of: `expected length of name to be in the range (1 - 50)` I think this regex is to blame (the last part of the regex): `^[a-zA-Z0-9\-\_\.]{1, 50}$` Proposed solution: Split the validation into syntax validation and length validation
This functionality has been released in v4.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #13247.