New Resources: r/`aws_networkmanager_vpc_attachment` & r/`aws_networkmanager_attachment_acceptor` #26227

drewmullen · 2022-08-10T18:40:33Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #26226.

Relates #25835.

Output from acceptance testing:

$ make testacc TESTS=TestAccNetworkManagerVpcAttachment PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerVpcAttachment'  -timeout 180m
=== RUN   TestAccNetworkManagerVpcAttachment_basic
=== PAUSE TestAccNetworkManagerVpcAttachment_basic
=== RUN   TestAccNetworkManagerVpcAttachment_tags
=== PAUSE TestAccNetworkManagerVpcAttachment_tags
=== CONT  TestAccNetworkManagerVpcAttachment_basic
=== CONT  TestAccNetworkManagerVpcAttachment_tags
--- PASS: TestAccNetworkManagerVpcAttachment_tags (1394.03s)
--- PASS: TestAccNetworkManagerVpcAttachment_basic (1623.94s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager     1627.529s
...

Notes

Accepting an attachment is required in order to delete the attachment. Attachments may not be deleted while they have a pending state AttachmentStatePendingTagAcceptance or AttachmentStatePendingAttachmentAcceptance
Tests for vpc-attachment have be put into the testfile for aws_networkmanager_attachment_acceptor because of the above requirement and because they are effectively the same tests required
There is currently a bug regarding updating the argument ipv6_support. It is not possible to currently update alone, must be updated with subnet_arn

drewmullen · 2022-08-11T12:07:46Z

$ make testacc TESTS=TestAccNetworkManagerAttachmentAcceptor PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerAttachmentAcceptor'  -timeout 180m
=== RUN   TestAccNetworkManagerAttachmentAcceptor_vpcAttachmentBasic
=== PAUSE TestAccNetworkManagerAttachmentAcceptor_vpcAttachmentBasic
=== RUN   TestAccNetworkManagerAttachmentAcceptor_vpcAttachmentTags
=== PAUSE TestAccNetworkManagerAttachmentAcceptor_vpcAttachmentTags
=== CONT  TestAccNetworkManagerAttachmentAcceptor_vpcAttachmentBasic
=== CONT  TestAccNetworkManagerAttachmentAcceptor_vpcAttachmentTags
--- PASS: TestAccNetworkManagerAttachmentAcceptor_vpcAttachmentTags (1247.46s)
--- PASS: TestAccNetworkManagerAttachmentAcceptor_vpcAttachmentBasic (1403.50s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager     1406.898s

.changelog/26227.txt

drewmullen · 2022-08-11T16:19:01Z

$ make testacc TESTS=TestAccNetworkManagerAttachmentAccepter PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerAttachmentAccepter'  -timeout 180m
=== RUN   TestAccNetworkManagerAttachmentAccepter_vpcAttachmentBasic
=== PAUSE TestAccNetworkManagerAttachmentAccepter_vpcAttachmentBasic
=== RUN   TestAccNetworkManagerAttachmentAccepter_vpcAttachmentTags
=== PAUSE TestAccNetworkManagerAttachmentAccepter_vpcAttachmentTags
=== CONT  TestAccNetworkManagerAttachmentAccepter_vpcAttachmentBasic
=== CONT  TestAccNetworkManagerAttachmentAccepter_vpcAttachmentTags
--- PASS: TestAccNetworkManagerAttachmentAccepter_vpcAttachmentTags (1301.31s)
--- PASS: TestAccNetworkManagerAttachmentAccepter_vpcAttachmentBasic (1427.20s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager     1431.028s

AdamTylerLynch

a few small changes requested

internal/service/networkmanager/vpc_attachment_test.go

drewmullen · 2022-08-15T17:51:10Z

$ make testacc TESTS=TestAccNetworkManagerVPCAttachment PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerVPCAttachment'  -timeout 180m
=== RUN   TestAccNetworkManagerVPCAttachment_basic
=== PAUSE TestAccNetworkManagerVPCAttachment_basic
=== RUN   TestAccNetworkManagerVPCAttachment_updates
=== PAUSE TestAccNetworkManagerVPCAttachment_updates
=== RUN   TestAccNetworkManagerVPCAttachment_tags
=== PAUSE TestAccNetworkManagerVPCAttachment_tags
=== CONT  TestAccNetworkManagerVPCAttachment_basic
=== CONT  TestAccNetworkManagerVPCAttachment_tags
=== CONT  TestAccNetworkManagerVPCAttachment_updates
--- PASS: TestAccNetworkManagerVPCAttachment_basic (1216.44s)
--- PASS: TestAccNetworkManagerVPCAttachment_tags (1400.23s)
--- PASS: TestAccNetworkManagerVPCAttachment_updates (1470.83s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager     1474.600s

Tests for AttachmentAccepter

$ make testacc TESTS=TestAccNetworkManagerAttachmentAccepter PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerAttachmentAccepter'  -timeout 180m
=== RUN   TestAccNetworkManagerAttachmentAccepter_vpcAttachmentBasic
=== PAUSE TestAccNetworkManagerAttachmentAccepter_vpcAttachmentBasic
=== CONT  TestAccNetworkManagerAttachmentAccepter_vpcAttachmentBasic
--- PASS: TestAccNetworkManagerAttachmentAccepter_vpcAttachmentBasic (1165.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	1169.302s

AdamTylerLynch

LGTM 🚀

…se'. Acceptance test output: % make testacc TESTARGS='-run=TestAccNetworkManagerVPCAttachment_basic' PKG=networkmanager ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 2 -run=TestAccNetworkManagerVPCAttachment_basic -timeout 180m === RUN TestAccNetworkManagerVPCAttachment_basic === PAUSE TestAccNetworkManagerVPCAttachment_basic === CONT TestAccNetworkManagerVPCAttachment_basic --- PASS: TestAccNetworkManagerVPCAttachment_basic (814.61s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager 818.609s

…ation function names.

Acceptance test output: % make testacc TESTARGS='-run=TestAccNetworkManagerVPCAttachment_' PKG=networkmanager ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 2 -run=TestAccNetworkManagerVPCAttachment_ -timeout 180m === RUN TestAccNetworkManagerVPCAttachment_basic === PAUSE TestAccNetworkManagerVPCAttachment_basic === RUN TestAccNetworkManagerVPCAttachment_disappears === PAUSE TestAccNetworkManagerVPCAttachment_disappears === RUN TestAccNetworkManagerVPCAttachment_tags === PAUSE TestAccNetworkManagerVPCAttachment_tags === RUN TestAccNetworkManagerVPCAttachment_update === PAUSE TestAccNetworkManagerVPCAttachment_update === CONT TestAccNetworkManagerVPCAttachment_basic === CONT TestAccNetworkManagerVPCAttachment_tags --- PASS: TestAccNetworkManagerVPCAttachment_basic (849.56s) === CONT TestAccNetworkManagerVPCAttachment_disappears --- PASS: TestAccNetworkManagerVPCAttachment_tags (1123.64s) === CONT TestAccNetworkManagerVPCAttachment_update --- PASS: TestAccNetworkManagerVPCAttachment_disappears (854.64s) --- PASS: TestAccNetworkManagerVPCAttachment_update (1284.73s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager 2412.205s

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccNetworkManagerVPCAttachment_' PKG=networkmanager ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 2  -run=TestAccNetworkManagerVPCAttachment_ -timeout 180m
=== RUN   TestAccNetworkManagerVPCAttachment_basic
=== PAUSE TestAccNetworkManagerVPCAttachment_basic
=== RUN   TestAccNetworkManagerVPCAttachment_disappears
=== PAUSE TestAccNetworkManagerVPCAttachment_disappears
=== RUN   TestAccNetworkManagerVPCAttachment_tags
=== PAUSE TestAccNetworkManagerVPCAttachment_tags
=== RUN   TestAccNetworkManagerVPCAttachment_update
=== PAUSE TestAccNetworkManagerVPCAttachment_update
=== CONT  TestAccNetworkManagerVPCAttachment_basic
=== CONT  TestAccNetworkManagerVPCAttachment_tags
--- PASS: TestAccNetworkManagerVPCAttachment_basic (849.56s)
=== CONT  TestAccNetworkManagerVPCAttachment_disappears
--- PASS: TestAccNetworkManagerVPCAttachment_tags (1123.64s)
=== CONT  TestAccNetworkManagerVPCAttachment_update
--- PASS: TestAccNetworkManagerVPCAttachment_disappears (854.64s)
--- PASS: TestAccNetworkManagerVPCAttachment_update (1284.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	2412.205s

ewbankkit · 2022-08-16T18:48:37Z

@drewmullen Thanks for the contribution 🎉 👏.
Overall this is great.
I made a couple of minor adjustments:

Removed the aws_networkmanager_attachment_accepter acceptance tests as the resource is being tested as part of aws_networkmanager_vpc_attachment tests
Implemented resource Read for aws_networkmanager_attachment_accepter

github-actions · 2022-08-19T12:16:49Z

This functionality has been released in v4.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-09-22T02:44:44Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

drewmullen added 4 commits August 10, 2022 11:29

initial commit for vpc_attachment and attachment_acceptor

94987ef

separate test structures

b067626

abstract attachment-acceptor to be flexible for other attachment types

bfec4c7

test file renamed to acceptor centric name

84232db

drewmullen added 7 commits August 10, 2022 14:52

cannot update ipv6 settings

2d4a9b7

changelog new r/networkmanager_vpc_attachment

99e36fe

terrafmt

ae29118

semgrep fix

b89ff3d

linting

54817eb

linting

32a9e4b

linting

f11c196

drewmullen force-pushed the f-networkmanager-vpc-attachment branch from 6da5dcd to f11c196 Compare August 11, 2022 02:47

rm unnecessary type cast

aaa7581

drewmullen mentioned this pull request Aug 11, 2022

Add support for networkmanager to peer with AWS Transit Gateway #26222

Closed

ewbankkit self-assigned this Aug 11, 2022

ewbankkit reviewed Aug 11, 2022

View reviewed changes

.changelog/26227.txt Outdated Show resolved Hide resolved

can only use ipv6 support if changing subnet_arns

0c3cd95

rename resource "accepter"

4d5fe8b

drewmullen force-pushed the f-networkmanager-vpc-attachment branch from 2bae08f to 4d5fe8b Compare August 11, 2022 16:35

drewmullen added 2 commits August 15, 2022 10:36

separate tests across resources, provide basic test

ad34837

wip

816cb75

AdamTylerLynch suggested changes Aug 15, 2022

View reviewed changes

internal/service/networkmanager/vpc_attachment_test.go Outdated Show resolved Hide resolved

diff suppres optional block

a07e413

drewmullen requested a review from AdamTylerLynch August 15, 2022 17:53

AdamTylerLynch approved these changes Aug 15, 2022

View reviewed changes

accepter does not support import

220f15c

ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 16, 2022

ewbankkit added 9 commits August 16, 2022 08:23

Merge branch 'main' into HEAD

eaa2b1c

r/aws_networkmanager_vpc_attachment: Tweaks to resource Create.

4a88eb2

r/aws_networkmanager_vpc_attachment: Tweaks to resource Read.

3650311

r/aws_networkmanager_vpc_attachment: Add 'arn' attribute.

bfb8bec

r/aws_networkmanager_vpc_attachment: Tweak resource Delete.

a56122c

r/aws_networkmanager_vpc_attachment: Correct acceptance test configur…

87402a1

…ation function names.

r/aws_networkmanager_accepter: Implement resource Read.

cb6765d

ewbankkit approved these changes Aug 16, 2022

View reviewed changes

ewbankkit added 3 commits August 16, 2022 14:49

Fix terrafmt error.

76c307e

Fix semgrep 'ci.caps5-in-func-name'.

c7f9205

Fix golangci-lint 'unparam'.

319f317

ewbankkit merged commit 650064a into hashicorp:main Aug 16, 2022

github-actions bot added this to the v4.27.0 milestone Aug 16, 2022

drewmullen deleted the f-networkmanager-vpc-attachment branch August 16, 2022 20:04

This was referenced Aug 22, 2022

r/aws_networkmanager_vpc_attachment #26226

Closed

aws_networkmanager_attachment_accepter NOT accepting the other type of attachments. #26420

Closed

github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2022

justinretzolk added the partner Contribution from a partner. label May 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resources: r/`aws_networkmanager_vpc_attachment` & r/`aws_networkmanager_attachment_acceptor` #26227

New Resources: r/`aws_networkmanager_vpc_attachment` & r/`aws_networkmanager_attachment_acceptor` #26227

drewmullen commented Aug 10, 2022 •

edited by ewbankkit

Loading

drewmullen commented Aug 11, 2022

drewmullen commented Aug 11, 2022

AdamTylerLynch left a comment

drewmullen commented Aug 15, 2022 •

edited

Loading

AdamTylerLynch left a comment

ewbankkit left a comment

ewbankkit commented Aug 16, 2022

github-actions bot commented Aug 19, 2022

github-actions bot commented Sep 22, 2022

New Resources: r/aws_networkmanager_vpc_attachment & r/aws_networkmanager_attachment_acceptor #26227

New Resources: r/aws_networkmanager_vpc_attachment & r/aws_networkmanager_attachment_acceptor #26227

Conversation

drewmullen commented Aug 10, 2022 • edited by ewbankkit Loading

Community Note

Notes

drewmullen commented Aug 11, 2022

drewmullen commented Aug 11, 2022

AdamTylerLynch left a comment

Choose a reason for hiding this comment

drewmullen commented Aug 15, 2022 • edited Loading

AdamTylerLynch left a comment

Choose a reason for hiding this comment

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Aug 16, 2022

github-actions bot commented Aug 19, 2022

github-actions bot commented Sep 22, 2022

New Resources: r/`aws_networkmanager_vpc_attachment` & r/`aws_networkmanager_attachment_acceptor` #26227

New Resources: r/`aws_networkmanager_vpc_attachment` & r/`aws_networkmanager_attachment_acceptor` #26227

drewmullen commented Aug 10, 2022 •

edited by ewbankkit

Loading

drewmullen commented Aug 15, 2022 •

edited

Loading