Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource aws_ec2_transit_gateway_policy_table and aws_ec2_transit_gateway_policy_table_association #26264

Merged

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Aug 11, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #26093.
Closes #26222.
Relates #25835.

Output from acceptance testing:

$ make testacc TESTS=TestAccTransitGatewayPolicyTable_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccTransitGatewayPolicyTable_'  -timeout 180m
=== RUN   TestAccTransitGatewayPolicyTable_basic
--- PASS: TestAccTransitGatewayPolicyTable_basic (214.53s)
=== RUN   TestAccTransitGatewayPolicyTable_disappears
--- PASS: TestAccTransitGatewayPolicyTable_disappears (193.38s)
=== RUN   TestAccTransitGatewayPolicyTable_disappears_TransitGateway
--- PASS: TestAccTransitGatewayPolicyTable_disappears_TransitGateway (208.86s)
=== RUN   TestAccTransitGatewayPolicyTable_Tags
--- PASS: TestAccTransitGatewayPolicyTable_Tags (206.53s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        825.031s

@bschaatsbergen bschaatsbergen changed the title New resource aws_ec2_transit_gateway_policy_table New resource aws_ec2_transit_gateway_policy_table and aws_ec2_transit_gateway_policy_table_association Aug 11, 2022
@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/transitgateway Issues and PRs that pertain to the transitgateway service. size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Aug 11, 2022
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Aug 11, 2022
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Aug 12, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. and removed documentation Introduces or discusses updates to documentation. labels Aug 13, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Aug 13, 2022
@bschaatsbergen
Copy link
Member Author

Almost ready for review - busy figuring out the resources I need to create for the aws_ec2_transit_gateway_policy_table_association tests.

@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 16, 2022
@ewbankkit ewbankkit added the new-data-source Introduces a new data source. label Aug 19, 2022
@ewbankkit

This comment was marked as resolved.

@ewbankkit ewbankkit added this to the v4.28.0 milestone Aug 19, 2022
@ewbankkit ewbankkit marked this pull request as ready for review August 23, 2022 19:14
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccNetworkManagerTransitGatewayRouteTableAttachment_' PKG=networkmanager ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 2  -run=TestAccNetworkManagerTransitGatewayRouteTableAttachment_ -timeout 180m
=== RUN   TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
=== PAUSE TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
=== RUN   TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears
=== PAUSE TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears
=== RUN   TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags
=== PAUSE TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags
=== CONT  TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
--- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_tags (1973.85s)
=== CONT  TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears
--- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic (2113.93s)
--- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_disappears (1678.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	3345.295s
% make testacc TESTARGS='-run=TestAccTransitGateway_serial/PolicyTableAssociation/basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGateway_serial/PolicyTableAssociation/basic -timeout 180m
=== RUN   TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/PolicyTableAssociation
=== RUN   TestAccTransitGateway_serial/PolicyTableAssociation/basic
--- PASS: TestAccTransitGateway_serial (1388.22s)
    --- PASS: TestAccTransitGateway_serial/PolicyTableAssociation (1388.22s)
        --- PASS: TestAccTransitGateway_serial/PolicyTableAssociation/basic (1388.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1392.618s
% make testacc TESTARGS='-run=TestAccTransitGateway_serial/PolicyTableAssociation/disappears' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGateway_serial/PolicyTableAssociation/disappears -timeout 180m
=== RUN   TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/PolicyTableAssociation
=== RUN   TestAccTransitGateway_serial/PolicyTableAssociation/disappears
--- PASS: TestAccTransitGateway_serial (1450.77s)
    --- PASS: TestAccTransitGateway_serial/PolicyTableAssociation (1450.77s)
        --- PASS: TestAccTransitGateway_serial/PolicyTableAssociation/disappears (1450.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1454.645s
% make testacc TESTARGS='-run=TestAccNetworkManagerTransitGatewayPeering_' PKG=networkmanager ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 2  -run=TestAccNetworkManagerTransitGatewayPeering_ -timeout 180m
=== RUN   TestAccNetworkManagerTransitGatewayPeering_basic
=== PAUSE TestAccNetworkManagerTransitGatewayPeering_basic
=== RUN   TestAccNetworkManagerTransitGatewayPeering_disappears
=== PAUSE TestAccNetworkManagerTransitGatewayPeering_disappears
=== RUN   TestAccNetworkManagerTransitGatewayPeering_tags
=== PAUSE TestAccNetworkManagerTransitGatewayPeering_tags
=== CONT  TestAccNetworkManagerTransitGatewayPeering_basic
=== CONT  TestAccNetworkManagerTransitGatewayPeering_tags
--- PASS: TestAccNetworkManagerTransitGatewayPeering_tags (1487.08s)
=== CONT  TestAccNetworkManagerTransitGatewayPeering_disappears
--- PASS: TestAccNetworkManagerTransitGatewayPeering_basic (1627.88s)
--- PASS: TestAccNetworkManagerTransitGatewayPeering_disappears (1279.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	2770.823s
% make testacc TESTARGS='-run=TestAccTransitGateway_serial/PolicyTable/basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGateway_serial/PolicyTable/basic -timeout 180m
=== RUN   TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/PolicyTable
=== RUN   TestAccTransitGateway_serial/PolicyTable/basic
=== RUN   TestAccTransitGateway_serial/PolicyTableAssociation
=== RUN   TestAccTransitGateway_serial/PolicyTableAssociation/basic
--- PASS: TestAccTransitGateway_serial (1724.02s)
    --- PASS: TestAccTransitGateway_serial/PolicyTable (200.15s)
        --- PASS: TestAccTransitGateway_serial/PolicyTable/basic (200.15s)
    --- PASS: TestAccTransitGateway_serial/PolicyTableAssociation (1523.87s)
        --- PASS: TestAccTransitGateway_serial/PolicyTableAssociation/basic (1523.87s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1728.558s

@github-actions
Copy link

This functionality has been released in v4.28.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2022
@bschaatsbergen bschaatsbergen deleted the r/transit-gateway-policy-table branch September 26, 2022 07:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/networkmanager Issues and PRs that pertain to the networkmanager service. service/transitgateway Issues and PRs that pertain to the transitgateway service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for networkmanager to peer with AWS Transit Gateway New resource: Transit Gateway policy table
2 participants