Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to create aws_dms_endpoint Redis target #26266

Closed
peresypkinroman opened this issue Aug 12, 2022 · 2 comments · Fixed by #26411
Closed

Unable to create aws_dms_endpoint Redis target #26266

peresypkinroman opened this issue Aug 12, 2022 · 2 comments · Fixed by #26411
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/dms Issues and PRs that pertain to the dms service.
Milestone

Comments

@peresypkinroman
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform 1.1.8
AWS provider v4.25.0

Affected Resource(s)

  • aws_dms_endpoint

Terraform Configuration Files

resource "aws_dms_endpoint" "reccommender_elasticache_endpoint_target" {
  endpoint_id   = local.recommender_elasticache_target_endpoint
  endpoint_type = "target"
  engine_name   = "redis"

  server_name = data.aws_ssm_parameter.primary_endpoint_address.value
  port        = 6379
}

Seems like go code does not form request properly.
RedisSettings are not present in the request.
https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/dms/endpoint.go#L824
Might be wrong correct me if so.

Debug Output

Json request to create endpoint

 {"EndpointIdentifier":"recommender-elasticache-redis-target","EndpointType":"target","EngineName":"redis","Password":"","Port":6379,"ServerName":"recommender-elasticache.eredaj.ng.0001.euc1.cache.amazonaws.com","Tags":[{"Key":"DeleteAfter","Value":"-"},{"Key":"Temporary","Value":"false"},{"Key":"Stream","Value":"BI-AP"},{"Key":"Project","Value":"ingest/dms"},{"Key":"Team","Value":"dwh"},{"Key":"Env","Value":"stage"},{"Key":"Owner","Value":"DWH"},{"Key":"Terraform","Value":"true"},{"Key":"map-migrated","Value":"d-server-03dn4ss3b8hq0r"}],"Username":""}

Expected Behavior

pland and apply pass and resources are created

Actual Behavior

│ Error: creating DMS Endpoint (recommender-elasticache-redis-target): InvalidParameterCombinationException: Server name and port are only allowed as ServerName and Port in RedisSettings
│ 	status code: 400, request id: 3d700f79-e029-4f4f-88e4-c52905d4ace7
│
│   with aws_dms_endpoint.reccommender_elasticache_endpoint_target,
│   on endpoints.tf line 113, in resource "aws_dms_endpoint" "reccommender_elasticache_endpoint_target":
│  113: resource "aws_dms_endpoint" "reccommender_elasticache_endpoint_target" {

Steps to Reproduce

Create output resource run apply

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/dms Issues and PRs that pertain to the dms service. labels Aug 12, 2022
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 18, 2022
@github-actions github-actions bot added this to the v4.29.0 milestone Aug 29, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This functionality has been released in v4.29.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/dms Issues and PRs that pertain to the dms service.
Projects
None yet
2 participants