Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b/aws_organizations_policy_allow_nonSCP_content #26279

Conversation

RonaldTechnative
Copy link
Contributor

@RonaldTechnative RonaldTechnative commented Aug 12, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25977

Output from acceptance testing:

These tests do not test DiffSuppressFunc switch. Can someone help me with that?

ronald@Ronalds-MacBook-Pro terraform-provider-aws % make testacc TESTS=TestAccPolicy_type PKG=organizations 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/organizations/... -v -count 1 -parallel 20 -run='TestAccPolicy_type'  -timeout 180m
=== RUN   TestAccPolicy_type_AI_OPT_OUT
--- PASS: TestAccPolicy_type_AI_OPT_OUT (32.89s)
=== RUN   TestAccPolicy_type_Backup
--- PASS: TestAccPolicy_type_Backup (29.82s)
=== RUN   TestAccPolicy_type_SCP
--- PASS: TestAccPolicy_type_SCP (47.49s)
=== RUN   TestAccPolicy_type_Tag
--- PASS: TestAccPolicy_type_Tag (30.45s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/organizations      142.246s

...

@github-actions github-actions bot added service/organizations Issues and PRs that pertain to the organizations service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Aug 12, 2022
@github-actions
Copy link

Hey @RonaldTechnative 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

@RonaldTechnative
Copy link
Contributor Author

RonaldTechnative commented Aug 12, 2022

Hey @RonaldTechnative 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

I'm unable to do this. I'm not able to find this, I can give individual maintainers access if required.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Aug 12, 2022
@RonaldTechnative RonaldTechnative changed the title [WIP]: #25977: We cannot handle all policies as SCP policies. #25977: We cannot handle all policies as SCP policies. Aug 12, 2022
@RonaldTechnative RonaldTechnative changed the title #25977: We cannot handle all policies as SCP policies. b/aws_organizations_policy_allow_nonSCP_content Aug 13, 2022
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 18, 2022
@ewbankkit
Copy link
Contributor

@RonaldTechnative Thanks for the contribution 🎉 👏.
As maintainers do not have permissions to push changes to this fork I created a new PR - #26456 - with your changes, reverting the final commit that changes the test names.

@ewbankkit ewbankkit closed this Aug 23, 2022
@RonaldTechnative
Copy link
Contributor Author

@RonaldTechnative Thanks for the contribution 🎉 👏. As maintainers do not have permissions to push changes to this fork I created a new PR - #26456 - with your changes, reverting the final commit that changes the test names.

If you revert the test name changes then they will not be included when trying to test this module. Is that your intended goal of the revert?

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/organizations Issues and PRs that pertain to the organizations service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_organizations_policy Invalid parameter: minimum field size of 1, CreatePolicyInput.Content.
3 participants