Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_networkfirewall_firewall: new attributes #26284

Conversation

cjtroiano
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #26148

Output from acceptance testing:

$ make testacc TESTS=TestAccNetworkFirewallFirewallDataSource PKG=networkfirewall
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 20 -run='TestAccNetworkFirewallFirewallDataSource'  -timeout 180m
=== RUN   TestAccNetworkFirewallFirewallDataSource_arn
=== PAUSE TestAccNetworkFirewallFirewallDataSource_arn
=== RUN   TestAccNetworkFirewallFirewallDataSource_name
=== PAUSE TestAccNetworkFirewallFirewallDataSource_name
=== RUN   TestAccNetworkFirewallFirewallDataSource_arnandname
=== PAUSE TestAccNetworkFirewallFirewallDataSource_arnandname
=== CONT  TestAccNetworkFirewallFirewallDataSource_arn
=== CONT  TestAccNetworkFirewallFirewallDataSource_arnandname
=== CONT  TestAccNetworkFirewallFirewallDataSource_name
--- PASS: TestAccNetworkFirewallFirewallDataSource_arn (748.66s)
--- PASS: TestAccNetworkFirewallFirewallDataSource_name (757.42s)
--- PASS: TestAccNetworkFirewallFirewallDataSource_arnandname (758.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	760.118s

This pr is missing a test case for capacity_usage_summary. To my knowledge, the only way to get capacity_usage_summary to come back from describe-firewall, is to link a managed prefix list to a firewall stateful rule. It doesn't look like that is currently possible with this provider. If I'm mistaken, or someone has an alternate solution, I would greatly appreciate it!

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Aug 12, 2022
@cjtroiano cjtroiano force-pushed the f-aws_networkfirewall_firewall-new-attributes branch from b073aaf to bb6d0a4 Compare August 13, 2022 00:12
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 15, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccNetworkFirewallFirewallDataSource_' PKG=networkfirewall ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 2  -run=TestAccNetworkFirewallFirewallDataSource_ -timeout 180m
=== RUN   TestAccNetworkFirewallFirewallDataSource_arn
=== PAUSE TestAccNetworkFirewallFirewallDataSource_arn
=== RUN   TestAccNetworkFirewallFirewallDataSource_name
=== PAUSE TestAccNetworkFirewallFirewallDataSource_name
=== RUN   TestAccNetworkFirewallFirewallDataSource_arnandname
=== PAUSE TestAccNetworkFirewallFirewallDataSource_arnandname
=== CONT  TestAccNetworkFirewallFirewallDataSource_arn
=== CONT  TestAccNetworkFirewallFirewallDataSource_arnandname
--- PASS: TestAccNetworkFirewallFirewallDataSource_arn (624.95s)
=== CONT  TestAccNetworkFirewallFirewallDataSource_name
--- PASS: TestAccNetworkFirewallFirewallDataSource_arnandname (635.88s)
--- PASS: TestAccNetworkFirewallFirewallDataSource_name (629.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	1262.211s

@ewbankkit
Copy link
Contributor

@cjtroiano Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 4e219a3 into hashicorp:main Aug 16, 2022
@github-actions github-actions bot added this to the v4.27.0 milestone Aug 16, 2022
@github-actions
Copy link

This functionality has been released in v4.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new attributes to AWS Network Firewall Datasource
3 participants