-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_networkfirewall_firewall: new attributes #26284
d/aws_networkfirewall_firewall: new attributes #26284
Conversation
b073aaf
to
bb6d0a4
Compare
… 0 or 2; Actual: 1]'.
…'ci.caps1-in-func-name'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccNetworkFirewallFirewallDataSource_' PKG=networkfirewall ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 2 -run=TestAccNetworkFirewallFirewallDataSource_ -timeout 180m
=== RUN TestAccNetworkFirewallFirewallDataSource_arn
=== PAUSE TestAccNetworkFirewallFirewallDataSource_arn
=== RUN TestAccNetworkFirewallFirewallDataSource_name
=== PAUSE TestAccNetworkFirewallFirewallDataSource_name
=== RUN TestAccNetworkFirewallFirewallDataSource_arnandname
=== PAUSE TestAccNetworkFirewallFirewallDataSource_arnandname
=== CONT TestAccNetworkFirewallFirewallDataSource_arn
=== CONT TestAccNetworkFirewallFirewallDataSource_arnandname
--- PASS: TestAccNetworkFirewallFirewallDataSource_arn (624.95s)
=== CONT TestAccNetworkFirewallFirewallDataSource_name
--- PASS: TestAccNetworkFirewallFirewallDataSource_arnandname (635.88s)
--- PASS: TestAccNetworkFirewallFirewallDataSource_name (629.30s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall 1262.211s
@cjtroiano Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates OR Closes #26148
Output from acceptance testing:
This pr is missing a test case for
capacity_usage_summary
. To my knowledge, the only way to getcapacity_usage_summary
to come back from describe-firewall, is to link a managed prefix list to a firewall stateful rule. It doesn't look like that is currently possible with this provider. If I'm mistaken, or someone has an alternate solution, I would greatly appreciate it!