Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_db_instance: Don't call ModifyDBInstance when just final_snapshot_identifier is changed #26286

Merged
merged 9 commits into from
Aug 15, 2022
Merged

r/aws_db_instance: Don't call ModifyDBInstance when just final_snapshot_identifier is changed #26286

merged 9 commits into from
Aug 15, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Aug 12, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #26280.

% make testacc TESTARGS='-run=TestAccRDSInstance_finalSnapshotIdentifier\|TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot\|TestAccRDSInstance_noDeleteAutomatedBackups\|TestAccRDSInstance_basic\|TestAccRDSInstance_isAlreadyBeingDeleted' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSInstance_finalSnapshotIdentifier\|TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot\|TestAccRDSInstance_noDeleteAutomatedBackups\|TestAccRDSInstance_basic\|TestAccRDSInstance_isAlreadyBeingDeleted -timeout 180m
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN   TestAccRDSInstance_finalSnapshotIdentifier
=== PAUSE TestAccRDSInstance_finalSnapshotIdentifier
=== RUN   TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot
=== PAUSE TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot
=== RUN   TestAccRDSInstance_isAlreadyBeingDeleted
=== PAUSE TestAccRDSInstance_isAlreadyBeingDeleted
=== RUN   TestAccRDSInstance_noDeleteAutomatedBackups
=== PAUSE TestAccRDSInstance_noDeleteAutomatedBackups
=== CONT  TestAccRDSInstance_basic
=== CONT  TestAccRDSInstance_isAlreadyBeingDeleted
--- PASS: TestAccRDSInstance_isAlreadyBeingDeleted (356.31s)
=== CONT  TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot
--- PASS: TestAccRDSInstance_basic (530.53s)
=== CONT  TestAccRDSInstance_finalSnapshotIdentifier
--- PASS: TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot (879.82s)
=== CONT  TestAccRDSInstance_noDeleteAutomatedBackups
--- PASS: TestAccRDSInstance_finalSnapshotIdentifier (971.29s)
--- PASS: TestAccRDSInstance_noDeleteAutomatedBackups (652.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1892.981s

@ewbankkit
Add 'FindDBSnapshotByID'.
ad384ad
@ewbankkit
r/aws_db_instance: Fix 'InvalidParameterCombination: No modifications…
11584ef 
… were requested' if only 'delete_automated_backups', 'final_snapshot_identifier' and/or 'skip_final_snapshot' change.
@ewbankkit
TestAccRDSInstance_finalSnapshotIdentifier: Test updating just 'final…
d285e0a 
…_snapshot_identifier'.
@github-actions github-actions bot added service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Aug 12, 2022
@ewbankkit
Update find.go
0b8127b
@ewbankkit
'testAccCheckInstanceSnapshot' -> 'testAccCheckInstanceDestroyWithFin…
342c64b 
…alSnapshot'.
@ewbankkit
Merge branch 'b-aws_db_instance-update-just-final_snapshot_identifier…
ea95986 
…' of https://github.com/hashicorp/terraform-provider-aws into b-aws_db_instance-update-just-final_snapshot_identifier
@ewbankkit
r/aws_db_instance: 'testAccCheckInstanceNoSnapshot' -> 'testAccCheckI…
b87dd80 
…nstanceDestroyWithoutFinalSnapshot'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSInstance_finalSnapshotIdentifier\|TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSInstance_finalSnapshotIdentifier\|TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot -timeout 180m
=== RUN   TestAccRDSInstance_finalSnapshotIdentifier
=== PAUSE TestAccRDSInstance_finalSnapshotIdentifier
=== RUN   TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot
=== PAUSE TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot
=== CONT  TestAccRDSInstance_finalSnapshotIdentifier
=== CONT  TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot
--- PASS: TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot (773.20s)
--- PASS: TestAccRDSInstance_finalSnapshotIdentifier (953.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	957.747s
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Aug 15, 2022
@ewbankkit ewbankkit marked this pull request as ready for review August 15, 2022 13:44
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. labels Aug 15, 2022
@ewbankkit ewbankkit merged commit e4ddc58 into main Aug 15, 2022
@ewbankkit ewbankkit deleted the b-aws_db_instance-update-just-final_snapshot_identifier branch August 15, 2022 14:59
@github-actions github-actions bot added this to the v4.27.0 milestone Aug 15, 2022
@github-actions
Copy link

This functionality has been released in v4.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.27.0
Development

Successfully merging this pull request may close these issues.

resource/aws_db_instance: Modifying only the final_snapshot_identifier returns error in v4.26.0
1 participant
@ewbankkit