r/aws_connect_phone_number

[GlennChia]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #26015

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccConnect_serial/PhoneNumber' PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20  -run=TestAccConnect_serial/PhoneNumber -timeout 180m
=== RUN   TestAccConnect_serial
=== RUN   TestAccConnect_serial/PhoneNumber
=== RUN   TestAccConnect_serial/PhoneNumber/prefix
=== RUN   TestAccConnect_serial/PhoneNumber/targetARN
=== RUN   TestAccConnect_serial/PhoneNumber/basic
=== RUN   TestAccConnect_serial/PhoneNumber/disappears
=== RUN   TestAccConnect_serial/PhoneNumber/tags
=== RUN   TestAccConnect_serial/PhoneNumber/description
--- PASS: TestAccConnect_serial (616.97s)
    --- PASS: TestAccConnect_serial/PhoneNumber (616.97s)
        --- PASS: TestAccConnect_serial/PhoneNumber/prefix (97.80s)
        --- PASS: TestAccConnect_serial/PhoneNumber/targetARN (116.53s)
        --- PASS: TestAccConnect_serial/PhoneNumber/basic (94.70s)
        --- PASS: TestAccConnect_serial/PhoneNumber/disappears (90.76s)
        --- PASS: TestAccConnect_serial/PhoneNumber/tags (122.56s)
        --- PASS: TestAccConnect_serial/PhoneNumber/description (94.62s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    617.031s

...

[schuylr]

Thanks for the PR! I think this is a great first pass, but there are some levels of control that are being restricted from the Terraform operator.

I believe the core thing to allow would be the option to provide a full phone_number per the ClaimPhoneNumber API.

More than happy to contribute to this with access provided to your branch.

[schuylr]

Discussed offline with @GlennChia about proceeding with this functionality for now. Will create another fast-follow issue to allow support for direct phone_number supplying.

Will also need to create two data sources which also depend on this PR. Will link issues as pending from this PR as well!

Thanks for the awesome discussion!

[schuylr]

Quick linter fix suggestion

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccConnect_serial/PhoneNumber' PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20  -run=TestAccConnect_serial/PhoneNumber -timeout 180m
=== RUN   TestAccConnect_serial
=== RUN   TestAccConnect_serial/PhoneNumber
=== RUN   TestAccConnect_serial/PhoneNumber/tags
=== RUN   TestAccConnect_serial/PhoneNumber/description
=== RUN   TestAccConnect_serial/PhoneNumber/prefix
=== RUN   TestAccConnect_serial/PhoneNumber/targetARN
=== RUN   TestAccConnect_serial/PhoneNumber/basic
=== RUN   TestAccConnect_serial/PhoneNumber/disappears
--- PASS: TestAccConnect_serial (744.97s)
    --- PASS: TestAccConnect_serial/PhoneNumber (744.97s)
        --- PASS: TestAccConnect_serial/PhoneNumber/tags (238.51s)
        --- PASS: TestAccConnect_serial/PhoneNumber/description (101.66s)
        --- PASS: TestAccConnect_serial/PhoneNumber/prefix (101.36s)
        --- PASS: TestAccConnect_serial/PhoneNumber/targetARN (124.27s)
        --- PASS: TestAccConnect_serial/PhoneNumber/basic (91.41s)
        --- PASS: TestAccConnect_serial/PhoneNumber/disappears (87.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	749.183s

[ewbankkit]

@GlennChia Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.