-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EC2-Classic retirement phase 1: Resource and attribute deprecation #26427
Conversation
…classic_link_security_groups'.
…assic_link_to_remote_vpc' and 'allow_vpc_to_remote_classic_link'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🎉
% make testacc TESTARGS='-run=TestAccVPC_basic\|TestAccVPCPeeringConnection_basic\|TestAccVPCPeeringConnectionAccepter_sameRegionSameAccount\|TestAccVPCPeeringConnectionOptions_basic' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPC_basic\|TestAccVPCPeeringConnection_basic\|TestAccVPCPeeringConnectionAccepter_sameRegionSameAccount\|TestAccVPCPeeringConnectionOptions_basic -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.44.80
--- PASS: TestAccVPCPeeringConnection_basic (47.76s)
--- PASS: TestAccVPCPeeringConnectionAccepter_sameRegionSameAccount (48.22s)
--- PASS: TestAccVPC_basic (42.51s)
--- PASS: TestAccVPCPeeringConnectionOptions_basic (84.31s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 133.794s
% make testacc TESTARGS='-run=TestAccAutoScalingLaunchConfiguration_basic' PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2 -run=TestAccAutoScalingLaunchConfiguration_basic -timeout 180m
--- PASS: TestAccAutoScalingLaunchConfiguration_basic (40.68s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 42.390s
% make testacc TESTARGS='-run=TestAccRedshiftCluster_basic' PKG=redshift ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 2 -run=TestAccRedshiftCluster_basic -timeout 180m
--- PASS: TestAccRedshiftCluster_basic (261.73s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/redshift 263.158s
% make testacc TESTARGS='-run=TestAccElastiCacheCluster_Engine_memcached' PKG=elasticache ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2 -run=TestAccElastiCacheCluster_Engine_memcached -timeout 180m
--- PASS: TestAccElastiCacheCluster_Engine_memcached (526.24s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 527.818s
This functionality has been released in v4.28.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #23625.
With the retirement of EC2-Classic various resources and resource attributes are now deprecated.