Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add target_capacity_unit_type to ec2_fleet and ec2_spot_fleet_request resources #26493

Merged
merged 5 commits into from
Aug 29, 2022
Merged

feat: add target_capacity_unit_type to ec2_fleet and ec2_spot_fleet_request resources #26493

merged 5 commits into from
Aug 29, 2022

Conversation

teddylear
Copy link
Contributor

@teddylear teddylear commented Aug 26, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

feat: add target_capacity_unit_type to ec2_fleet and ec2_spot_fleet_request resources
Closes #25777

Output from acceptance testing:

terraform-provider-aws on  f-aws_ec2_fleet-aws_spot_fleet_request-add-target_capacity_unit_type [!] via 🐹 v1.18.4 took 2s
[I] ➜ make testacc TESTS=TestAccEC2Fleet_TargetCapacitySpecification_targetCapacityUnitType PKG=ec2

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Fleet_TargetCapacitySpecification_targetCapacityUnitType'
-timeout 180m
=== RUN   TestAccEC2Fleet_TargetCapacitySpecification_targetCapacityUnitType
=== PAUSE TestAccEC2Fleet_TargetCapacitySpecification_targetCapacityUnitType
=== CONT  TestAccEC2Fleet_TargetCapacitySpecification_targetCapacityUnitType
--- PASS: TestAccEC2Fleet_TargetCapacitySpecification_targetCapacityUnitType (435.09s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        438.463s
terraform-provider-aws on  f-aws_ec2_fleet-aws_spot_fleet_request-add-target_capacity_unit_type [!] via 🐹 v1.18.4 took 3s
[I] ➜ make testacc TESTS=TestAccEC2SpotFleetRequest_targetCapacityUnitType PKG=ec2

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SpotFleetRequest_targetCapacityUnitType'  -timeout 180m
=== RUN   TestAccEC2SpotFleetRequest_targetCapacityUnitType
=== PAUSE TestAccEC2SpotFleetRequest_targetCapacityUnitType
=== CONT  TestAccEC2SpotFleetRequest_targetCapacityUnitType
--- PASS: TestAccEC2SpotFleetRequest_targetCapacityUnitType (203.27s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        206.555s

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Aug 26, 2022
@teddylear teddylear changed the title [WIP] aws ec2 fleet aws spot fleet request add target capacity unit type [WIP] feat: add target_capacity_unit_type to ec2_fleet and ec2_spot_fleet_request resources Aug 26, 2022
@teddylear teddylear changed the title [WIP] feat: add target_capacity_unit_type to ec2_fleet and ec2_spot_fleet_request resources feat: add target_capacity_unit_type to ec2_fleet and ec2_spot_fleet_request resources Aug 26, 2022
@teddylear teddylear marked this pull request as ready for review August 26, 2022 00:50
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 26, 2022
ewbankkit
ewbankkit approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

 make testacc TESTARGS='-run=TestAccEC2Fleet_\|TestAccEC2SpotFleetRequest_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccEC2Fleet_\|TestAccEC2SpotFleetRequest_ -timeout 180m
=== RUN   TestAccEC2Fleet_basic
=== PAUSE TestAccEC2Fleet_basic
=== RUN   TestAccEC2Fleet_disappears
=== PAUSE TestAccEC2Fleet_disappears
=== RUN   TestAccEC2Fleet_tags
=== PAUSE TestAccEC2Fleet_tags
=== RUN   TestAccEC2Fleet_excessCapacityTerminationPolicy
=== PAUSE TestAccEC2Fleet_excessCapacityTerminationPolicy
=== RUN   TestAccEC2Fleet_LaunchTemplateLaunchTemplateSpecification_launchTemplateID
=== PAUSE TestAccEC2Fleet_LaunchTemplateLaunchTemplateSpecification_launchTemplateID
=== RUN   TestAccEC2Fleet_LaunchTemplateLaunchTemplateSpecification_launchTemplateName
=== PAUSE TestAccEC2Fleet_LaunchTemplateLaunchTemplateSpecification_launchTemplateName
=== RUN   TestAccEC2Fleet_LaunchTemplateLaunchTemplateSpecification_version
=== PAUSE TestAccEC2Fleet_LaunchTemplateLaunchTemplateSpecification_version
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_availabilityZone
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_availabilityZone
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_memoryMiBAndVCPUCount
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_memoryMiBAndVCPUCount
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorCount
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorCount
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorManufacturers
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorManufacturers
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorNames
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorNames
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorTotalMemoryMiB
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorTotalMemoryMiB
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorTypes
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorTypes
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_bareMetal
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_bareMetal
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_baselineEBSBandwidthMbps
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_baselineEBSBandwidthMbps
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_burstablePerformance
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_burstablePerformance
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_cpuManufacturers
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_cpuManufacturers
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_excludedInstanceTypes
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_excludedInstanceTypes
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_instanceGenerations
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_instanceGenerations
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_localStorage
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_localStorage
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_localStorageTypes
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_localStorageTypes
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_memoryGiBPerVCPU
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_memoryGiBPerVCPU
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_networkInterfaceCount
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_networkInterfaceCount
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_onDemandMaxPricePercentageOverLowestPrice
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_onDemandMaxPricePercentageOverLowestPrice
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_requireHibernateSupport
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_requireHibernateSupport
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_spotMaxPricePercentageOverLowestPrice
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_spotMaxPricePercentageOverLowestPrice
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_totalLocalStorageGB
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_totalLocalStorageGB
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_instanceType
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_instanceType
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_maxPrice
    acctest.go:69: EC2 API is not correctly returning MaxPrice override
--- SKIP: TestAccEC2Fleet_LaunchTemplateOverride_maxPrice (0.00s)
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_priority
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_priority
=== RUN   TestAccEC2Fleet_LaunchTemplateOverridePriority_multiple
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverridePriority_multiple
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_subnetID
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_subnetID
=== RUN   TestAccEC2Fleet_LaunchTemplateOverride_weightedCapacity
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverride_weightedCapacity
=== RUN   TestAccEC2Fleet_LaunchTemplateOverrideWeightedCapacity_multiple
=== PAUSE TestAccEC2Fleet_LaunchTemplateOverrideWeightedCapacity_multiple
=== RUN   TestAccEC2Fleet_OnDemandOptions_allocationStrategy
=== PAUSE TestAccEC2Fleet_OnDemandOptions_allocationStrategy
=== RUN   TestAccEC2Fleet_replaceUnhealthyInstances
=== PAUSE TestAccEC2Fleet_replaceUnhealthyInstances
=== RUN   TestAccEC2Fleet_SpotOptions_allocationStrategy
=== PAUSE TestAccEC2Fleet_SpotOptions_allocationStrategy
=== RUN   TestAccEC2Fleet_SpotOptions_capacityRebalance
=== PAUSE TestAccEC2Fleet_SpotOptions_capacityRebalance
=== RUN   TestAccEC2Fleet_capacityRebalanceInvalidType
=== PAUSE TestAccEC2Fleet_capacityRebalanceInvalidType
=== RUN   TestAccEC2Fleet_SpotOptions_instanceInterruptionBehavior
=== PAUSE TestAccEC2Fleet_SpotOptions_instanceInterruptionBehavior
=== RUN   TestAccEC2Fleet_SpotOptions_instancePoolsToUseCount
=== PAUSE TestAccEC2Fleet_SpotOptions_instancePoolsToUseCount
=== RUN   TestAccEC2Fleet_TargetCapacitySpecification_defaultTargetCapacityType
=== PAUSE TestAccEC2Fleet_TargetCapacitySpecification_defaultTargetCapacityType
=== RUN   TestAccEC2Fleet_TargetCapacitySpecificationDefaultTargetCapacityType_onDemand
=== PAUSE TestAccEC2Fleet_TargetCapacitySpecificationDefaultTargetCapacityType_onDemand
=== RUN   TestAccEC2Fleet_TargetCapacitySpecificationDefaultTargetCapacityType_spot
=== PAUSE TestAccEC2Fleet_TargetCapacitySpecificationDefaultTargetCapacityType_spot
=== RUN   TestAccEC2Fleet_TargetCapacitySpecification_totalTargetCapacity
=== PAUSE TestAccEC2Fleet_TargetCapacitySpecification_totalTargetCapacity
=== RUN   TestAccEC2Fleet_TargetCapacitySpecification_targetCapacityUnitType
=== PAUSE TestAccEC2Fleet_TargetCapacitySpecification_targetCapacityUnitType
=== RUN   TestAccEC2Fleet_terminateInstancesWithExpiration
=== PAUSE TestAccEC2Fleet_terminateInstancesWithExpiration
=== RUN   TestAccEC2Fleet_type
=== PAUSE TestAccEC2Fleet_type
=== RUN   TestAccEC2Fleet_templateMultipleNetworkInterfaces
=== PAUSE TestAccEC2Fleet_templateMultipleNetworkInterfaces
=== RUN   TestAccEC2SpotFleetRequest_basic
=== PAUSE TestAccEC2SpotFleetRequest_basic
=== RUN   TestAccEC2SpotFleetRequest_targetCapacityUnitType
=== PAUSE TestAccEC2SpotFleetRequest_targetCapacityUnitType
=== RUN   TestAccEC2SpotFleetRequest_disappears
=== PAUSE TestAccEC2SpotFleetRequest_disappears
=== RUN   TestAccEC2SpotFleetRequest_tags
=== PAUSE TestAccEC2SpotFleetRequest_tags
=== RUN   TestAccEC2SpotFleetRequest_associatePublicIPAddress
=== PAUSE TestAccEC2SpotFleetRequest_associatePublicIPAddress
=== RUN   TestAccEC2SpotFleetRequest_launchTemplate
=== PAUSE TestAccEC2SpotFleetRequest_launchTemplate
=== RUN   TestAccEC2SpotFleetRequest_LaunchTemplate_multiple
=== PAUSE TestAccEC2SpotFleetRequest_LaunchTemplate_multiple
=== RUN   TestAccEC2SpotFleetRequest_launchTemplateWithInstanceTypeOverrides
=== PAUSE TestAccEC2SpotFleetRequest_launchTemplateWithInstanceTypeOverrides
=== RUN   TestAccEC2SpotFleetRequest_launchTemplateWithInstanceRequirementsOverrides
=== PAUSE TestAccEC2SpotFleetRequest_launchTemplateWithInstanceRequirementsOverrides
=== RUN   TestAccEC2SpotFleetRequest_launchTemplateToLaunchSpec
=== PAUSE TestAccEC2SpotFleetRequest_launchTemplateToLaunchSpec
=== RUN   TestAccEC2SpotFleetRequest_launchSpecToLaunchTemplate
=== PAUSE TestAccEC2SpotFleetRequest_launchSpecToLaunchTemplate
=== RUN   TestAccEC2SpotFleetRequest_onDemandTargetCapacity
=== PAUSE TestAccEC2SpotFleetRequest_onDemandTargetCapacity
=== RUN   TestAccEC2SpotFleetRequest_onDemandMaxTotalPrice
=== PAUSE TestAccEC2SpotFleetRequest_onDemandMaxTotalPrice
=== RUN   TestAccEC2SpotFleetRequest_onDemandAllocationStrategy
=== PAUSE TestAccEC2SpotFleetRequest_onDemandAllocationStrategy
=== RUN   TestAccEC2SpotFleetRequest_instanceInterruptionBehavior
=== PAUSE TestAccEC2SpotFleetRequest_instanceInterruptionBehavior
=== RUN   TestAccEC2SpotFleetRequest_fleetType
=== PAUSE TestAccEC2SpotFleetRequest_fleetType
=== RUN   TestAccEC2SpotFleetRequest_iamInstanceProfileARN
=== PAUSE TestAccEC2SpotFleetRequest_iamInstanceProfileARN
=== RUN   TestAccEC2SpotFleetRequest_changePriceForcesNewRequest
=== PAUSE TestAccEC2SpotFleetRequest_changePriceForcesNewRequest
=== RUN   TestAccEC2SpotFleetRequest_updateTargetCapacity
=== PAUSE TestAccEC2SpotFleetRequest_updateTargetCapacity
=== RUN   TestAccEC2SpotFleetRequest_updateExcessCapacityTerminationPolicy
=== PAUSE TestAccEC2SpotFleetRequest_updateExcessCapacityTerminationPolicy
=== RUN   TestAccEC2SpotFleetRequest_lowestPriceAzOrSubnetInRegion
=== PAUSE TestAccEC2SpotFleetRequest_lowestPriceAzOrSubnetInRegion
=== RUN   TestAccEC2SpotFleetRequest_lowestPriceAzInGivenList
=== PAUSE TestAccEC2SpotFleetRequest_lowestPriceAzInGivenList
=== RUN   TestAccEC2SpotFleetRequest_lowestPriceSubnetInGivenList
=== PAUSE TestAccEC2SpotFleetRequest_lowestPriceSubnetInGivenList
=== RUN   TestAccEC2SpotFleetRequest_multipleInstanceTypesInSameAz
=== PAUSE TestAccEC2SpotFleetRequest_multipleInstanceTypesInSameAz
=== RUN   TestAccEC2SpotFleetRequest_multipleInstanceTypesInSameSubnet
=== PAUSE TestAccEC2SpotFleetRequest_multipleInstanceTypesInSameSubnet
=== RUN   TestAccEC2SpotFleetRequest_overridingSpotPrice
=== PAUSE TestAccEC2SpotFleetRequest_overridingSpotPrice
=== RUN   TestAccEC2SpotFleetRequest_withoutSpotPrice
=== PAUSE TestAccEC2SpotFleetRequest_withoutSpotPrice
=== RUN   TestAccEC2SpotFleetRequest_diversifiedAllocation
=== PAUSE TestAccEC2SpotFleetRequest_diversifiedAllocation
=== RUN   TestAccEC2SpotFleetRequest_multipleInstancePools
=== PAUSE TestAccEC2SpotFleetRequest_multipleInstancePools
=== RUN   TestAccEC2SpotFleetRequest_withWeightedCapacity
=== PAUSE TestAccEC2SpotFleetRequest_withWeightedCapacity
=== RUN   TestAccEC2SpotFleetRequest_withEBSDisk
=== PAUSE TestAccEC2SpotFleetRequest_withEBSDisk
=== RUN   TestAccEC2SpotFleetRequest_LaunchSpecificationEBSBlockDevice_kmsKeyID
=== PAUSE TestAccEC2SpotFleetRequest_LaunchSpecificationEBSBlockDevice_kmsKeyID
=== RUN   TestAccEC2SpotFleetRequest_LaunchSpecificationRootBlockDevice_kmsKeyID
=== PAUSE TestAccEC2SpotFleetRequest_LaunchSpecificationRootBlockDevice_kmsKeyID
=== RUN   TestAccEC2SpotFleetRequest_LaunchSpecification_ebsBlockDeviceGP3
=== PAUSE TestAccEC2SpotFleetRequest_LaunchSpecification_ebsBlockDeviceGP3
=== RUN   TestAccEC2SpotFleetRequest_LaunchSpecification_rootBlockDeviceGP3
=== PAUSE TestAccEC2SpotFleetRequest_LaunchSpecification_rootBlockDeviceGP3
=== RUN   TestAccEC2SpotFleetRequest_withTags
=== PAUSE TestAccEC2SpotFleetRequest_withTags
=== RUN   TestAccEC2SpotFleetRequest_placementTenancyAndGroup
=== PAUSE TestAccEC2SpotFleetRequest_placementTenancyAndGroup
=== RUN   TestAccEC2SpotFleetRequest_withELBs
=== PAUSE TestAccEC2SpotFleetRequest_withELBs
=== RUN   TestAccEC2SpotFleetRequest_withTargetGroups
=== PAUSE TestAccEC2SpotFleetRequest_withTargetGroups
=== RUN   TestAccEC2SpotFleetRequest_Zero_capacity
=== PAUSE TestAccEC2SpotFleetRequest_Zero_capacity
=== RUN   TestAccEC2SpotFleetRequest_capacityRebalance
=== PAUSE TestAccEC2SpotFleetRequest_capacityRebalance
=== RUN   TestAccEC2SpotFleetRequest_withInstanceStoreAMI
    acctest.go:69: Test fails due to test harness constraints
--- SKIP: TestAccEC2SpotFleetRequest_withInstanceStoreAMI (0.00s)
=== RUN   TestAccEC2SpotFleetRequest_noTerminateInstancesWithExpiration
=== PAUSE TestAccEC2SpotFleetRequest_noTerminateInstancesWithExpiration
=== CONT  TestAccEC2Fleet_basic
=== CONT  TestAccEC2Fleet_terminateInstancesWithExpiration
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_networkInterfaceCount
--- PASS: TestAccEC2Fleet_basic (47.83s)
=== CONT  TestAccEC2Fleet_TargetCapacitySpecification_targetCapacityUnitType
--- PASS: TestAccEC2Fleet_terminateInstancesWithExpiration (87.08s)
=== CONT  TestAccEC2Fleet_TargetCapacitySpecification_totalTargetCapacity
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_networkInterfaceCount (173.55s)
=== CONT  TestAccEC2Fleet_TargetCapacitySpecificationDefaultTargetCapacityType_spot
--- PASS: TestAccEC2Fleet_TargetCapacitySpecificationDefaultTargetCapacityType_spot (42.89s)
=== CONT  TestAccEC2Fleet_TargetCapacitySpecificationDefaultTargetCapacityType_onDemand
--- PASS: TestAccEC2Fleet_TargetCapacitySpecificationDefaultTargetCapacityType_onDemand (43.75s)
=== CONT  TestAccEC2Fleet_TargetCapacitySpecification_defaultTargetCapacityType
--- PASS: TestAccEC2Fleet_TargetCapacitySpecification_defaultTargetCapacityType (80.25s)
=== CONT  TestAccEC2Fleet_SpotOptions_instancePoolsToUseCount
--- PASS: TestAccEC2Fleet_SpotOptions_instancePoolsToUseCount (82.86s)
=== CONT  TestAccEC2Fleet_SpotOptions_instanceInterruptionBehavior
--- PASS: TestAccEC2Fleet_TargetCapacitySpecification_targetCapacityUnitType (413.48s)
=== CONT  TestAccEC2Fleet_capacityRebalanceInvalidType
--- PASS: TestAccEC2Fleet_capacityRebalanceInvalidType (4.41s)
=== CONT  TestAccEC2Fleet_SpotOptions_capacityRebalance
--- PASS: TestAccEC2Fleet_SpotOptions_instanceInterruptionBehavior (80.50s)
=== CONT  TestAccEC2Fleet_SpotOptions_allocationStrategy
--- PASS: TestAccEC2Fleet_SpotOptions_capacityRebalance (43.16s)
=== CONT  TestAccEC2Fleet_replaceUnhealthyInstances
--- PASS: TestAccEC2Fleet_TargetCapacitySpecification_totalTargetCapacity (472.15s)
=== CONT  TestAccEC2Fleet_OnDemandOptions_allocationStrategy
--- PASS: TestAccEC2Fleet_SpotOptions_allocationStrategy (81.96s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverrideWeightedCapacity_multiple
--- PASS: TestAccEC2Fleet_replaceUnhealthyInstances (80.59s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_weightedCapacity
--- PASS: TestAccEC2Fleet_OnDemandOptions_allocationStrategy (84.08s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_totalLocalStorageGB
--- PASS: TestAccEC2Fleet_LaunchTemplateOverrideWeightedCapacity_multiple (102.20s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_spotMaxPricePercentageOverLowestPrice
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_weightedCapacity (101.21s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_requireHibernateSupport
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_spotMaxPricePercentageOverLowestPrice (43.17s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_onDemandMaxPricePercentageOverLowestPrice
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_onDemandMaxPricePercentageOverLowestPrice (44.78s)
=== CONT  TestAccEC2SpotFleetRequest_lowestPriceAzOrSubnetInRegion
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_requireHibernateSupport (103.96s)
=== CONT  TestAccEC2SpotFleetRequest_noTerminateInstancesWithExpiration
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_totalLocalStorageGB (166.57s)
=== CONT  TestAccEC2SpotFleetRequest_capacityRebalance
--- PASS: TestAccEC2SpotFleetRequest_lowestPriceAzOrSubnetInRegion (139.71s)
=== CONT  TestAccEC2SpotFleetRequest_Zero_capacity
--- PASS: TestAccEC2SpotFleetRequest_noTerminateInstancesWithExpiration (138.33s)
=== CONT  TestAccEC2SpotFleetRequest_withTargetGroups
--- PASS: TestAccEC2SpotFleetRequest_capacityRebalance (130.09s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceType
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceType (100.21s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_subnetID
--- PASS: TestAccEC2SpotFleetRequest_Zero_capacity (205.39s)
=== CONT  TestAccEC2SpotFleetRequest_withELBs
=== CONT  TestAccEC2SpotFleetRequest_withTargetGroups
    ec2_spot_fleet_request_test.go:1519: Step 1/2 error: Error running apply: exit status 1
        
        Error: waiting for EC2 Spot Fleet Request (sfr-4a22a5b7-4702-46f8-8454-3a594586d8bb) fulfillment: unexpected state 'error', wanted target 'fulfilled'. last error: 1 error occurred:
        	* {
          EventInformation: {
            EventDescription: "m3.large, ami-00413793e4d8a02c8, Linux/UNIX: There is no Spot capacity available that matches your request.",
            EventSubType: "spotFleetRequestConfigurationInvalid"
          },
          EventType: "error",
          Timestamp: 2022-08-26 17:08:19 +0000 UTC
        }
        
        
        
          with aws_spot_fleet_request.test,
          on terraform_plugin_test.tf line 159, in resource "aws_spot_fleet_request" "test":
         159: resource "aws_spot_fleet_request" "test" {
     
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_subnetID (107.82s)
=== CONT  TestAccEC2SpotFleetRequest_placementTenancyAndGroup
=== CONT  TestAccEC2SpotFleetRequest_withTags
=== CONT  TestAccEC2SpotFleetRequest_withELBs
    ec2_spot_fleet_request_test.go:1483: Step 1/2 error: Error running apply: exit status 1
        
        Error: waiting for EC2 Spot Fleet Request (sfr-03719faa-9133-41bc-9ac6-55e252895269) fulfillment: unexpected state 'error', wanted target 'fulfilled'. last error: 1 error occurred:
        	* {
          EventInformation: {
            EventDescription: "m3.large, ami-00413793e4d8a02c8, Linux/UNIX: There is no Spot capacity available that matches your request.",
            EventSubType: "spotFleetRequestConfigurationInvalid"
          },
          EventType: "error",
          Timestamp: 2022-08-26 17:05:56 +0000 UTC
        }
        
        
        
          with aws_spot_fleet_request.test,
          on terraform_plugin_test.tf line 148, in resource "aws_spot_fleet_request" "test":
         148: resource "aws_spot_fleet_request" "test" {

--- FAIL: TestAccEC2SpotFleetRequest_withELBs (154.85s)
--- PASS: TestAccEC2SpotFleetRequest_placementTenancyAndGroup (81.37s)
=== CONT  TestAccEC2SpotFleetRequest_LaunchSpecification_rootBlockDeviceGP3
=== CONT  TestAccEC2SpotFleetRequest_LaunchSpecification_ebsBlockDeviceGP3
--- PASS: TestAccEC2SpotFleetRequest_withTags (130.21s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverridePriority_multiple
--- PASS: TestAccEC2SpotFleetRequest_LaunchSpecification_rootBlockDeviceGP3 (129.33s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_priority
--- PASS: TestAccEC2SpotFleetRequest_LaunchSpecification_ebsBlockDeviceGP3 (142.47s)
=== CONT  TestAccEC2SpotFleetRequest_LaunchSpecificationRootBlockDevice_kmsKeyID
--- PASS: TestAccEC2Fleet_LaunchTemplateOverridePriority_multiple (101.70s)
=== CONT  TestAccEC2SpotFleetRequest_withoutSpotPrice
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_priority (101.36s)
=== CONT  TestAccEC2SpotFleetRequest_overridingSpotPrice
--- PASS: TestAccEC2SpotFleetRequest_LaunchSpecificationRootBlockDevice_kmsKeyID (135.05s)
=== CONT  TestAccEC2SpotFleetRequest_multipleInstanceTypesInSameSubnet
--- PASS: TestAccEC2SpotFleetRequest_withoutSpotPrice (134.88s)
=== CONT  TestAccEC2SpotFleetRequest_LaunchSpecificationEBSBlockDevice_kmsKeyID
--- PASS: TestAccEC2SpotFleetRequest_overridingSpotPrice (134.41s)
=== CONT  TestAccEC2SpotFleetRequest_multipleInstanceTypesInSameAz
--- PASS: TestAccEC2SpotFleetRequest_LaunchSpecificationEBSBlockDevice_kmsKeyID (144.17s)
=== CONT  TestAccEC2SpotFleetRequest_withEBSDisk
--- PASS: TestAccEC2SpotFleetRequest_multipleInstanceTypesInSameSubnet (181.01s)
=== CONT  TestAccEC2SpotFleetRequest_lowestPriceSubnetInGivenList
--- PASS: TestAccEC2SpotFleetRequest_multipleInstanceTypesInSameAz (135.26s)
=== CONT  TestAccEC2SpotFleetRequest_withWeightedCapacity
--- PASS: TestAccEC2SpotFleetRequest_withEBSDisk (135.16s)
=== CONT  TestAccEC2SpotFleetRequest_multipleInstancePools
--- PASS: TestAccEC2SpotFleetRequest_lowestPriceSubnetInGivenList (177.43s)
=== CONT  TestAccEC2SpotFleetRequest_diversifiedAllocation
--- PASS: TestAccEC2SpotFleetRequest_withWeightedCapacity (257.62s)
=== CONT  TestAccEC2SpotFleetRequest_lowestPriceAzInGivenList
--- PASS: TestAccEC2SpotFleetRequest_multipleInstancePools (133.01s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorTotalMemoryMiB
--- PASS: TestAccEC2SpotFleetRequest_diversifiedAllocation (193.02s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_excludedInstanceTypes
--- PASS: TestAccEC2SpotFleetRequest_lowestPriceAzInGivenList (131.95s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_cpuManufacturers
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_excludedInstanceTypes (107.69s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_memoryGiBPerVCPU
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorTotalMemoryMiB (170.23s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_localStorageTypes
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_cpuManufacturers (106.68s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_burstablePerformance
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_localStorageTypes (105.64s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_localStorage
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_memoryGiBPerVCPU (167.26s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_baselineEBSBandwidthMbps
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_burstablePerformance (166.61s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_instanceGenerations
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_localStorage (165.95s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_bareMetal
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_instanceGenerations (104.46s)
=== CONT  TestAccEC2SpotFleetRequest_tags
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_baselineEBSBandwidthMbps (166.71s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorTypes
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorTypes (105.49s)
=== CONT  TestAccEC2SpotFleetRequest_launchTemplateWithInstanceRequirementsOverrides
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_bareMetal (170.94s)
=== CONT  TestAccEC2SpotFleetRequest_LaunchTemplate_multiple
--- PASS: TestAccEC2SpotFleetRequest_tags (186.16s)
=== CONT  TestAccEC2SpotFleetRequest_launchTemplate
--- PASS: TestAccEC2SpotFleetRequest_launchTemplateWithInstanceRequirementsOverrides (137.48s)
=== CONT  TestAccEC2SpotFleetRequest_launchTemplateWithInstanceTypeOverrides
--- PASS: TestAccEC2SpotFleetRequest_LaunchTemplate_multiple (136.02s)
=== CONT  TestAccEC2SpotFleetRequest_associatePublicIPAddress
--- PASS: TestAccEC2SpotFleetRequest_launchTemplate (130.01s)
=== CONT  TestAccEC2SpotFleetRequest_launchTemplateToLaunchSpec
--- PASS: TestAccEC2SpotFleetRequest_launchTemplateWithInstanceTypeOverrides (138.71s)
=== CONT  TestAccEC2Fleet_LaunchTemplateLaunchTemplateSpecification_version
--- PASS: TestAccEC2SpotFleetRequest_associatePublicIPAddress (139.29s)
=== CONT  TestAccEC2SpotFleetRequest_instanceInterruptionBehavior
--- PASS: TestAccEC2Fleet_LaunchTemplateLaunchTemplateSpecification_version (103.48s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorNames
--- PASS: TestAccEC2SpotFleetRequest_launchTemplateToLaunchSpec (255.80s)
=== CONT  TestAccEC2SpotFleetRequest_onDemandAllocationStrategy
--- PASS: TestAccEC2SpotFleetRequest_instanceInterruptionBehavior (131.52s)
=== CONT  TestAccEC2SpotFleetRequest_fleetType
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorNames (105.51s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorManufacturers
--- PASS: TestAccEC2SpotFleetRequest_onDemandAllocationStrategy (131.28s)
=== CONT  TestAccEC2SpotFleetRequest_updateExcessCapacityTerminationPolicy
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorManufacturers (105.67s)
=== CONT  TestAccEC2SpotFleetRequest_updateTargetCapacity
--- PASS: TestAccEC2SpotFleetRequest_fleetType (140.71s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorCount
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_acceleratorCount (172.95s)
=== CONT  TestAccEC2SpotFleetRequest_changePriceForcesNewRequest
--- PASS: TestAccEC2SpotFleetRequest_updateExcessCapacityTerminationPolicy (255.05s)
=== CONT  TestAccEC2SpotFleetRequest_onDemandMaxTotalPrice
--- PASS: TestAccEC2SpotFleetRequest_updateTargetCapacity (360.04s)
=== CONT  TestAccEC2SpotFleetRequest_iamInstanceProfileARN
--- PASS: TestAccEC2SpotFleetRequest_onDemandMaxTotalPrice (139.24s)
=== CONT  TestAccEC2SpotFleetRequest_onDemandTargetCapacity
--- PASS: TestAccEC2SpotFleetRequest_changePriceForcesNewRequest (247.88s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_availabilityZone
--- PASS: TestAccEC2SpotFleetRequest_iamInstanceProfileARN (141.69s)
=== CONT  TestAccEC2SpotFleetRequest_launchSpecToLaunchTemplate
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_availabilityZone (102.70s)
=== CONT  TestAccEC2Fleet_LaunchTemplateLaunchTemplateSpecification_launchTemplateName
--- PASS: TestAccEC2SpotFleetRequest_onDemandTargetCapacity (244.34s)
=== CONT  TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_memoryMiBAndVCPUCount
--- PASS: TestAccEC2Fleet_LaunchTemplateLaunchTemplateSpecification_launchTemplateName (104.95s)
=== CONT  TestAccEC2Fleet_LaunchTemplateLaunchTemplateSpecification_launchTemplateID
--- PASS: TestAccEC2Fleet_LaunchTemplateLaunchTemplateSpecification_launchTemplateID (101.79s)
=== CONT  TestAccEC2Fleet_disappears
--- PASS: TestAccEC2Fleet_LaunchTemplateOverride_instanceRequirements_memoryMiBAndVCPUCount (104.89s)
=== CONT  TestAccEC2SpotFleetRequest_basic
--- PASS: TestAccEC2SpotFleetRequest_launchSpecToLaunchTemplate (243.73s)
=== CONT  TestAccEC2Fleet_tags
--- PASS: TestAccEC2Fleet_disappears (42.30s)
=== CONT  TestAccEC2SpotFleetRequest_targetCapacityUnitType
--- PASS: TestAccEC2Fleet_tags (90.29s)
=== CONT  TestAccEC2SpotFleetRequest_disappears
--- PASS: TestAccEC2SpotFleetRequest_basic (142.99s)
=== CONT  TestAccEC2Fleet_templateMultipleNetworkInterfaces
--- PASS: TestAccEC2SpotFleetRequest_disappears (137.78s)
=== CONT  TestAccEC2Fleet_excessCapacityTerminationPolicy
--- PASS: TestAccEC2SpotFleetRequest_targetCapacityUnitType (253.87s)
=== CONT  TestAccEC2Fleet_type
--- PASS: TestAccEC2Fleet_excessCapacityTerminationPolicy (102.53s)
--- PASS: TestAccEC2Fleet_type (43.04s)
--- PASS: TestAccEC2Fleet_templateMultipleNetworkInterfaces (544.23s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	4635.896s

Failures are unrelated to this change.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Aug 26, 2022
@ewbankkit ewbankkit added this to the v4.29.0 milestone Aug 26, 2022
@ewbankkit
Copy link
Contributor

@teddylear Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 1e0efe0 into hashicorp:main Aug 29, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This functionality has been released in v4.29.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.29.0
Development

Successfully merging this pull request may close these issues.

Support capacity unit types for aws_ec2_fleet and aws_spot_fleet_request
2 participants
@teddylear @ewbankkit