-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_eks_node_group: Add capacity_type attribute #26521
d/aws_eks_node_group: Add capacity_type attribute #26521
Conversation
Hey @Vrtak-CZ 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.) |
4a73b4b
to
44f30cb
Compare
I'm letting you know I do not know how to enable this in our organization. |
44f30cb
to
bea2db6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEKSNodeGroupDataSource_' PKG=eks ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 3 -run=TestAccEKSNodeGroupDataSource_ -timeout 180m
=== RUN TestAccEKSNodeGroupDataSource_basic
--- PASS: TestAccEKSNodeGroupDataSource_basic (1033.20s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/eks 1037.207s
@Vrtak-CZ Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.29.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Output from acceptance testing: