aws_network_interface_attachment: Add import functionality

[jpbuecken]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Please implement terraform import for aws_network_interface_attachment.

We cannot use the attachment block of aws_network_interface that support import already.
It does not support a detach (just deleting the attachment block does not result in changes)
We need to have more control about attaching and detaching of nics.
Use cases:

• Migrate a nic from instance A to instance B.
• Rebuild the instance from newer image, but keep all nics as it. Used for some upgrades.
• Using aws_network_interface_attachment is similar to aws_volume_attachment, so the concept is known and similar concepts make code more understandable.

Since there is code to refresh the state file, a READ functionality is already in place. (at least for aws_network_interface)
And so I assume the import functionality is not too much to ask for it, isn't it?

New or Affected Resource(s)

• aws_network_interface_attachment

Potential Terraform Configuration

resource "aws_instance" "instance" {
}
resource "aws_network_interface" "secondary_nic" {
}
resource "aws_network_interface_attachment" "secondary_nic" {
  instance_id          = aws_instance.instance.id
  network_interface_id = aws_network_interface.secondary_nic.id
  device_index         = 1
}

If someone want to import, maybe lookup the attachment_id in statefile from an already imported nic:

terraform import aws_network_interface_attachment.secondary_nic eni-attach-123456789

or maybe with a nic_id/instance_id combination:

terraform import aws_network_interface_attachment.secondary_nic eni-xxxxxxxxxxxxxx/i-xxxxxxxxxxxxxx

References

[github-actions]

This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.