Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datasource aws_ec2_managed_prefix_lists #26727

Merged

Conversation

aleksanderaleksic
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccVPCManagedPrefixListsDataSource PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCManagedPrefixListsDataSource'  -timeout 180m
=== RUN   TestAccVPCManagedPrefixListsDataSource_basic
=== PAUSE TestAccVPCManagedPrefixListsDataSource_basic
=== RUN   TestAccVPCManagedPrefixListsDataSource_filter_tags
=== PAUSE TestAccVPCManagedPrefixListsDataSource_filter_tags
=== RUN   TestAccVPCManagedPrefixListsDataSource_noMatches
=== PAUSE TestAccVPCManagedPrefixListsDataSource_noMatches
=== CONT  TestAccVPCManagedPrefixListsDataSource_basic
=== CONT  TestAccVPCManagedPrefixListsDataSource_noMatches
=== CONT  TestAccVPCManagedPrefixListsDataSource_filter_tags
--- PASS: TestAccVPCManagedPrefixListsDataSource_noMatches (16.74s)
--- PASS: TestAccVPCManagedPrefixListsDataSource_basic (17.06s)
--- PASS: TestAccVPCManagedPrefixListsDataSource_filter_tags (43.96s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        45.648s
...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/vpc Issues and PRs that pertain to the vpc service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 9, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 12, 2022
@ewbankkit ewbankkit added the new-data-source Introduces a new data source. label Sep 12, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCManagedPrefixListsDataSource_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCManagedPrefixListsDataSource_ -timeout 180m
=== RUN   TestAccVPCManagedPrefixListsDataSource_basic
=== PAUSE TestAccVPCManagedPrefixListsDataSource_basic
=== RUN   TestAccVPCManagedPrefixListsDataSource_tags
=== PAUSE TestAccVPCManagedPrefixListsDataSource_tags
=== RUN   TestAccVPCManagedPrefixListsDataSource_noMatches
=== PAUSE TestAccVPCManagedPrefixListsDataSource_noMatches
=== CONT  TestAccVPCManagedPrefixListsDataSource_basic
=== CONT  TestAccVPCManagedPrefixListsDataSource_noMatches
--- PASS: TestAccVPCManagedPrefixListsDataSource_noMatches (17.48s)
=== CONT  TestAccVPCManagedPrefixListsDataSource_tags
--- PASS: TestAccVPCManagedPrefixListsDataSource_basic (17.78s)
--- PASS: TestAccVPCManagedPrefixListsDataSource_tags (26.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	51.085s

@ewbankkit
Copy link
Contributor

@aleksanderaleksic Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 2b65aac into hashicorp:main Sep 12, 2022
@github-actions github-actions bot added this to the v4.31.0 milestone Sep 12, 2022
@github-actions
Copy link

This functionality has been released in v4.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/vpc Issues and PRs that pertain to the vpc service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants