-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression issue: Allow SSM parameter overwrite upon creation #26785
Regression issue: Allow SSM parameter overwrite upon creation #26785
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSSMParameter_' PKG=ssm ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 2 -run=TestAccSSMParameter_ -timeout 180m
=== RUN TestAccSSMParameter_basic
=== PAUSE TestAccSSMParameter_basic
=== RUN TestAccSSMParameter_tier
=== PAUSE TestAccSSMParameter_tier
=== RUN TestAccSSMParameter_Tier_intelligentTieringToStandard
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringToStandard
=== RUN TestAccSSMParameter_Tier_intelligentTieringToAdvanced
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringToAdvanced
=== RUN TestAccSSMParameter_Tier_intelligentTieringOnCreation
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringOnCreation
=== RUN TestAccSSMParameter_Tier_intelligentTieringOnUpdate
=== PAUSE TestAccSSMParameter_Tier_intelligentTieringOnUpdate
=== RUN TestAccSSMParameter_disappears
=== PAUSE TestAccSSMParameter_disappears
=== RUN TestAccSSMParameter_Overwrite_basic
=== PAUSE TestAccSSMParameter_Overwrite_basic
=== RUN TestAccSSMParameter_Overwrite_cascade
=== PAUSE TestAccSSMParameter_Overwrite_cascade
=== RUN TestAccSSMParameter_Overwrite_tags
=== PAUSE TestAccSSMParameter_Overwrite_tags
=== RUN TestAccSSMParameter_Overwrite_noOverwriteTags
=== PAUSE TestAccSSMParameter_Overwrite_noOverwriteTags
=== RUN TestAccSSMParameter_Overwrite_updateToTags
=== PAUSE TestAccSSMParameter_Overwrite_updateToTags
=== RUN TestAccSSMParameter_tags
=== PAUSE TestAccSSMParameter_tags
=== RUN TestAccSSMParameter_updateType
=== PAUSE TestAccSSMParameter_updateType
=== RUN TestAccSSMParameter_Overwrite_updateDescription
=== PAUSE TestAccSSMParameter_Overwrite_updateDescription
=== RUN TestAccSSMParameter_changeNameForcesNew
=== PAUSE TestAccSSMParameter_changeNameForcesNew
=== RUN TestAccSSMParameter_fullPath
=== PAUSE TestAccSSMParameter_fullPath
=== RUN TestAccSSMParameter_Secure_basic
=== PAUSE TestAccSSMParameter_Secure_basic
=== RUN TestAccSSMParameter_Secure_insecure
=== PAUSE TestAccSSMParameter_Secure_insecure
=== RUN TestAccSSMParameter_Secure_insecureChangeSecure
=== PAUSE TestAccSSMParameter_Secure_insecureChangeSecure
=== RUN TestAccSSMParameter_DataType_ec2Image
=== PAUSE TestAccSSMParameter_DataType_ec2Image
=== RUN TestAccSSMParameter_Secure_key
=== PAUSE TestAccSSMParameter_Secure_key
=== RUN TestAccSSMParameter_Secure_keyUpdate
=== PAUSE TestAccSSMParameter_Secure_keyUpdate
=== CONT TestAccSSMParameter_basic
=== CONT TestAccSSMParameter_tags
--- PASS: TestAccSSMParameter_basic (20.53s)
=== CONT TestAccSSMParameter_disappears
--- PASS: TestAccSSMParameter_disappears (14.56s)
=== CONT TestAccSSMParameter_Overwrite_updateToTags
--- PASS: TestAccSSMParameter_tags (47.99s)
=== CONT TestAccSSMParameter_Overwrite_noOverwriteTags
--- PASS: TestAccSSMParameter_Overwrite_updateToTags (30.81s)
=== CONT TestAccSSMParameter_Overwrite_tags
--- PASS: TestAccSSMParameter_Overwrite_noOverwriteTags (18.02s)
=== CONT TestAccSSMParameter_Overwrite_cascade
--- PASS: TestAccSSMParameter_Overwrite_tags (24.44s)
=== CONT TestAccSSMParameter_Overwrite_basic
--- PASS: TestAccSSMParameter_Overwrite_cascade (50.68s)
=== CONT TestAccSSMParameter_Tier_intelligentTieringToAdvanced
--- PASS: TestAccSSMParameter_Overwrite_basic (63.35s)
=== CONT TestAccSSMParameter_Tier_intelligentTieringOnUpdate
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToAdvanced (72.38s)
=== CONT TestAccSSMParameter_Tier_intelligentTieringOnCreation
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnUpdate (45.79s)
=== CONT TestAccSSMParameter_Secure_insecure
--- PASS: TestAccSSMParameter_Tier_intelligentTieringOnCreation (30.27s)
=== CONT TestAccSSMParameter_Secure_keyUpdate
--- PASS: TestAccSSMParameter_Secure_insecure (70.41s)
=== CONT TestAccSSMParameter_Secure_key
--- PASS: TestAccSSMParameter_Secure_keyUpdate (51.85s)
=== CONT TestAccSSMParameter_DataType_ec2Image
--- PASS: TestAccSSMParameter_Secure_key (28.96s)
=== CONT TestAccSSMParameter_Secure_insecureChangeSecure
--- PASS: TestAccSSMParameter_DataType_ec2Image (50.48s)
=== CONT TestAccSSMParameter_changeNameForcesNew
--- PASS: TestAccSSMParameter_Secure_insecureChangeSecure (65.28s)
=== CONT TestAccSSMParameter_Secure_basic
--- PASS: TestAccSSMParameter_changeNameForcesNew (49.96s)
=== CONT TestAccSSMParameter_fullPath
--- PASS: TestAccSSMParameter_Secure_basic (32.82s)
=== CONT TestAccSSMParameter_Tier_intelligentTieringToStandard
--- PASS: TestAccSSMParameter_fullPath (32.27s)
=== CONT TestAccSSMParameter_updateType
--- PASS: TestAccSSMParameter_updateType (47.91s)
=== CONT TestAccSSMParameter_tier
--- PASS: TestAccSSMParameter_Tier_intelligentTieringToStandard (66.43s)
=== CONT TestAccSSMParameter_Overwrite_updateDescription
--- PASS: TestAccSSMParameter_Overwrite_updateDescription (41.27s)
--- PASS: TestAccSSMParameter_tier (58.31s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ssm 515.061s
@bschaatsbergen Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #25335
Regression bug
This issue was flagged after releasing v4.18.0 through #25335
I've reverted the commit.
Output from acceptance testing: