Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_ec2_managed_prefix_list - Fix: MaxEntries and Entry can be changed in same apply #26845

Merged
merged 7 commits into from
Sep 22, 2022
Merged

r/aws_ec2_managed_prefix_list - Fix: MaxEntries and Entry can be changed in same apply #26845

merged 7 commits into from
Sep 22, 2022

Conversation

drewmullen
Copy link
Collaborator

@drewmullen drewmullen commented Sep 16, 2022 •
edited

Closes #26639

Output from acceptance testing:

$ make testacc TESTS=TestAccVPCManagedPrefixList PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCManagedPrefixList'  -timeout 180m
=== RUN   TestAccVPCManagedPrefixListDataSource_basic
=== PAUSE TestAccVPCManagedPrefixListDataSource_basic
=== RUN   TestAccVPCManagedPrefixListDataSource_filter
=== PAUSE TestAccVPCManagedPrefixListDataSource_filter
=== RUN   TestAccVPCManagedPrefixListDataSource_matchesTooMany
=== PAUSE TestAccVPCManagedPrefixListDataSource_matchesTooMany
=== RUN   TestAccVPCManagedPrefixListEntry_ipv4
=== PAUSE TestAccVPCManagedPrefixListEntry_ipv4
=== RUN   TestAccVPCManagedPrefixListEntry_ipv4Multiple
=== PAUSE TestAccVPCManagedPrefixListEntry_ipv4Multiple
=== RUN   TestAccVPCManagedPrefixListEntry_ipv6
=== PAUSE TestAccVPCManagedPrefixListEntry_ipv6
=== RUN   TestAccVPCManagedPrefixListEntry_expectInvalidTypeError
=== PAUSE TestAccVPCManagedPrefixListEntry_expectInvalidTypeError
=== RUN   TestAccVPCManagedPrefixListEntry_expectInvalidCIDR
=== PAUSE TestAccVPCManagedPrefixListEntry_expectInvalidCIDR
=== RUN   TestAccVPCManagedPrefixListEntry_description
=== PAUSE TestAccVPCManagedPrefixListEntry_description
=== RUN   TestAccVPCManagedPrefixListEntry_disappears
=== PAUSE TestAccVPCManagedPrefixListEntry_disappears
=== RUN   TestAccVPCManagedPrefixList_basic
=== PAUSE TestAccVPCManagedPrefixList_basic
=== RUN   TestAccVPCManagedPrefixList_disappears
=== PAUSE TestAccVPCManagedPrefixList_disappears
=== RUN   TestAccVPCManagedPrefixList_AddressFamily_ipv6
=== PAUSE TestAccVPCManagedPrefixList_AddressFamily_ipv6
=== RUN   TestAccVPCManagedPrefixList_Entry_cidr
=== PAUSE TestAccVPCManagedPrefixList_Entry_cidr
=== RUN   TestAccVPCManagedPrefixList_Entry_description
=== PAUSE TestAccVPCManagedPrefixList_Entry_description
=== RUN   TestAccVPCManagedPrefixList_updateEntryAndMaxEntry
=== PAUSE TestAccVPCManagedPrefixList_updateEntryAndMaxEntry
=== RUN   TestAccVPCManagedPrefixList_name
=== PAUSE TestAccVPCManagedPrefixList_name
=== RUN   TestAccVPCManagedPrefixList_tags
=== PAUSE TestAccVPCManagedPrefixList_tags
=== RUN   TestAccVPCManagedPrefixListsDataSource_basic
=== PAUSE TestAccVPCManagedPrefixListsDataSource_basic
=== RUN   TestAccVPCManagedPrefixListsDataSource_tags
=== PAUSE TestAccVPCManagedPrefixListsDataSource_tags
=== RUN   TestAccVPCManagedPrefixListsDataSource_noMatches
=== PAUSE TestAccVPCManagedPrefixListsDataSource_noMatches
=== CONT  TestAccVPCManagedPrefixListDataSource_basic
=== CONT  TestAccVPCManagedPrefixList_disappears
=== CONT  TestAccVPCManagedPrefixList_name
=== CONT  TestAccVPCManagedPrefixList_AddressFamily_ipv6
=== CONT  TestAccVPCManagedPrefixListsDataSource_tags
=== CONT  TestAccVPCManagedPrefixList_updateEntryAndMaxEntry
=== CONT  TestAccVPCManagedPrefixListsDataSource_basic
=== CONT  TestAccVPCManagedPrefixList_Entry_description
=== CONT  TestAccVPCManagedPrefixListEntry_expectInvalidTypeError
=== CONT  TestAccVPCManagedPrefixList_Entry_cidr
=== CONT  TestAccVPCManagedPrefixList_basic
=== CONT  TestAccVPCManagedPrefixListDataSource_matchesTooMany
=== CONT  TestAccVPCManagedPrefixListEntry_description
=== CONT  TestAccVPCManagedPrefixListEntry_disappears
=== CONT  TestAccVPCManagedPrefixListsDataSource_noMatches
=== CONT  TestAccVPCManagedPrefixListEntry_ipv4
=== CONT  TestAccVPCManagedPrefixListEntry_ipv6
=== CONT  TestAccVPCManagedPrefixList_tags
=== CONT  TestAccVPCManagedPrefixListEntry_ipv4Multiple
=== CONT  TestAccVPCManagedPrefixListDataSource_filter
--- PASS: TestAccVPCManagedPrefixListEntry_expectInvalidTypeError (11.44s)
=== CONT  TestAccVPCManagedPrefixListEntry_expectInvalidCIDR
--- PASS: TestAccVPCManagedPrefixListDataSource_matchesTooMany (21.29s)
--- PASS: TestAccVPCManagedPrefixListEntry_expectInvalidCIDR (17.40s)
--- PASS: TestAccVPCManagedPrefixList_disappears (81.41s)
--- PASS: TestAccVPCManagedPrefixListsDataSource_noMatches (82.23s)
--- PASS: TestAccVPCManagedPrefixListDataSource_basic (83.32s)
--- PASS: TestAccVPCManagedPrefixListsDataSource_basic (84.19s)
--- PASS: TestAccVPCManagedPrefixListDataSource_filter (87.24s)
--- PASS: TestAccVPCManagedPrefixListsDataSource_tags (95.10s)
--- PASS: TestAccVPCManagedPrefixListEntry_disappears (96.67s)
--- PASS: TestAccVPCManagedPrefixListEntry_ipv4Multiple (101.23s)
--- PASS: TestAccVPCManagedPrefixList_AddressFamily_ipv6 (107.37s)
--- PASS: TestAccVPCManagedPrefixListEntry_description (107.97s)
--- PASS: TestAccVPCManagedPrefixListEntry_ipv6 (108.65s)
--- PASS: TestAccVPCManagedPrefixListEntry_ipv4 (108.81s)
--- PASS: TestAccVPCManagedPrefixList_name (131.27s)
--- PASS: TestAccVPCManagedPrefixList_Entry_description (134.53s)
--- PASS: TestAccVPCManagedPrefixList_basic (139.63s)
--- PASS: TestAccVPCManagedPrefixList_Entry_cidr (141.11s)
--- PASS: TestAccVPCManagedPrefixList_tags (151.47s)
--- PASS: TestAccVPCManagedPrefixList_updateEntryAndMaxEntry (158.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	162.623
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Please review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/vpc Issues and PRs that pertain to the vpc service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Sep 16, 2022
@drewmullen drewmullen removed the needs-triage Waiting for first response or review from a maintainer. label Sep 16, 2022
@drewmullen drewmullen changed the title [WIP] r/aws_ec2_managed_prefix_list Fix: MaxEntries and Entry can be changed in same apply r/aws_ec2_managed_prefix_list Fix: MaxEntries and Entry can be changed in same apply Sep 16, 2022
@drewmullen drewmullen changed the title r/aws_ec2_managed_prefix_list Fix: MaxEntries and Entry can be changed in same apply r/aws_ec2_managed_prefix_list - Fix: MaxEntries and Entry can be changed in same apply Sep 16, 2022
AdamTylerLynch
AdamTylerLynch approved these changes Sep 17, 2022
View reviewed changes
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just one question on the local variable).

internal/service/ec2/vpc_managed_prefix_list.go Outdated Show resolved Hide resolved
@drewmullen
Copy link
Collaborator Author 

make testacc TESTS=TestAccVPCManagedPrefixList PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCManagedPrefixList'  -timeout 180m
=== RUN   TestAccVPCManagedPrefixListDataSource_basic
=== PAUSE TestAccVPCManagedPrefixListDataSource_basic
=== RUN   TestAccVPCManagedPrefixListDataSource_filter
=== PAUSE TestAccVPCManagedPrefixListDataSource_filter
=== RUN   TestAccVPCManagedPrefixListDataSource_matchesTooMany
=== PAUSE TestAccVPCManagedPrefixListDataSource_matchesTooMany
=== RUN   TestAccVPCManagedPrefixListEntry_ipv4
=== PAUSE TestAccVPCManagedPrefixListEntry_ipv4
=== RUN   TestAccVPCManagedPrefixListEntry_ipv4Multiple
=== PAUSE TestAccVPCManagedPrefixListEntry_ipv4Multiple
=== RUN   TestAccVPCManagedPrefixListEntry_ipv6
=== PAUSE TestAccVPCManagedPrefixListEntry_ipv6
=== RUN   TestAccVPCManagedPrefixListEntry_expectInvalidTypeError
=== PAUSE TestAccVPCManagedPrefixListEntry_expectInvalidTypeError
=== RUN   TestAccVPCManagedPrefixListEntry_expectInvalidCIDR
=== PAUSE TestAccVPCManagedPrefixListEntry_expectInvalidCIDR
=== RUN   TestAccVPCManagedPrefixListEntry_description
=== PAUSE TestAccVPCManagedPrefixListEntry_description
=== RUN   TestAccVPCManagedPrefixListEntry_disappears
=== PAUSE TestAccVPCManagedPrefixListEntry_disappears
=== RUN   TestAccVPCManagedPrefixList_basic
=== PAUSE TestAccVPCManagedPrefixList_basic
=== RUN   TestAccVPCManagedPrefixList_disappears
=== PAUSE TestAccVPCManagedPrefixList_disappears
=== RUN   TestAccVPCManagedPrefixList_AddressFamily_ipv6
=== PAUSE TestAccVPCManagedPrefixList_AddressFamily_ipv6
=== RUN   TestAccVPCManagedPrefixList_Entry_cidr
=== PAUSE TestAccVPCManagedPrefixList_Entry_cidr
=== RUN   TestAccVPCManagedPrefixList_Entry_description
=== PAUSE TestAccVPCManagedPrefixList_Entry_description
=== RUN   TestAccVPCManagedPrefixList_updateEntryAndMaxEntry
=== PAUSE TestAccVPCManagedPrefixList_updateEntryAndMaxEntry
=== RUN   TestAccVPCManagedPrefixList_name
=== PAUSE TestAccVPCManagedPrefixList_name
=== RUN   TestAccVPCManagedPrefixList_tags
=== PAUSE TestAccVPCManagedPrefixList_tags
=== RUN   TestAccVPCManagedPrefixListsDataSource_basic
=== PAUSE TestAccVPCManagedPrefixListsDataSource_basic
=== RUN   TestAccVPCManagedPrefixListsDataSource_tags
=== PAUSE TestAccVPCManagedPrefixListsDataSource_tags
=== RUN   TestAccVPCManagedPrefixListsDataSource_noMatches
=== PAUSE TestAccVPCManagedPrefixListsDataSource_noMatches
=== CONT  TestAccVPCManagedPrefixListDataSource_basic
=== CONT  TestAccVPCManagedPrefixList_disappears
=== CONT  TestAccVPCManagedPrefixList_name
=== CONT  TestAccVPCManagedPrefixList_Entry_description
=== CONT  TestAccVPCManagedPrefixList_Entry_cidr
=== CONT  TestAccVPCManagedPrefixList_AddressFamily_ipv6
=== CONT  TestAccVPCManagedPrefixListsDataSource_noMatches
=== CONT  TestAccVPCManagedPrefixList_updateEntryAndMaxEntry
=== CONT  TestAccVPCManagedPrefixList_tags
=== CONT  TestAccVPCManagedPrefixListsDataSource_tags
=== CONT  TestAccVPCManagedPrefixListsDataSource_basic
=== CONT  TestAccVPCManagedPrefixListEntry_expectInvalidCIDR
=== CONT  TestAccVPCManagedPrefixListEntry_ipv4
=== CONT  TestAccVPCManagedPrefixListEntry_ipv6
=== CONT  TestAccVPCManagedPrefixListEntry_expectInvalidTypeError
=== CONT  TestAccVPCManagedPrefixListEntry_ipv4Multiple
=== CONT  TestAccVPCManagedPrefixListDataSource_matchesTooMany
=== CONT  TestAccVPCManagedPrefixList_basic
=== CONT  TestAccVPCManagedPrefixListEntry_disappears
=== CONT  TestAccVPCManagedPrefixListEntry_description
--- PASS: TestAccVPCManagedPrefixListEntry_expectInvalidTypeError (19.02s)
=== CONT  TestAccVPCManagedPrefixListDataSource_filter
--- PASS: TestAccVPCManagedPrefixListEntry_expectInvalidCIDR (24.78s)
--- PASS: TestAccVPCManagedPrefixListDataSource_matchesTooMany (27.63s)
--- PASS: TestAccVPCManagedPrefixListsDataSource_basic (109.67s)
--- PASS: TestAccVPCManagedPrefixListsDataSource_noMatches (110.44s)
--- PASS: TestAccVPCManagedPrefixList_disappears (110.81s)
--- PASS: TestAccVPCManagedPrefixListDataSource_basic (115.42s)
--- PASS: TestAccVPCManagedPrefixListDataSource_filter (104.32s)
--- PASS: TestAccVPCManagedPrefixListsDataSource_tags (127.56s)
--- PASS: TestAccVPCManagedPrefixListEntry_disappears (130.04s)
--- PASS: TestAccVPCManagedPrefixListEntry_ipv4Multiple (138.98s)
--- PASS: TestAccVPCManagedPrefixListEntry_description (145.15s)
--- PASS: TestAccVPCManagedPrefixList_AddressFamily_ipv6 (145.34s)
--- PASS: TestAccVPCManagedPrefixListEntry_ipv4 (145.80s)
--- PASS: TestAccVPCManagedPrefixListEntry_ipv6 (146.82s)
--- PASS: TestAccVPCManagedPrefixList_name (171.59s)
--- PASS: TestAccVPCManagedPrefixList_Entry_description (172.50s)
--- PASS: TestAccVPCManagedPrefixList_basic (177.51s)
--- PASS: TestAccVPCManagedPrefixList_Entry_cidr (178.49s)
--- PASS: TestAccVPCManagedPrefixList_tags (193.17s)
--- PASS: TestAccVPCManagedPrefixList_updateEntryAndMaxEntry (198.68s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        202.780s

gdavison
gdavison approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

--- PASS: TestAccVPCManagedPrefixListEntry_expectInvalidTypeError (28.24s)
--- PASS: TestAccVPCManagedPrefixListEntry_expectInvalidCIDR (30.86s)
--- PASS: TestAccVPCManagedPrefixListDataSource_matchesTooMany (32.44s)
--- PASS: TestAccVPCManagedPrefixListsDataSource_basic (125.55s)
--- PASS: TestAccVPCManagedPrefixListsDataSource_noMatches (127.06s)
--- PASS: TestAccVPCManagedPrefixList_disappears (134.19s)
--- PASS: TestAccVPCManagedPrefixListDataSource_basic (139.58s)
--- PASS: TestAccVPCManagedPrefixListDataSource_filter (125.30s)
--- PASS: TestAccVPCManagedPrefixListEntry_disappears (158.56s)
--- PASS: TestAccVPCManagedPrefixListsDataSource_tags (158.59s)
--- PASS: TestAccVPCManagedPrefixListEntry_ipv4Multiple (163.16s)
--- PASS: TestAccVPCManagedPrefixList_AddressFamily_ipv6 (169.57s)
--- PASS: TestAccVPCManagedPrefixListEntry_ipv4 (170.54s)
--- PASS: TestAccVPCManagedPrefixListEntry_ipv6 (172.96s)
--- PASS: TestAccVPCManagedPrefixListEntry_description (173.32s)
--- PASS: TestAccVPCManagedPrefixList_name (206.62s)
--- PASS: TestAccVPCManagedPrefixList_Entry_description (211.00s)
--- PASS: TestAccVPCManagedPrefixList_basic (212.50s)
--- PASS: TestAccVPCManagedPrefixList_Entry_cidr (214.65s)
--- PASS: TestAccVPCManagedPrefixList_tags (229.16s)
--- PASS: TestAccVPCManagedPrefixList_updateEntryAndMaxEntry (231.66s)

@gdavison gdavison merged commit 54e6519 into hashicorp:main Sep 22, 2022
@github-actions github-actions bot added this to the v4.32.0 milestone Sep 22, 2022
@drewmullen drewmullen deleted the b-managed-pls-entry-fix branch September 22, 2022 18:47
@github-actions
Copy link

This functionality has been released in v4.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

@AdamTylerLynch AdamTylerLynch AdamTylerLynch approved these changes

Assignees
No one assigned
Labels
partner Contribution from a partner. service/vpc Issues and PRs that pertain to the vpc service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.32.0
Development

Successfully merging this pull request may close these issues.

Prefix List ressource won't allow adding an entry and changing the maximum number of entries at the same time
4 participants
@drewmullen @gdavison @AdamTylerLynch @justinretzolk