Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EKS local clusters on Outposts #26866

Merged
merged 52 commits into from
Sep 22, 2022
Merged

Add support for EKS local clusters on Outposts #26866

merged 52 commits into from
Sep 22, 2022

Conversation

skyscrapr
Copy link
Contributor

@skyscrapr skyscrapr commented Sep 19, 2022

Add support for EKS local clusters on Outposts

Closes #26913

Output from acceptance testing:

$ make testacc TESTS=TestAccEKSCluster_ PKG=eks

TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 2 -run='TestAccEKSCluster_'  -timeout 180m
=== RUN   TestAccEKSCluster_basic
=== PAUSE TestAccEKSCluster_basic
=== RUN   TestAccEKSCluster_disappears
=== PAUSE TestAccEKSCluster_disappears
=== RUN   TestAccEKSCluster_Encryption_create
=== PAUSE TestAccEKSCluster_Encryption_create
=== RUN   TestAccEKSCluster_Encryption_update
=== PAUSE TestAccEKSCluster_Encryption_update
=== RUN   TestAccEKSCluster_Encryption_versionUpdate
=== PAUSE TestAccEKSCluster_Encryption_versionUpdate
=== RUN   TestAccEKSCluster_version
=== PAUSE TestAccEKSCluster_version
=== RUN   TestAccEKSCluster_logging
=== PAUSE TestAccEKSCluster_logging
=== RUN   TestAccEKSCluster_tags
=== PAUSE TestAccEKSCluster_tags
=== RUN   TestAccEKSCluster_VPC_securityGroupIDs
=== PAUSE TestAccEKSCluster_VPC_securityGroupIDs
=== RUN   TestAccEKSCluster_VPC_endpointPrivateAccess
=== PAUSE TestAccEKSCluster_VPC_endpointPrivateAccess
=== RUN   TestAccEKSCluster_VPC_endpointPublicAccess
=== PAUSE TestAccEKSCluster_VPC_endpointPublicAccess
=== RUN   TestAccEKSCluster_VPC_publicAccessCIDRs
=== PAUSE TestAccEKSCluster_VPC_publicAccessCIDRs
=== RUN   TestAccEKSCluster_Network_serviceIPv4CIDR
=== PAUSE TestAccEKSCluster_Network_serviceIPv4CIDR
=== RUN   TestAccEKSCluster_Network_ipFamily
=== PAUSE TestAccEKSCluster_Network_ipFamily
=== RUN   TestAccEKSCluster_Outpost_create
=== PAUSE TestAccEKSCluster_Outpost_create
=== CONT  TestAccEKSCluster_basic
=== CONT  TestAccEKSCluster_VPC_securityGroupIDs
--- PASS: TestAccEKSCluster_VPC_securityGroupIDs (710.43s)
=== CONT  TestAccEKSCluster_Encryption_versionUpdate
--- PASS: TestAccEKSCluster_basic (806.92s)
=== CONT  TestAccEKSCluster_tags
--- PASS: TestAccEKSCluster_tags (793.93s)
=== CONT  TestAccEKSCluster_logging
--- PASS: TestAccEKSCluster_Encryption_versionUpdate (1646.97s)
=== CONT  TestAccEKSCluster_version
--- PASS: TestAccEKSCluster_logging (836.04s)
=== CONT  TestAccEKSCluster_Encryption_create
--- PASS: TestAccEKSCluster_Encryption_create (841.02s)
=== CONT  TestAccEKSCluster_Encryption_update
--- PASS: TestAccEKSCluster_version (1197.46s)
=== CONT  TestAccEKSCluster_disappears
--- PASS: TestAccEKSCluster_disappears (782.33s)
=== CONT  TestAccEKSCluster_Network_serviceIPv4CIDR
--- PASS: TestAccEKSCluster_Network_serviceIPv4CIDR (1458.33s)
=== CONT  TestAccEKSCluster_Outpost_create
--- PASS: TestAccEKSCluster_Encryption_update (2955.74s)
=== CONT  TestAccEKSCluster_Network_ipFamily
--- PASS: TestAccEKSCluster_Outpost_create (658.56s)
=== CONT  TestAccEKSCluster_VPC_endpointPublicAccess
--- PASS: TestAccEKSCluster_Network_ipFamily (1560.61s)
=== CONT  TestAccEKSCluster_VPC_publicAccessCIDRs
--- PASS: TestAccEKSCluster_VPC_endpointPublicAccess (1454.42s)
=== CONT  TestAccEKSCluster_VPC_endpointPrivateAccess
--- PASS: TestAccEKSCluster_VPC_publicAccessCIDRs (939.61s) 
--- PASS: TestAccEKSCluster_VPC_endpointPrivateAccess (1767.35s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks         9679.710s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Please review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. labels Sep 19, 2022
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @skyscrapr 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Sep 20, 2022
@AdamTylerLynch AdamTylerLynch self-assigned this Sep 21, 2022
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Closes #26913

Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

--- SKIP: TestAccEKSCluster_Outpost_create (1.30s)
--- PASS: TestAccEKSCluster_basic (722.79s)
--- PASS: TestAccEKSCluster_disappears (733.51s)
--- PASS: TestAccEKSCluster_Encryption_create (742.47s)
--- PASS: TestAccEKSCluster_tags (748.12s)
--- PASS: TestAccEKSCluster_VPC_securityGroupIDs (777.15s)
--- PASS: TestAccEKSCluster_logging (781.16s)
--- PASS: TestAccEKSCluster_VPC_publicAccessCIDRs (977.79s)
--- PASS: TestAccEKSCluster_Encryption_versionUpdate (1339.53s)
--- PASS: TestAccEKSCluster_VPC_endpointPublicAccess (1381.21s)
--- PASS: TestAccEKSCluster_Network_serviceIPv4CIDR (1389.21s)
--- PASS: TestAccEKSCluster_version (1435.87s)
--- PASS: TestAccEKSCluster_Network_ipFamily (1500.95s)
--- PASS: TestAccEKSCluster_VPC_endpointPrivateAccess (1880.19s)
--- PASS: TestAccEKSCluster_Encryption_update (4428.46s)

@gdavison gdavison merged commit 4305cf3 into hashicorp:main Sep 22, 2022
@github-actions github-actions bot added this to the v4.32.0 milestone Sep 22, 2022
@github-actions
Copy link

This functionality has been released in v4.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: EKS clusters on AWS Outposts
4 participants