Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_comprehend_document_classifier: New resource #26951

Merged
merged 6 commits into from
Oct 7, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Sep 22, 2022

Adds new resource aws_comprehend_entity_recognizer.

Relates #18864

Output from acceptance testing:

$ make testacc PKG=comprehend TESTS=TestAccComprehendDocumentClassifier_ ACCTEST_PARALLELISM=10

--- PASS: TestAccComprehendDocumentClassifier_testDocuments (2467.22s)
--- PASS: TestAccComprehendDocumentClassifier_basic (2480.80s)
--- PASS: TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateAliasName (2481.73s)
--- PASS: TestAccComprehendDocumentClassifier_KMSKeys_Remove (4453.52s)
--- PASS: TestAccComprehendDocumentClassifier_VPCConfig_Create (4751.61s)
--- PASS: TestAccComprehendDocumentClassifier_KMSKeys_CreateARNs (2310.44s)
--- PASS: TestAccComprehendDocumentClassifier_KMSKeys_CreateIDs (2307.65s)
--- PASS: TestAccComprehendDocumentClassifier_KMSKeys_Add (4418.99s)
--- PASS: TestAccComprehendDocumentClassifier_SingleLabel_ValidateNoDelimiterSet (8.45s)
--- PASS: TestAccComprehendDocumentClassifier_KMSKeys_Update (4542.17s)
--- PASS: TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateAliasARN (2311.73s)
--- PASS: TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyRemove (4366.05s)
--- PASS: TestAccComprehendDocumentClassifier_DefaultTags_providerOnly (2340.86s)
--- PASS: TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyUpdate (4302.43s)
--- PASS: TestAccComprehendDocumentClassifier_tags (2454.61s)
--- PASS: TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateARN (2313.86s)
--- PASS: TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyAdd (4301.75s)
--- PASS: TestAccComprehendDocumentClassifier_multiLabel_labelDelimiter (6105.00s)
--- PASS: TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateID (2435.72s)
--- PASS: TestAccComprehendDocumentClassifier_outputDataConfig_basic (2436.06s)
--- PASS: TestAccComprehendDocumentClassifier_VPCConfig_Remove (4642.94s)
--- PASS: TestAccComprehendDocumentClassifier_versionNamePrefix (2304.41s)
--- PASS: TestAccComprehendDocumentClassifier_versionNameGenerated (2304.18s)
--- PASS: TestAccComprehendDocumentClassifier_versionNameEmpty (2426.10s)
--- PASS: TestAccComprehendDocumentClassifier_VPCConfig_Add (4712.16s)
--- PASS: TestAccComprehendDocumentClassifier_multiLabel_basic (3036.53s)
--- PASS: TestAccComprehendDocumentClassifier_disappears (2301.05s)
--- PASS: TestAccComprehendDocumentClassifier_versionName (4303.08s)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Please review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/comprehend Issues and PRs that pertain to the comprehend service. service/kms Issues and PRs that pertain to the kms service. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Sep 22, 2022
@gdavison gdavison marked this pull request as ready for review September 24, 2022 00:25
@ewbankkit
Copy link
Contributor

LGTM 🚀.

% ACCTEST_TIMEOUT=720m  make testacc TESTARGS='-run=TestAccComprehendDocumentClassifier_' PKG=comprehend ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/comprehend/... -v -count 1 -parallel 4  -run=TestAccComprehendDocumentClassifier_ -timeout 720m
=== RUN   TestAccComprehendDocumentClassifier_basic
=== PAUSE TestAccComprehendDocumentClassifier_basic
=== RUN   TestAccComprehendDocumentClassifier_disappears
=== PAUSE TestAccComprehendDocumentClassifier_disappears
=== RUN   TestAccComprehendDocumentClassifier_versionName
=== PAUSE TestAccComprehendDocumentClassifier_versionName
=== RUN   TestAccComprehendDocumentClassifier_versionNameEmpty
=== PAUSE TestAccComprehendDocumentClassifier_versionNameEmpty
=== RUN   TestAccComprehendDocumentClassifier_versionNameGenerated
=== PAUSE TestAccComprehendDocumentClassifier_versionNameGenerated
=== RUN   TestAccComprehendDocumentClassifier_versionNamePrefix
=== PAUSE TestAccComprehendDocumentClassifier_versionNamePrefix
=== RUN   TestAccComprehendDocumentClassifier_testDocuments
=== PAUSE TestAccComprehendDocumentClassifier_testDocuments
=== RUN   TestAccComprehendDocumentClassifier_SingleLabel_ValidateNoDelimiterSet
=== PAUSE TestAccComprehendDocumentClassifier_SingleLabel_ValidateNoDelimiterSet
=== RUN   TestAccComprehendDocumentClassifier_multiLabel_basic
=== PAUSE TestAccComprehendDocumentClassifier_multiLabel_basic
=== RUN   TestAccComprehendDocumentClassifier_outputDataConfig_basic
=== PAUSE TestAccComprehendDocumentClassifier_outputDataConfig_basic
=== RUN   TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateID
=== PAUSE TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateID
=== RUN   TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateARN
=== PAUSE TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateARN
=== RUN   TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateAliasName
=== PAUSE TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateAliasName
=== RUN   TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateAliasARN
=== PAUSE TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateAliasARN
=== RUN   TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyAdd
=== PAUSE TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyAdd
=== RUN   TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyUpdate
=== PAUSE TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyUpdate
=== RUN   TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyRemove
=== PAUSE TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyRemove
=== RUN   TestAccComprehendDocumentClassifier_multiLabel_labelDelimiter
=== PAUSE TestAccComprehendDocumentClassifier_multiLabel_labelDelimiter
=== RUN   TestAccComprehendDocumentClassifier_KMSKeys_CreateIDs
=== PAUSE TestAccComprehendDocumentClassifier_KMSKeys_CreateIDs
=== RUN   TestAccComprehendDocumentClassifier_KMSKeys_CreateARNs
=== PAUSE TestAccComprehendDocumentClassifier_KMSKeys_CreateARNs
=== RUN   TestAccComprehendDocumentClassifier_KMSKeys_Add
=== PAUSE TestAccComprehendDocumentClassifier_KMSKeys_Add
=== RUN   TestAccComprehendDocumentClassifier_KMSKeys_Update
=== PAUSE TestAccComprehendDocumentClassifier_KMSKeys_Update
=== RUN   TestAccComprehendDocumentClassifier_KMSKeys_Remove
=== PAUSE TestAccComprehendDocumentClassifier_KMSKeys_Remove
=== RUN   TestAccComprehendDocumentClassifier_VPCConfig_Create
=== PAUSE TestAccComprehendDocumentClassifier_VPCConfig_Create
=== RUN   TestAccComprehendDocumentClassifier_VPCConfig_Add
=== PAUSE TestAccComprehendDocumentClassifier_VPCConfig_Add
=== RUN   TestAccComprehendDocumentClassifier_VPCConfig_Remove
=== PAUSE TestAccComprehendDocumentClassifier_VPCConfig_Remove
=== RUN   TestAccComprehendDocumentClassifier_tags
=== PAUSE TestAccComprehendDocumentClassifier_tags
=== RUN   TestAccComprehendDocumentClassifier_DefaultTags_providerOnly
=== PAUSE TestAccComprehendDocumentClassifier_DefaultTags_providerOnly
=== CONT  TestAccComprehendDocumentClassifier_basic
=== CONT  TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyAdd
=== CONT  TestAccComprehendDocumentClassifier_SingleLabel_ValidateNoDelimiterSet
=== CONT  TestAccComprehendDocumentClassifier_versionNameGenerated
--- PASS: TestAccComprehendDocumentClassifier_SingleLabel_ValidateNoDelimiterSet (12.60s)
=== CONT  TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateARN
--- PASS: TestAccComprehendDocumentClassifier_basic (2330.14s)
=== CONT  TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateAliasARN
--- PASS: TestAccComprehendDocumentClassifier_versionNameGenerated (2442.40s)
=== CONT  TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateAliasName
--- PASS: TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateARN (2445.71s)
=== CONT  TestAccComprehendDocumentClassifier_versionName
--- PASS: TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyAdd (4337.98s)
=== CONT  TestAccComprehendDocumentClassifier_versionNameEmpty
--- PASS: TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateAliasARN (2340.15s)
=== CONT  TestAccComprehendDocumentClassifier_testDocuments
--- PASS: TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateAliasName (2465.90s)
=== CONT  TestAccComprehendDocumentClassifier_versionNamePrefix
--- PASS: TestAccComprehendDocumentClassifier_versionNameEmpty (2327.42s)
=== CONT  TestAccComprehendDocumentClassifier_multiLabel_basic
--- PASS: TestAccComprehendDocumentClassifier_versionName (4451.89s)
=== CONT  TestAccComprehendDocumentClassifier_KMSKeys_Update
--- PASS: TestAccComprehendDocumentClassifier_testDocuments (2328.27s)
=== CONT  TestAccComprehendDocumentClassifier_DefaultTags_providerOnly
--- PASS: TestAccComprehendDocumentClassifier_versionNamePrefix (2380.03s)
=== CONT  TestAccComprehendDocumentClassifier_tags
--- PASS: TestAccComprehendDocumentClassifier_DefaultTags_providerOnly (2341.00s)
=== CONT  TestAccComprehendDocumentClassifier_VPCConfig_Remove
--- PASS: TestAccComprehendDocumentClassifier_tags (2472.44s)
=== CONT  TestAccComprehendDocumentClassifier_outputDataConfig_basic
--- PASS: TestAccComprehendDocumentClassifier_multiLabel_basic (3123.26s)
=== CONT  TestAccComprehendDocumentClassifier_VPCConfig_Add
--- PASS: TestAccComprehendDocumentClassifier_KMSKeys_Update (4389.47s)
=== CONT  TestAccComprehendDocumentClassifier_VPCConfig_Create
--- PASS: TestAccComprehendDocumentClassifier_outputDataConfig_basic (2459.10s)
=== CONT  TestAccComprehendDocumentClassifier_KMSKeys_Remove
--- PASS: TestAccComprehendDocumentClassifier_VPCConfig_Remove (4629.91s)
=== CONT  TestAccComprehendDocumentClassifier_disappears
--- PASS: TestAccComprehendDocumentClassifier_VPCConfig_Add (4872.96s)
=== CONT  TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateID
--- PASS: TestAccComprehendDocumentClassifier_VPCConfig_Create (4808.58s)
=== CONT  TestAccComprehendDocumentClassifier_KMSKeys_CreateIDs
--- PASS: TestAccComprehendDocumentClassifier_disappears (2556.46s)
=== CONT  TestAccComprehendDocumentClassifier_KMSKeys_Add
--- PASS: TestAccComprehendDocumentClassifier_KMSKeys_Remove (4333.77s)
=== CONT  TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyRemove
--- PASS: TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyCreateID (2459.40s)
=== CONT  TestAccComprehendDocumentClassifier_KMSKeys_CreateARNs
--- PASS: TestAccComprehendDocumentClassifier_KMSKeys_CreateIDs (2386.97s)
=== CONT  TestAccComprehendDocumentClassifier_multiLabel_labelDelimiter
--- PASS: TestAccComprehendDocumentClassifier_KMSKeys_CreateARNs (2325.55s)
=== CONT  TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyUpdate
--- PASS: TestAccComprehendDocumentClassifier_KMSKeys_Add (4447.27s)
--- PASS: TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyRemove (4452.53s)
--- PASS: TestAccComprehendDocumentClassifier_multiLabel_labelDelimiter (5771.49s)
--- PASS: TestAccComprehendDocumentClassifier_outputDataConfig_kmsKeyUpdate (5772.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/comprehend	25222.585s

@gdavison gdavison merged commit b694181 into main Oct 7, 2022
@gdavison gdavison deleted the f-comprehend-document-classifier branch October 7, 2022 00:01
@github-actions github-actions bot added this to the v4.35.0 milestone Oct 7, 2022
ewbankkit added a commit that referenced this pull request Oct 7, 2022
@github-actions
Copy link

This functionality has been released in v4.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/comprehend Issues and PRs that pertain to the comprehend service. service/kms Issues and PRs that pertain to the kms service. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants