Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudwatch rum: add application id to exported attributes #26994

Merged
merged 5 commits into from
Oct 18, 2022

Conversation

NabilHouidi
Copy link
Contributor

Description

Adds an application_id computed attribute to the AWS CloudWatch RUM resource.

Using the application ID as the resource's id requires more modifications to the code, updating the tests, and might introduce breaking changes. I'll be happy to implement those changes if that is what's needed to fix the issue.

However, this fix is enough to make the resource useful in my case: dynamically generated RUM javascript template.

Relations

Relates #26430

References

https://github.com/aws-observability/aws-rum-web/blob/main/docs/cdn_installation.md#arguments

Output from Acceptance Testing

$ make testacc PKG=rum
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rum/... -v -count 1 -parallel 20   -timeout 180m
=== RUN   TestAccRUMAppMonitor_basic
=== PAUSE TestAccRUMAppMonitor_basic
=== RUN   TestAccRUMAppMonitor_tags
=== PAUSE TestAccRUMAppMonitor_tags
=== RUN   TestAccRUMAppMonitor_disappears
=== PAUSE TestAccRUMAppMonitor_disappears
=== CONT  TestAccRUMAppMonitor_basic
=== CONT  TestAccRUMAppMonitor_disappears
=== CONT  TestAccRUMAppMonitor_tags
--- PASS: TestAccRUMAppMonitor_disappears (26.66s)
--- PASS: TestAccRUMAppMonitor_basic (49.98s)
--- PASS: TestAccRUMAppMonitor_tags (65.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rum	67.638s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/rum Issues and PRs that pertain to the rum service. labels Sep 27, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @NabilHouidi 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 28, 2022
@NabilHouidi
Copy link
Contributor Author

@ewbankkit As I am a new contributor here, I am feeling a bit confused. should I do something to move this forward?

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Oct 18, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRUMAppMonitor_' PKG=rum ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rum/... -v -count 1 -parallel 3  -run=TestAccRUMAppMonitor_ -timeout 180m
=== RUN   TestAccRUMAppMonitor_basic
=== PAUSE TestAccRUMAppMonitor_basic
=== RUN   TestAccRUMAppMonitor_tags
=== PAUSE TestAccRUMAppMonitor_tags
=== RUN   TestAccRUMAppMonitor_disappears
=== PAUSE TestAccRUMAppMonitor_disappears
=== CONT  TestAccRUMAppMonitor_basic
=== CONT  TestAccRUMAppMonitor_disappears
=== CONT  TestAccRUMAppMonitor_tags
--- PASS: TestAccRUMAppMonitor_disappears (22.01s)
--- PASS: TestAccRUMAppMonitor_basic (44.38s)
--- PASS: TestAccRUMAppMonitor_tags (56.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rum	61.394s

@ewbankkit
Copy link
Contributor

@NabilHouidi Thanks for the contribution 🎉 👏.

I renamed the new attribute to app_monitor_id to better match the underlying AWS API.

@ewbankkit ewbankkit merged commit 3b44696 into hashicorp:main Oct 18, 2022
@github-actions github-actions bot added this to the v4.36.0 milestone Oct 18, 2022
@github-actions
Copy link

This functionality has been released in v4.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/rum Issues and PRs that pertain to the rum service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants