-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloudwatch rum: add application id to exported attributes #26994
Cloudwatch rum: add application id to exported attributes #26994
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @NabilHouidi 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
@ewbankkit As I am a new contributor here, I am feeling a bit confused. should I do something to move this forward? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRUMAppMonitor_' PKG=rum ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rum/... -v -count 1 -parallel 3 -run=TestAccRUMAppMonitor_ -timeout 180m
=== RUN TestAccRUMAppMonitor_basic
=== PAUSE TestAccRUMAppMonitor_basic
=== RUN TestAccRUMAppMonitor_tags
=== PAUSE TestAccRUMAppMonitor_tags
=== RUN TestAccRUMAppMonitor_disappears
=== PAUSE TestAccRUMAppMonitor_disappears
=== CONT TestAccRUMAppMonitor_basic
=== CONT TestAccRUMAppMonitor_disappears
=== CONT TestAccRUMAppMonitor_tags
--- PASS: TestAccRUMAppMonitor_disappears (22.01s)
--- PASS: TestAccRUMAppMonitor_basic (44.38s)
--- PASS: TestAccRUMAppMonitor_tags (56.74s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rum 61.394s
@NabilHouidi Thanks for the contribution 🎉 👏. I renamed the new attribute to |
This functionality has been released in v4.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds an
application_id
computed attribute to the AWS CloudWatch RUM resource.Using the application ID as the resource's id requires more modifications to the code, updating the tests, and might introduce breaking changes. I'll be happy to implement those changes if that is what's needed to fix the issue.
However, this fix is enough to make the resource useful in my case: dynamically generated RUM javascript template.
Relations
Relates #26430
References
https://github.com/aws-observability/aws-rum-web/blob/main/docs/cdn_installation.md#arguments
Output from Acceptance Testing