Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKS Add-on resolve_conflicts with PRESERVE feature tests and docs updated #27038

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

vara-bonthu
Copy link
Contributor

Description

EKS API now provides three options for resolve_conflicts which are NONE, OVERWRITE and PRESERVE.

EKS Add-on currently supports a new feature to preserve user configuration during the upgrade of EKS Add-ons. Any changes applied to the managed add-ons using kubectl or through any other approach will be retained during the upgrade of managed add-on to the newer version.

Current behaviour of the upgrade add-on version overwrites the custom changes applied to the previous version of add-on However, users can retain the custom configuration during the add-on upgrades by using resolve_conflicts = "PRESERVE"

This new resolve_conflicts with PRESERVE feature is already supported by the current version(4.32.0) of AWS provider since the option of pulling resolve_conflicts string is dynamic using eks.ResolveConflicts_Values hence the users can now pass the resolve_conflicts = "PRESERVE" during the upgrade of the add-on.

I have added the tests and updates to the dcoumentation

Relations

References

Output from Acceptance Testing

➜  terraform-provider-aws git:(f-eks_addon-refactor) ✗ make testacc TESTARGS='-run=TestAccEKSAddon_resolveConflicts' PKG=eks TIMEOUT=300m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20  -run=TestAccEKSAddon_resolveConflicts -timeout 180m
=== RUN   TestAccEKSAddon_resolveConflicts
=== PAUSE TestAccEKSAddon_resolveConflicts
=== CONT  TestAccEKSAddon_resolveConflicts
--- PASS: TestAccEKSAddon_resolveConflicts (741.34s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        760.820s

——

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. labels Sep 30, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 30, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEKSAddon_resolveConflicts' PKG=eks 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20  -run=TestAccEKSAddon_resolveConflicts -timeout 180m
=== RUN   TestAccEKSAddon_resolveConflicts
=== PAUSE TestAccEKSAddon_resolveConflicts
=== CONT  TestAccEKSAddon_resolveConflicts
--- PASS: TestAccEKSAddon_resolveConflicts (794.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	798.350s

@ewbankkit
Copy link
Contributor

@vara-bonthu Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 562f79f into hashicorp:main Sep 30, 2022
@github-actions github-actions bot added this to the v4.34.0 milestone Sep 30, 2022
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

This functionality has been released in v4.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants