-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_sesv2_configuration_set: new resource #27056
r/aws_sesv2_configuration_set: new resource #27056
Conversation
Community NoteVoting for Prioritization
For Submitters
|
@kamilturek When testing I keep getting these errors: % make testacc TESTARGS='-run=TestAccSESV2ConfigurationSet_basic' PKG=sesv2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 3 -run=TestAccSESV2ConfigurationSet_basic -timeout 180m
=== RUN TestAccSESV2ConfigurationSet_basic
=== PAUSE TestAccSESV2ConfigurationSet_basic
=== CONT TestAccSESV2ConfigurationSet_basic
configuration_set_test.go:25: Step 1/2 error: Error running apply: exit status 1
Error: reading Amazon SESv2 (Simple Email V2) Configuration Set (tf-acc-test-6907488776219186461): operation error SESv2: ListTagsForResource, exceeded maximum number of attempts, 25, https response error StatusCode: 500, RequestID: cf63abf4-e8f1-405b-840b-c15a64987e8a, api error InternalFailure: UnknownError
with aws_sesv2_configuration_set.test,
on terraform_plugin_test.tf line 2, in resource "aws_sesv2_configuration_set" "test":
2: resource "aws_sesv2_configuration_set" "test" {
--- FAIL: TestAccSESV2ConfigurationSet_basic (430.85s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/sesv2 434.772s
FAIL
make: *** [testacc] Error 1 |
Hey @ewbankkit, really weird. I just tried again and it passes for me.
From the error you got looks like it was an internal error on AWS side. Can you please try running these tests again? |
Hey @ewbankkit, do you have any updates? Let me know if there's anything I can do to resolve the issues 👍 |
Hey @kamilturek - this looks great. Just made a couple small changes:
$ aws sesv2 list-tags-for-resource --resource-arn arn:aws:sesv2:us-west-2:012345678901:configuration-set/jb-test
An error occurred (InternalFailure) when calling the ListTagsForResource operation (reached max retries: 2): None
$ aws sesv2 list-tags-for-resource --resource-arn arn:aws:ses:us-west-2:012345678901:configuration-set/jb-test
{
"Tags": []
} |
➜ make testacc PKG=sesv2 TESTS="TestAccSESV2ConfigurationSet_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2ConfigurationSet_' -timeout 180m
=== RUN TestAccSESV2ConfigurationSet_basic
=== PAUSE TestAccSESV2ConfigurationSet_basic
=== RUN TestAccSESV2ConfigurationSet_disappears
=== PAUSE TestAccSESV2ConfigurationSet_disappears
=== RUN TestAccSESV2ConfigurationSet_tlsPolicy
=== PAUSE TestAccSESV2ConfigurationSet_tlsPolicy
=== RUN TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== PAUSE TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== RUN TestAccSESV2ConfigurationSet_sendingEnabled
=== PAUSE TestAccSESV2ConfigurationSet_sendingEnabled
=== RUN TestAccSESV2ConfigurationSet_suppressedReasons
=== PAUSE TestAccSESV2ConfigurationSet_suppressedReasons
=== RUN TestAccSESV2ConfigurationSet_tags
=== PAUSE TestAccSESV2ConfigurationSet_tags
=== CONT TestAccSESV2ConfigurationSet_basic
=== CONT TestAccSESV2ConfigurationSet_sendingEnabled
=== CONT TestAccSESV2ConfigurationSet_tlsPolicy
=== CONT TestAccSESV2ConfigurationSet_disappears
=== CONT TestAccSESV2ConfigurationSet_tags
=== CONT TestAccSESV2ConfigurationSet_suppressedReasons
=== CONT TestAccSESV2ConfigurationSet_reputationMetricsEnabled
--- PASS: TestAccSESV2ConfigurationSet_disappears (14.49s)
--- PASS: TestAccSESV2ConfigurationSet_basic (19.43s)
--- PASS: TestAccSESV2ConfigurationSet_suppressedReasons (30.76s)
--- PASS: TestAccSESV2ConfigurationSet_sendingEnabled (30.95s)
--- PASS: TestAccSESV2ConfigurationSet_tlsPolicy (31.07s)
--- PASS: TestAccSESV2ConfigurationSet_reputationMetricsEnabled (31.09s)
--- PASS: TestAccSESV2ConfigurationSet_tags (42.00s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sesv2 44.613s |
Hey @jar-b. Perfect, many thanks for handling that! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for your contribution! 🚀
This functionality has been released in v4.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds the
aws_sesv2_configuration_set
resource.Relations
Relates #26796.
References
https://docs.aws.amazon.com/ses/latest/APIReference-V2/Welcome.html
Output from Acceptance Testing