Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALB target group defaults changed for healthy/unhealthy thresholds #2712

Closed
wvidana opened this issue Dec 19, 2017 · 3 comments
Closed

ALB target group defaults changed for healthy/unhealthy thresholds #2712

wvidana opened this issue Dec 19, 2017 · 3 comments
Labels
bug Addresses a defect in current functionality. service/elbv2 Issues and PRs that pertain to the elbv2 service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.

Comments

@wvidana
Copy link

wvidana commented Dec 19, 2017

Hi,

So this commit changed the target group default parameters 79467dc

This makes old code to have pending changes, when there are non. (By old I mean code applied with aws provider <1.3 and revisited now on 1.6). Also the defaults mismatch with the official AWS API for Application Load Balancer.

Is it necessary to define here defaults? Not sure if the Go SDK can provide those or the API call can relay on leaving them empty. In example, the UnhealthyThresholdCount now is forced to be 3, when it used to be 2, and AWS official API defaults to 2 for ALB (though that gets tricky for network load balancers, which I guess was the reason of the change).

If there is no other way around it, I wouldn't mind on updating my module to force my own default, though I would rather relay on official's AWS defaults, which differs between ALB and NLB.

Terraform Version

Terraform v0.11.1
provider.aws: version = "~> 1.6"

Affected Resource(s)

  • aws_alb_target_group

Expected Behavior

No code changes -> no terraform changes

Actual Behavior

terraform plan wants to make changes when there are no code changes.

References

@wvidana wvidana changed the title ALB target group defaults changed ALB target group defaults changed for healthy/unhealthy thresholds Dec 19, 2017
@wvidana
Copy link
Author

wvidana commented Dec 19, 2017

This PR #2380 seems to fix it for matcher, path and timeout, though not for the healthy and unhealthy thresholds yet.

@jen20 jen20 added the bug Addresses a defect in current functionality. label Dec 29, 2017
@radeksimko radeksimko added the service/elbv2 Issues and PRs that pertain to the elbv2 service. label Jan 28, 2018
@github-actions
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Mar 28, 2020
@ghost
Copy link

ghost commented May 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/elbv2 Issues and PRs that pertain to the elbv2 service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.
Projects
None yet
Development

No branches or pull requests

3 participants