-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use proper name for networking term Statmux #27223
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 (needs a few test runs and a core member to validate this)
It would be a breaking change. Going to update to deprecate the miss-spelled argument and add the correct. Should have this updated first thing next week. |
Statmux is a shortened name for Statistical Multiplexing See: https://en.wikipedia.org/wiki/Statistical_time-division_multiplexing
22bad63
to
4e0fb6d
Compare
$ make testacc TESTARGS='-run=TestAccMediaLive_serial/MultiplexProgram' PKG=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run=TestAccMediaLive_serial/MultiplexProgram -timeout 180m
=== RUN TestAccMediaLive_serial
=== RUN TestAccMediaLive_serial/MultiplexProgram
=== RUN TestAccMediaLive_serial/MultiplexProgram/basic
=== RUN TestAccMediaLive_serial/MultiplexProgram/update
=== RUN TestAccMediaLive_serial/MultiplexProgram/disappears
--- PASS: TestAccMediaLive_serial (194.16s)
--- PASS: TestAccMediaLive_serial/MultiplexProgram (194.16s)
--- PASS: TestAccMediaLive_serial/MultiplexProgram/basic (57.59s)
--- PASS: TestAccMediaLive_serial/MultiplexProgram/update (65.34s)
--- PASS: TestAccMediaLive_serial/MultiplexProgram/disappears (71.23s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/medialive 196.889s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Statmux is a shortened name for Statistical Multiplexing
Rename code references from
statemux
andStatemux
tostatmux
andStatmux
respectively.Relations
Relates #4936
References
See:
Output from Acceptance Testing