r/aws_sesv2_email_identity: new resource

[kamilturek]

Description

This PR introduces new aws_sesv2_email_identity resource.

Relations

Relates #26796.
Closes #26927.
Closes #21129.
Closes #19363.
Closes #23312.
Closes #21672.

References

https://docs.aws.amazon.com/ses/latest/APIReference-V2/Welcome.html

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccSESV2EmailIdentity_' PKG=sesv2 ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 2  -run=TestAccSESV2EmailIdentity_ -timeout 180m
=== RUN   TestAccSESV2EmailIdentity_basic_emailAddress
=== PAUSE TestAccSESV2EmailIdentity_basic_emailAddress
=== RUN   TestAccSESV2EmailIdentity_basic_domain
=== PAUSE TestAccSESV2EmailIdentity_basic_domain
=== RUN   TestAccSESV2EmailIdentity_disappears
=== PAUSE TestAccSESV2EmailIdentity_disappears
=== RUN   TestAccSESV2EmailIdentity_configurationSetName
=== PAUSE TestAccSESV2EmailIdentity_configurationSetName
=== RUN   TestAccSESV2EmailIdentity_nextSigningKeyLength
=== PAUSE TestAccSESV2EmailIdentity_nextSigningKeyLength
=== RUN   TestAccSESV2EmailIdentity_domainSigning
=== PAUSE TestAccSESV2EmailIdentity_domainSigning
=== RUN   TestAccSESV2EmailIdentity_tags
=== PAUSE TestAccSESV2EmailIdentity_tags
=== CONT  TestAccSESV2EmailIdentity_basic_emailAddress
=== CONT  TestAccSESV2EmailIdentity_nextSigningKeyLength
--- PASS: TestAccSESV2EmailIdentity_basic_emailAddress (27.29s)
=== CONT  TestAccSESV2EmailIdentity_tags
--- PASS: TestAccSESV2EmailIdentity_nextSigningKeyLength (45.81s)
=== CONT  TestAccSESV2EmailIdentity_disappears
--- PASS: TestAccSESV2EmailIdentity_disappears (16.81s)
=== CONT  TestAccSESV2EmailIdentity_configurationSetName
--- PASS: TestAccSESV2EmailIdentity_tags (58.89s)
=== CONT  TestAccSESV2EmailIdentity_basic_domain
--- PASS: TestAccSESV2EmailIdentity_basic_domain (25.01s)
=== CONT  TestAccSESV2EmailIdentity_domainSigning
--- PASS: TestAccSESV2EmailIdentity_configurationSetName (54.12s)
--- PASS: TestAccSESV2EmailIdentity_domainSigning (53.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      166.895s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[kamilturek]

The CreateEmailIdentity action does not cover all email identity attributes. Additional configuration can be done through CreateEmailIdentityPolicy, PutEmailIdentityDkimAttributes(signing enabled), PutEmailIdentityFeedbackAttributes, PutEmailIdentityMailFromAttributes.

I'd say we should follow the most recent preferences/tendency of splitting out PUT APIs into their own resources, especially since the main create action (CreateEmailIdentity) does not allow configuring all attributes. This would mean creating related resources (provisional names): aws_sesv2_email_identity_policy, aws_sesv2_email_identity_feedback_attributes, aws_sesv2_email_identity_mail_from_attributes.

[kamilturek]

The failing CI check is not related to this PR.

[ewbankkit]

@kamilturek Yes, I'm addressing that failing CI check via #27425.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSESV2EmailIdentity_' PKG=sesv2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 2  -run=TestAccSESV2EmailIdentity_ -timeout 180m
=== RUN   TestAccSESV2EmailIdentity_basic_emailAddress
=== PAUSE TestAccSESV2EmailIdentity_basic_emailAddress
=== RUN   TestAccSESV2EmailIdentity_basic_domain
=== PAUSE TestAccSESV2EmailIdentity_basic_domain
=== RUN   TestAccSESV2EmailIdentity_disappears
=== PAUSE TestAccSESV2EmailIdentity_disappears
=== RUN   TestAccSESV2EmailIdentity_configurationSetName
=== PAUSE TestAccSESV2EmailIdentity_configurationSetName
=== RUN   TestAccSESV2EmailIdentity_nextSigningKeyLength
=== PAUSE TestAccSESV2EmailIdentity_nextSigningKeyLength
=== RUN   TestAccSESV2EmailIdentity_domainSigning
=== PAUSE TestAccSESV2EmailIdentity_domainSigning
=== RUN   TestAccSESV2EmailIdentity_tags
=== PAUSE TestAccSESV2EmailIdentity_tags
=== CONT  TestAccSESV2EmailIdentity_basic_emailAddress
=== CONT  TestAccSESV2EmailIdentity_domainSigning
--- PASS: TestAccSESV2EmailIdentity_basic_emailAddress (20.16s)
=== CONT  TestAccSESV2EmailIdentity_tags
--- PASS: TestAccSESV2EmailIdentity_domainSigning (34.03s)
=== CONT  TestAccSESV2EmailIdentity_configurationSetName
--- PASS: TestAccSESV2EmailIdentity_tags (42.33s)
=== CONT  TestAccSESV2EmailIdentity_nextSigningKeyLength
--- PASS: TestAccSESV2EmailIdentity_configurationSetName (31.75s)
=== CONT  TestAccSESV2EmailIdentity_disappears
--- PASS: TestAccSESV2EmailIdentity_disappears (13.21s)
=== CONT  TestAccSESV2EmailIdentity_basic_domain
--- PASS: TestAccSESV2EmailIdentity_nextSigningKeyLength (32.26s)
--- PASS: TestAccSESV2EmailIdentity_basic_domain (19.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	102.453s

[ewbankkit]

@kamilturek Thanks for the contribution 🎉 👏.

[kayrus]

@ewbankkit #24436 this is the most frustrating PR I ever made, thank you. Keep going with your opensource policy and people will praise you.

[github-actions]

This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.