-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vpc): Enable addition amazon provided ipv6 cidr #27274
feat(vpc): Enable addition amazon provided ipv6 cidr #27274
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @project0 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
e34f8f2
to
377212d
Compare
* Extend existing `vpc_ipv6_cidr_block_association` resource to allow requesting additional ipv6 CIDR from the amazon pool
377212d
to
56dea14
Compare
Currently, there are some limitations to manage VPC's IPv6 CIDR. I hope that this feature will be implemented quickly. |
What can we do to get movement here? 🙏 |
This reverts commit 56dea14.
…r_block` and `ipv6_pool` arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccVPCIPv6CIDRBlockAssociation_basic\|TestAccVPCIPv6CIDRBlockAssociation_disappears' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccVPCIPv6CIDRBlockAssociation_basic\|TestAccVPCIPv6CIDRBlockAssociation_disappears -timeout 360m
=== RUN TestAccVPCIPv6CIDRBlockAssociation_basic
=== PAUSE TestAccVPCIPv6CIDRBlockAssociation_basic
=== RUN TestAccVPCIPv6CIDRBlockAssociation_disappears
=== PAUSE TestAccVPCIPv6CIDRBlockAssociation_disappears
=== CONT TestAccVPCIPv6CIDRBlockAssociation_basic
=== CONT TestAccVPCIPv6CIDRBlockAssociation_disappears
--- PASS: TestAccVPCIPv6CIDRBlockAssociation_basic (51.13s)
--- PASS: TestAccVPCIPv6CIDRBlockAssociation_disappears (57.31s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 62.522s
@project0 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
vpc_ipv6_cidr_block_association
resource to allow requesting additional ipv6 CIDR from the amazon poolDescription
Relations
Closes #25136
References
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_AssociateVpcCidrBlock.html
Output from Acceptance Testing