Relocate Valid4ByteAsn function to common lib, add to CloudWAN Network Policy Doc Data Source #27305

schuylr · 2022-10-18T18:24:46Z

Description

This PR restores the validation for a 4-byte ASN on CloudWAN (Network Manager) Core Network Policy Document data source under Edge Locations. The validation was removed due to build failures on 32-bit systems, but can be restored by re-using the valid4ByteAsn function from the ec2 service provider as a common validation function.

This PR also modifies the ec2 service provider to use the relocated common validation function (tests below).

When terraform-plugin-framework becomes GA, the function can be modified to leverage Int64 as a new schema type.

No changelog entry created per these instructions

Relations

Closes #24902

References

https://github.com/hashicorp/terraform-provider-aws/pull/24890/files#r877631861
#14030
#1888

Output from Acceptance Testing

terraform-provider-aws % make testacc TESTS=TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic'  -timeout 180m
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic (9.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	13.749s

terraform-provider-aws % make testacc TESTS=TestAccSiteVPNCustomerGateway_4ByteASN PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccSiteVPNCustomerGateway_4ByteASN'  -timeout 180m
=== RUN   TestAccSiteVPNCustomerGateway_4ByteASN
=== PAUSE TestAccSiteVPNCustomerGateway_4ByteASN
=== CONT  TestAccSiteVPNCustomerGateway_4ByteASN
--- PASS: TestAccSiteVPNCustomerGateway_4ByteASN (25.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	29.842s

terraform-provider-aws % make testacc TESTARGS='-run=TestAccTransitGateway_serial/ConnectPeer/BgpAsn' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGateway_serial/ConnectPeer/BgpAsn -timeout 180m
=== RUN   TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/ConnectPeer
=== RUN   TestAccTransitGateway_serial/ConnectPeer/BgpAsn
--- PASS: TestAccTransitGateway_serial (479.25s)
    --- PASS: TestAccTransitGateway_serial/ConnectPeer (479.25s)
        --- PASS: TestAccTransitGateway_serial/ConnectPeer/BgpAsn (479.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	483.413s

terraform-provider-aws % make test TESTARGS='-v -count=1' TEST=./internal/verify/...
==> Checking that code complies with gofmt requirements...
go test ./internal/verify/... -v -count=1 -timeout=5m
=== RUN   TestBase64Encode
--- PASS: TestBase64Encode (0.00s)
=== RUN   TestCIDRBlocksEqual
--- PASS: TestCIDRBlocksEqual (0.00s)
=== RUN   TestCanonicalCIDRBlock
--- PASS: TestCanonicalCIDRBlock (0.00s)
=== RUN   TestSuppressEquivalentRoundedTime
--- PASS: TestSuppressEquivalentRoundedTime (0.00s)
=== RUN   TestSuppressEquivalentTypeStringBoolean
--- PASS: TestSuppressEquivalentTypeStringBoolean (0.00s)
=== RUN   TestDiffStringMaps
--- PASS: TestDiffStringMaps (0.00s)
=== RUN   TestLooksLikeJSONString
--- PASS: TestLooksLikeJSONString (0.00s)
=== RUN   TestJSONBytesEqualQuotedAndUnquoted
--- PASS: TestJSONBytesEqualQuotedAndUnquoted (0.00s)
=== RUN   TestJSONBytesEqualWhitespaceAndNoWhitespace
--- PASS: TestJSONBytesEqualWhitespaceAndNoWhitespace (0.00s)
=== RUN   TestSecondJSONUnlessEquivalent
--- PASS: TestSecondJSONUnlessEquivalent (0.00s)
=== RUN   TestNormalizeJSONOrYAMLString
--- PASS: TestNormalizeJSONOrYAMLString (0.00s)
=== RUN   TestSuppressEquivalentJSONDiffsWhitespaceAndNoWhitespace
--- PASS: TestSuppressEquivalentJSONDiffsWhitespaceAndNoWhitespace (0.00s)
=== RUN   TestSuppressEquivalentJSONOrYAMLDiffs
--- PASS: TestSuppressEquivalentJSONOrYAMLDiffs (0.00s)
=== RUN   TestSemVerLessThan
--- PASS: TestSemVerLessThan (0.00s)
=== RUN   TestSemVerGreaterThanOrEqual
--- PASS: TestSemVerGreaterThanOrEqual (0.00s)
=== RUN   TestValid4ByteASN
--- PASS: TestValid4ByteASN (0.00s)
=== RUN   TestValidTypeStringNullableBoolean
--- PASS: TestValidTypeStringNullableBoolean (0.00s)
=== RUN   TestValidTypeStringNullableFloat
--- PASS: TestValidTypeStringNullableFloat (0.00s)
=== RUN   TestValidAccountID
--- PASS: TestValidAccountID (0.00s)
=== RUN   TestValidARN
--- PASS: TestValidARN (0.00s)
=== RUN   TestValidateCIDRBlock
--- PASS: TestValidateCIDRBlock (0.00s)
=== RUN   TestValidCIDRNetworkAddress
--- PASS: TestValidCIDRNetworkAddress (0.00s)
=== RUN   TestValidIPv4CIDRBlock
--- PASS: TestValidIPv4CIDRBlock (0.00s)
=== RUN   TestValidIPv6CIDRBlock
--- PASS: TestValidIPv6CIDRBlock (0.00s)
=== RUN   TestIsIPv4CIDRBlockOrIPv6CIDRBlock
--- PASS: TestIsIPv4CIDRBlockOrIPv6CIDRBlock (0.00s)
=== RUN   TestValidIAMPolicyJSONString
--- PASS: TestValidIAMPolicyJSONString (0.00s)
=== RUN   TestValidStringIsJSONOrYAML
--- PASS: TestValidStringIsJSONOrYAML (0.00s)
=== RUN   TestValidOnceAWeekWindowFormat
--- PASS: TestValidOnceAWeekWindowFormat (0.00s)
=== RUN   TestValidOnceADayWindowFormat
--- PASS: TestValidOnceADayWindowFormat (0.00s)
=== RUN   TestValidLaunchTemplateName
--- PASS: TestValidLaunchTemplateName (0.00s)
=== RUN   TestValidLaunchTemplateID
--- PASS: TestValidLaunchTemplateID (0.00s)
=== RUN   TestValidUTCTimestamp
--- PASS: TestValidUTCTimestamp (0.00s)
=== RUN   TestValidateTypeStringIsDateOrInt
--- PASS: TestValidateTypeStringIsDateOrInt (0.00s)
=== RUN   TestFloatGreaterThan
--- PASS: TestFloatGreaterThan (0.00s)
=== RUN   TestCheckYAMLString
--- PASS: TestCheckYAMLString (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/verify	0.625s

… Network Policy Doc DS

github-actions · 2022-10-18T18:25:01Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

…alization in validation tests

github-actions

Welcome @schuylr 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

GlennChia

LGTM

gdavison · 2022-10-20T23:38:15Z

Since this PR adds a plan-time validation for the user, it should have a changeling entry. Something like "Add plan-time validation for core_network_configuration[].edge_locations[].asn

gdavison

Thanks for the PR, @schuylr. Moving the valid4ByteASN function looks good. I'm concerned that the change from an int to string for the asn value in the JSON document might not be accepted by the API calls where it's used

internal/service/networkmanager/core_network_policy_model.go

schuylr · 2022-10-21T14:07:08Z

I was double-checking this yesterday as I was adding the changelog comment. CloudWAN is indeed looking for an integer/number format in the JSON, so this type change is not accepted by AWS APIs.

In discussion with @GlennChia yesterday, I think the best approach will be to modify the Valid4ByteAsn function to accept an int, convert it to a string, then run it through a new Valid4ByteAsnString function with the existing logic here. Will modify this today.

… changelog

schuylr · 2022-10-21T18:54:50Z

New tests:

terraform-provider-aws % make testacc TESTS=TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic PKG=networkmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic'  -timeout 180m
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic (11.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	16.033s

terraform-provider-aws % make testacc TESTS=TestAccSiteVPNCustomerGateway_4ByteASN PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccSiteVPNCustomerGateway_4ByteASN'  -timeout 180m
=== RUN   TestAccSiteVPNCustomerGateway_4ByteASN
=== PAUSE TestAccSiteVPNCustomerGateway_4ByteASN
=== CONT  TestAccSiteVPNCustomerGateway_4ByteASN
--- PASS: TestAccSiteVPNCustomerGateway_4ByteASN (25.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	29.641s

terraform-provider-aws % make testacc TESTARGS='-run=TestAccTransitGateway_serial/ConnectPeer/BgpAsn' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGateway_serial/ConnectPeer/BgpAsn -timeout 180m
=== RUN   TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/ConnectPeer
=== RUN   TestAccTransitGateway_serial/ConnectPeer/BgpAsn
--- PASS: TestAccTransitGateway_serial (572.42s)
    --- PASS: TestAccTransitGateway_serial/ConnectPeer (572.42s)
        --- PASS: TestAccTransitGateway_serial/ConnectPeer/BgpAsn (572.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	576.521s

terraform-provider-aws % make test TESTARGS='-v -count=1' TEST=./internal/verify/...
==> Checking that code complies with gofmt requirements...
go test ./internal/verify/... -v -count=1 -timeout=5m
=== RUN   TestBase64Encode
--- PASS: TestBase64Encode (0.00s)
=== RUN   TestCIDRBlocksEqual
--- PASS: TestCIDRBlocksEqual (0.00s)
=== RUN   TestCanonicalCIDRBlock
--- PASS: TestCanonicalCIDRBlock (0.00s)
=== RUN   TestSuppressEquivalentRoundedTime
--- PASS: TestSuppressEquivalentRoundedTime (0.00s)
=== RUN   TestSuppressEquivalentTypeStringBoolean
--- PASS: TestSuppressEquivalentTypeStringBoolean (0.00s)
=== RUN   TestDiffStringMaps
--- PASS: TestDiffStringMaps (0.00s)
=== RUN   TestLooksLikeJSONString
--- PASS: TestLooksLikeJSONString (0.00s)
=== RUN   TestJSONBytesEqualQuotedAndUnquoted
--- PASS: TestJSONBytesEqualQuotedAndUnquoted (0.00s)
=== RUN   TestJSONBytesEqualWhitespaceAndNoWhitespace
--- PASS: TestJSONBytesEqualWhitespaceAndNoWhitespace (0.00s)
=== RUN   TestSecondJSONUnlessEquivalent
--- PASS: TestSecondJSONUnlessEquivalent (0.00s)
=== RUN   TestNormalizeJSONOrYAMLString
--- PASS: TestNormalizeJSONOrYAMLString (0.00s)
=== RUN   TestSuppressEquivalentJSONDiffsWhitespaceAndNoWhitespace
--- PASS: TestSuppressEquivalentJSONDiffsWhitespaceAndNoWhitespace (0.00s)
=== RUN   TestSuppressEquivalentJSONOrYAMLDiffs
--- PASS: TestSuppressEquivalentJSONOrYAMLDiffs (0.00s)
=== RUN   TestSemVerLessThan
--- PASS: TestSemVerLessThan (0.00s)
=== RUN   TestSemVerGreaterThanOrEqual
--- PASS: TestSemVerGreaterThanOrEqual (0.00s)
=== RUN   TestValid4ByteAsn
--- PASS: TestValid4ByteAsn (0.00s)
=== RUN   TestValid4ByteASNString
--- PASS: TestValid4ByteASNString (0.00s)
=== RUN   TestValidTypeStringNullableBoolean
--- PASS: TestValidTypeStringNullableBoolean (0.00s)
=== RUN   TestValidTypeStringNullableFloat
--- PASS: TestValidTypeStringNullableFloat (0.00s)
=== RUN   TestValidAccountID
--- PASS: TestValidAccountID (0.00s)
=== RUN   TestValidARN
--- PASS: TestValidARN (0.00s)
=== RUN   TestValidateCIDRBlock
--- PASS: TestValidateCIDRBlock (0.00s)
=== RUN   TestValidCIDRNetworkAddress
--- PASS: TestValidCIDRNetworkAddress (0.00s)
=== RUN   TestValidIPv4CIDRBlock
--- PASS: TestValidIPv4CIDRBlock (0.00s)
=== RUN   TestValidIPv6CIDRBlock
--- PASS: TestValidIPv6CIDRBlock (0.00s)
=== RUN   TestIsIPv4CIDRBlockOrIPv6CIDRBlock
--- PASS: TestIsIPv4CIDRBlockOrIPv6CIDRBlock (0.00s)
=== RUN   TestValidIAMPolicyJSONString
--- PASS: TestValidIAMPolicyJSONString (0.00s)
=== RUN   TestValidStringIsJSONOrYAML
--- PASS: TestValidStringIsJSONOrYAML (0.00s)
=== RUN   TestValidOnceAWeekWindowFormat
--- PASS: TestValidOnceAWeekWindowFormat (0.00s)
=== RUN   TestValidOnceADayWindowFormat
--- PASS: TestValidOnceADayWindowFormat (0.00s)
=== RUN   TestValidLaunchTemplateName
--- PASS: TestValidLaunchTemplateName (0.00s)
=== RUN   TestValidLaunchTemplateID
--- PASS: TestValidLaunchTemplateID (0.00s)
=== RUN   TestValidUTCTimestamp
--- PASS: TestValidUTCTimestamp (0.00s)
=== RUN   TestValidateTypeStringIsDateOrInt
--- PASS: TestValidateTypeStringIsDateOrInt (0.00s)
=== RUN   TestFloatGreaterThan
--- PASS: TestFloatGreaterThan (0.00s)
=== RUN   TestCheckYAMLString
--- PASS: TestCheckYAMLString (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/verify	0.614s

schuylr · 2022-10-21T19:01:13Z

internal/verify/validate.go

@@ -20,6 +20,27 @@ var accountIDRegexp = regexp.MustCompile(`^(aws|aws-managed|\d{12})$`)
 var partitionRegexp = regexp.MustCompile(`^aws(-[a-z]+)*$`)
 var regionRegexp = regexp.MustCompile(`^[a-z]{2}(-[a-z]+)+-\d$`)

+func Valid4ByteASN(v interface{}, k string) (ws []string, errors []error) {
+	stringValue := strconv.Itoa(v.(int))


@gdavison Can you see any concerns with the 32-bit BSD build on this?

ASN numbers are 32-bit unsigned values, so this will fail for any values between 2147483647 and 4294967295. Basically, for any resources using terraform-plugin-sdk (and therefore a TypeInt) we have to accept a TypeString and parse it into an int64. Technically, we could use a uint32, but the AWS API takes an int64

gdavison

Unfortunately, we can't use an int to contain uint32 values on a 32-bit platform. Instead we can use an int64, since that's what the AWS API takes

gdavison · 2022-10-25T23:01:43Z

internal/verify/validate.go

@@ -20,6 +20,27 @@ var accountIDRegexp = regexp.MustCompile(`^(aws|aws-managed|\d{12})$`)
 var partitionRegexp = regexp.MustCompile(`^aws(-[a-z]+)*$`)
 var regionRegexp = regexp.MustCompile(`^[a-z]{2}(-[a-z]+)+-\d$`)

+func Valid4ByteASN(v interface{}, k string) (ws []string, errors []error) {
+	stringValue := strconv.Itoa(v.(int))


ASN numbers are 32-bit unsigned values, so this will fail for any values between 2147483647 and 4294967295. Basically, for any resources using terraform-plugin-sdk (and therefore a TypeInt) we have to accept a TypeString and parse it into an int64. Technically, we could use a uint32, but the AWS API takes an int64

gdavison · 2022-10-25T23:03:42Z

internal/service/networkmanager/core_network_policy_document_data_source.go

@@ -160,8 +160,9 @@ func DataSourceCoreNetworkPolicyDocument() *schema.Resource {
 										ValidateFunc: verify.ValidRegionName,
 									},
 									"asn": {
-										Type:     schema.TypeInt,
-										Optional: true,
+										Type:         schema.TypeInt,


This should be changed to a schema.TypeString, which will be handled internally as an int64. We can take advantage of the Terraform parser which will allow some string values, such as numbers and boolean values to omit the quotes

…iguration.edge_locations.asn' -> 'TypeString'.

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_' PKG=networkmanager ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 2  -run=TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_ -timeout 180m
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic (92.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	99.341s
% make testacc TESTARGS='-run=TestAccSiteVPNCustomerGateway_4ByteASN\|TestAccTransitGateway_serial/ConnectPeer/BgpAsn' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccSiteVPNCustomerGateway_4ByteASN\|TestAccTransitGateway_serial/ConnectPeer/BgpAsn -timeout 180m
=== RUN   TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/ConnectPeer
=== RUN   TestAccTransitGateway_serial/ConnectPeer/BgpAsn
--- PASS: TestAccTransitGateway_serial (594.69s)
    --- PASS: TestAccTransitGateway_serial/ConnectPeer (594.69s)
        --- PASS: TestAccTransitGateway_serial/ConnectPeer/BgpAsn (594.68s)
=== RUN   TestAccSiteVPNCustomerGateway_4ByteASN
=== PAUSE TestAccSiteVPNCustomerGateway_4ByteASN
=== CONT  TestAccSiteVPNCustomerGateway_4ByteASN
--- PASS: TestAccSiteVPNCustomerGateway_4ByteASN (33.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	632.081s

ewbankkit · 2022-11-03T15:09:05Z

@schuylr Thanks for the contribution 🎉 👏.

schuylr · 2022-11-03T15:15:37Z

Thanks for your edits, learned a bunch!!

github-actions · 2022-11-03T19:49:31Z

This functionality has been released in v4.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-12-04T02:18:09Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Refactor Valid4ByteAsn validation function to common lib, add to Core…

3533a1d

… Network Policy Doc DS

Fix JSON validation for Core Network Policy Docs, Valid4ByteASN capit…

a828943

…alization in validation tests

github-actions bot reviewed Oct 18, 2022

View reviewed changes

ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 19, 2022

GlennChia approved these changes Oct 20, 2022

View reviewed changes

gdavison self-assigned this Oct 20, 2022

gdavison reviewed Oct 21, 2022

View reviewed changes

internal/service/networkmanager/core_network_policy_model.go Outdated Show resolved Hide resolved

Split Valid4ByteASN into two functions for different input types, add…

4f9aebd

… changelog

schuylr commented Oct 21, 2022

View reviewed changes

gdavison requested changes Oct 25, 2022

View reviewed changes

ewbankkit added 4 commits November 3, 2022 09:12

Tweak CHANGELOG entry.

3f5165b

d/aws_networkmanager_core_network_policy_document: 'core_network_conf…

434ff35

…iguration.edge_locations.asn' -> 'TypeString'.

Remove 'verify.Valid4ByteASN'.

0de69f8

'verify.Valid4ByteASNString' -> 'verify.Valid4ByteASN'.

2cf8aac

ewbankkit added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Nov 3, 2022

ewbankkit approved these changes Nov 3, 2022

View reviewed changes

ewbankkit merged commit f8e94f0 into hashicorp:main Nov 3, 2022

github-actions bot added this to the v4.38.0 milestone Nov 3, 2022

schuylr deleted the td-4_byte_asn_refactor branch November 3, 2022 15:15

github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022

justinretzolk added the partner Contribution from a partner. label May 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Relocate Valid4ByteAsn function to common lib, add to CloudWAN Network Policy Doc Data Source #27305

Relocate Valid4ByteAsn function to common lib, add to CloudWAN Network Policy Doc Data Source #27305

schuylr commented Oct 18, 2022 •

edited

Loading

github-actions bot commented Oct 18, 2022

github-actions bot left a comment

GlennChia left a comment

gdavison commented Oct 20, 2022 •

edited

Loading

gdavison left a comment

schuylr commented Oct 21, 2022 •

edited

Loading

schuylr commented Oct 21, 2022

schuylr Oct 21, 2022

gdavison Oct 25, 2022

gdavison left a comment

gdavison Oct 25, 2022

gdavison Oct 25, 2022

ewbankkit left a comment

ewbankkit commented Nov 3, 2022

schuylr commented Nov 3, 2022

github-actions bot commented Nov 3, 2022

github-actions bot commented Dec 4, 2022

Relocate Valid4ByteAsn function to common lib, add to CloudWAN Network Policy Doc Data Source #27305

Relocate Valid4ByteAsn function to common lib, add to CloudWAN Network Policy Doc Data Source #27305

Conversation

schuylr commented Oct 18, 2022 • edited Loading

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Oct 18, 2022

Community Note

github-actions bot left a comment

Choose a reason for hiding this comment

GlennChia left a comment

Choose a reason for hiding this comment

gdavison commented Oct 20, 2022 • edited Loading

gdavison left a comment

Choose a reason for hiding this comment

schuylr commented Oct 21, 2022 • edited Loading

schuylr commented Oct 21, 2022

schuylr Oct 21, 2022

Choose a reason for hiding this comment

gdavison Oct 25, 2022

Choose a reason for hiding this comment

gdavison left a comment

Choose a reason for hiding this comment

gdavison Oct 25, 2022

Choose a reason for hiding this comment

gdavison Oct 25, 2022

Choose a reason for hiding this comment

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Nov 3, 2022

schuylr commented Nov 3, 2022

github-actions bot commented Nov 3, 2022

github-actions bot commented Dec 4, 2022

schuylr commented Oct 18, 2022 •

edited

Loading

gdavison commented Oct 20, 2022 •

edited

Loading

schuylr commented Oct 21, 2022 •

edited

Loading