New Resources: `aws_lightsail_lb` and `aws_lightsail_lb_attachment` #27339

brittandeyoung · 2022-10-19T20:27:01Z

Description

Adds the following resources to terraform aws_lightsail_lb and aws_lightsail_lb_attachment. This Pull request includes the orriginal commits from this Pull request #11405 and refactors it to bring it up to speed with the new provider layout.

Relations

Closes #11049
Closes #11421

Relates #11405

References

Output from Acceptance Testing

➜ terraform-provider-aws (f-aws_lightsail_lb) ✗ make testacc TESTARGS='-run=TestAccLightsailLoadBalancerAttachment_' PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailLoadBalancerAttachment_ -timeout 180m
=== RUN   TestAccLightsailLoadBalancerAttachment_basic
=== PAUSE TestAccLightsailLoadBalancerAttachment_basic
=== RUN   TestAccLightsailLoadBalancerAttachment_disappears
=== PAUSE TestAccLightsailLoadBalancerAttachment_disappears
=== CONT  TestAccLightsailLoadBalancerAttachment_disappears
=== CONT  TestAccLightsailLoadBalancerAttachment_basic
--- PASS: TestAccLightsailLoadBalancerAttachment_basic (499.02s)
--- PASS: TestAccLightsailLoadBalancerAttachment_disappears (509.77s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  511.759s
➜ terraform-provider-aws (f-aws_lightsail_lb) ✗ make testacc TESTARGS='-run=TestAccLightsailLoadBalancer_' PKG=lightsail 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailLoadBalancer_ -timeout 180m
=== RUN   TestAccLightsailLoadBalancer_basic
=== PAUSE TestAccLightsailLoadBalancer_basic
=== RUN   TestAccLightsailLoadBalancer_Name
=== PAUSE TestAccLightsailLoadBalancer_Name
=== RUN   TestAccLightsailLoadBalancer_HealthCheckPath
=== PAUSE TestAccLightsailLoadBalancer_HealthCheckPath
=== RUN   TestAccLightsailLoadBalancer_Tags
=== PAUSE TestAccLightsailLoadBalancer_Tags
=== RUN   TestAccLightsailLoadBalancer_disappears
=== PAUSE TestAccLightsailLoadBalancer_disappears
=== CONT  TestAccLightsailLoadBalancer_basic
=== CONT  TestAccLightsailLoadBalancer_Tags
=== CONT  TestAccLightsailLoadBalancer_disappears
=== CONT  TestAccLightsailLoadBalancer_HealthCheckPath
=== CONT  TestAccLightsailLoadBalancer_Name
--- PASS: TestAccLightsailLoadBalancer_disappears (112.94s)
--- PASS: TestAccLightsailLoadBalancer_basic (120.38s)
--- PASS: TestAccLightsailLoadBalancer_HealthCheckPath (134.49s)
--- PASS: TestAccLightsailLoadBalancer_Tags (145.30s)
--- PASS: TestAccLightsailLoadBalancer_Name (236.07s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  238.032s

...

…tsail resources.

Reference: hashicorp#14712

Reference: hashicorp#14551

Action Required: Removal of website/aws.erb File

This Spelling error is already resolved in the main branch and this change is causing a conflict.

* Added dns_name to Read

Removed conflict, removed SetPartial

* terrafmt issue * Removed provider from tests * added missing semgrp.yml config file

…r-aws into patch-2

Fixed: Linting issues and sync upstream

* old reference to glue * string reference oid * waiter import

Feature: Path acctests added

Requested Changes Implemented

* Add acceptance tests for `aws_lightsail_lb` resource.

Update functions to use context

github-actions · 2022-10-19T20:27:17Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

* moved from testDestroy to acctest.CheckResourceDisappears

Add checkdestroy

* move import to use new context function

* remove extra new lines flagged by golangci-lint

brittandeyoung · 2022-10-20T13:07:56Z

Latest test output with most recent changes:

➜ terraform-provider-aws (f-aws_lightsail_lb) ✔ make testacc TESTARGS='-run=TestAccLightsailLoadBalancer' PKG=lightsail ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 5  -run=TestAccLightsailLoadBalancer -timeout 180m
=== RUN   TestAccLightsailLoadBalancerAttachment_basic
=== PAUSE TestAccLightsailLoadBalancerAttachment_basic
=== RUN   TestAccLightsailLoadBalancerAttachment_disappears
=== PAUSE TestAccLightsailLoadBalancerAttachment_disappears
=== RUN   TestAccLightsailLoadBalancer_basic
=== PAUSE TestAccLightsailLoadBalancer_basic
=== RUN   TestAccLightsailLoadBalancer_Name
=== PAUSE TestAccLightsailLoadBalancer_Name
=== RUN   TestAccLightsailLoadBalancer_HealthCheckPath
=== PAUSE TestAccLightsailLoadBalancer_HealthCheckPath
=== RUN   TestAccLightsailLoadBalancer_Tags
=== PAUSE TestAccLightsailLoadBalancer_Tags
=== RUN   TestAccLightsailLoadBalancer_disappears
=== PAUSE TestAccLightsailLoadBalancer_disappears
=== CONT  TestAccLightsailLoadBalancerAttachment_basic
=== CONT  TestAccLightsailLoadBalancer_HealthCheckPath
=== CONT  TestAccLightsailLoadBalancer_basic
=== CONT  TestAccLightsailLoadBalancer_disappears
=== CONT  TestAccLightsailLoadBalancer_Name
--- PASS: TestAccLightsailLoadBalancer_disappears (113.11s)
=== CONT  TestAccLightsailLoadBalancerAttachment_disappears
=== CONT  TestAccLightsailLoadBalancer_Tags
--- PASS: TestAccLightsailLoadBalancer_basic (118.69s)
--- PASS: TestAccLightsailLoadBalancer_HealthCheckPath (148.38s)
--- PASS: TestAccLightsailLoadBalancer_Name (239.62s)
--- PASS: TestAccLightsailLoadBalancer_Tags (145.05s)
--- PASS: TestAccLightsailLoadBalancerAttachment_basic (509.47s)
--- PASS: TestAccLightsailLoadBalancerAttachment_disappears (505.23s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  620.305s

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLightsailLoadBalancer' PKG=lightsail ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 3  -run=TestAccLightsailLoadBalancer -timeout 180m
=== RUN   TestAccLightsailLoadBalancerAttachment_basic
=== PAUSE TestAccLightsailLoadBalancerAttachment_basic
=== RUN   TestAccLightsailLoadBalancerAttachment_disappears
=== PAUSE TestAccLightsailLoadBalancerAttachment_disappears
=== RUN   TestAccLightsailLoadBalancer_basic
=== PAUSE TestAccLightsailLoadBalancer_basic
=== RUN   TestAccLightsailLoadBalancer_Name
=== PAUSE TestAccLightsailLoadBalancer_Name
=== RUN   TestAccLightsailLoadBalancer_HealthCheckPath
=== PAUSE TestAccLightsailLoadBalancer_HealthCheckPath
=== RUN   TestAccLightsailLoadBalancer_Tags
=== PAUSE TestAccLightsailLoadBalancer_Tags
=== RUN   TestAccLightsailLoadBalancer_disappears
=== PAUSE TestAccLightsailLoadBalancer_disappears
=== CONT  TestAccLightsailLoadBalancerAttachment_basic
=== CONT  TestAccLightsailLoadBalancer_HealthCheckPath
=== CONT  TestAccLightsailLoadBalancer_basic
--- PASS: TestAccLightsailLoadBalancer_basic (120.32s)
=== CONT  TestAccLightsailLoadBalancer_Name
--- PASS: TestAccLightsailLoadBalancer_HealthCheckPath (139.60s)
=== CONT  TestAccLightsailLoadBalancer_disappears
--- PASS: TestAccLightsailLoadBalancer_disappears (121.91s)
=== CONT  TestAccLightsailLoadBalancerAttachment_disappears
--- PASS: TestAccLightsailLoadBalancer_Name (234.37s)
=== CONT  TestAccLightsailLoadBalancer_Tags
--- PASS: TestAccLightsailLoadBalancerAttachment_basic (504.03s)
--- PASS: TestAccLightsailLoadBalancer_Tags (164.36s)
--- PASS: TestAccLightsailLoadBalancerAttachment_disappears (499.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	765.017s

github-actions · 2022-10-20T23:10:10Z

This functionality has been released in v4.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-11-21T02:31:24Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

akonrath and others added 30 commits December 21, 2019 22:52

Added Lightsail load balancer resource, fixed 'disapear' typo in ligh…

26862f2

…tsail resources.

Action Required: Removal of website/aws.erb File

3e88cf8

Reference: hashicorp#14712

Fixed: Action Required: Terraform Plugin SDK V2

4fa9805

Reference: hashicorp#14551

Merge pull request #83 from brittandeyoung/patch-1

a4dcde1

Action Required: Removal of website/aws.erb File

Removed conflicting changes

43bbaf4

This Spelling error is already resolved in the main branch and this change is causing a conflict.

* Fixed usage of SetPartial

7f65c40

* Added dns_name to Read

Merge pull request #88 from brittandeyoung/patch-2

955b12f

Removed conflict, removed SetPartial

Fixed:

9e4d71b

* terrafmt issue * Removed provider from tests * added missing semgrp.yml config file

Merge branch 'main' of https://github.com/hashicorp/terraform-provide…

b48d5c6

…r-aws into patch-2

fixed: AWSR002

7c24c54

Merge pull request #91 from brittandeyoung/patch-2

89b5467

Fixed: Linting issues and sync upstream

Created Internal Waiter files

a2c4807

FIxed:

6a146ba

* old reference to glue * string reference oid * waiter import

added aws sdk import

df2e0e3

Fixed: Waiter input type

26ae514

Feature: Path acctests added

Updated healthcheckpath test name

d9beabd

fixed import order an String format

be02e54

switched to aws.stringvalue

72ad656

resolved import order

cb72b94

Merge pull request #96 from brittandeyoung/patch-2

9c4e385

Requested Changes Implemented

Merge branch 'feature/lightsail-akonrath'

5551236

lightsail: Amend consts add ResLoadBalancer

acffe67

lightsail: Amend find add FindLoadBalancerByName

841e27b

lightsail: Add lb resource

d2157fd

provider: Amend provider to add aws_lightsail_lb

57a637d

lightsail: Add aws_lightsail_lb_test

cd77a7d

* Add acceptance tests for `aws_lightsail_lb` resource.

Lightsail: Amend lb remove d.SetId()

ce6167c

Docs: Add lightsail_lb resource docs

23a85d3

lightsail: Amend consts add ResLoadBalancerAttachment

6d5b368

lightsail: Amend find Add FindLoadBalancerAttachmentById

4aa9f69

brittandeyoung added 6 commits October 19, 2022 16:19

lightsail: Add lb_attachment resource

01d66ce

lightsail: Add lb_attachment_test

0866119

lightsail: Amend lb

3bbbd59

Update functions to use context

docs: Add lightsail_lb_attachment docs

325636b

Merge branch 'main' into f-aws_lightsail_lb

213498f

lightsail: terrafmt tests

5ef7ced

brittandeyoung added 3 commits October 19, 2022 16:33

lightsail: Amend lb_attachement_test testdestroy

b5635b8

* moved from testDestroy to acctest.CheckResourceDisappears

changelog: add 27339 changelog

13c380a

lightsail: Amend lb_test and lb_attachment_test

f5e8a55

Add checkdestroy

ewbankkit added new-resource Introduces a new resource. enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 20, 2022

brittandeyoung added 3 commits October 20, 2022 08:44

lightsail: Amend lb and lb_attachment

5e79a0b

* move import to use new context function

docs: lightsail lb and lb_attachment lint fix

e9b5e1a

lightsail: Amend lb and lb_attachment golangci-lint

d59ab53

* remove extra new lines flagged by golangci-lint

ewbankkit approved these changes Oct 20, 2022

View reviewed changes

ewbankkit merged commit 9372a5e into hashicorp:main Oct 20, 2022

github-actions bot added this to the v4.36.0 milestone Oct 20, 2022

github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resources: `aws_lightsail_lb` and `aws_lightsail_lb_attachment` #27339

New Resources: `aws_lightsail_lb` and `aws_lightsail_lb_attachment` #27339

brittandeyoung commented Oct 19, 2022 •

edited

Loading

github-actions bot commented Oct 19, 2022

brittandeyoung commented Oct 20, 2022

ewbankkit left a comment

github-actions bot commented Oct 20, 2022

github-actions bot commented Nov 21, 2022

New Resources: aws_lightsail_lb and aws_lightsail_lb_attachment #27339

New Resources: aws_lightsail_lb and aws_lightsail_lb_attachment #27339

Conversation

brittandeyoung commented Oct 19, 2022 • edited Loading

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Oct 19, 2022

Community Note

brittandeyoung commented Oct 20, 2022

ewbankkit left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 20, 2022

github-actions bot commented Nov 21, 2022

New Resources: `aws_lightsail_lb` and `aws_lightsail_lb_attachment` #27339

New Resources: `aws_lightsail_lb` and `aws_lightsail_lb_attachment` #27339

brittandeyoung commented Oct 19, 2022 •

edited

Loading