Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: aws_dynamodb_table_item #27504

Merged
merged 17 commits into from
Nov 7, 2022
Merged

New Data Source: aws_dynamodb_table_item #27504

merged 17 commits into from
Nov 7, 2022

Conversation

breathingdust
Copy link
Member

@breathingdust breathingdust commented Oct 27, 2022

Description

Relations

Closes #9462.
Relates #26080.

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccDynamoDBTableItemDataSource_' PKG=dynamodb 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20  -run=TestAccDynamoDBTableItemDataSource_ -timeout 180m
=== RUN   TestAccDynamoDBTableItemDataSource_basic
=== PAUSE TestAccDynamoDBTableItemDataSource_basic
=== RUN   TestAccDynamoDBTableItemDataSource_projectionExpression
=== PAUSE TestAccDynamoDBTableItemDataSource_projectionExpression
=== RUN   TestAccDynamoDBTableItemDataSource_expressionAttributeNames
=== PAUSE TestAccDynamoDBTableItemDataSource_expressionAttributeNames
=== CONT  TestAccDynamoDBTableItemDataSource_basic
=== CONT  TestAccDynamoDBTableItemDataSource_expressionAttributeNames
=== CONT  TestAccDynamoDBTableItemDataSource_projectionExpression
--- PASS: TestAccDynamoDBTableItemDataSource_basic (37.72s)
--- PASS: TestAccDynamoDBTableItemDataSource_expressionAttributeNames (37.74s)
--- PASS: TestAccDynamoDBTableItemDataSource_projectionExpression (37.74s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   41.262s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. github_actions Pull requests that update Github_actions code provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/dynamodb Issues and PRs that pertain to the dynamodb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 27, 2022
@github-actions github-actions bot removed repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. github_actions Pull requests that update Github_actions code labels Oct 27, 2022
@breathingdust breathingdust marked this pull request as ready for review October 27, 2022 06:47
@ewbankkit ewbankkit added the new-data-source Introduces a new data source. label Oct 27, 2022
@ewbankkit ewbankkit self-assigned this Nov 7, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDynamoDBTableItemDataSource_' PKG=dynamodb ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 2  -run=TestAccDynamoDBTableItemDataSource_ -timeout 180m
=== RUN   TestAccDynamoDBTableItemDataSource_basic
=== PAUSE TestAccDynamoDBTableItemDataSource_basic
=== RUN   TestAccDynamoDBTableItemDataSource_projectionExpression
=== PAUSE TestAccDynamoDBTableItemDataSource_projectionExpression
=== RUN   TestAccDynamoDBTableItemDataSource_expressionAttributeNames
=== PAUSE TestAccDynamoDBTableItemDataSource_expressionAttributeNames
=== CONT  TestAccDynamoDBTableItemDataSource_basic
=== CONT  TestAccDynamoDBTableItemDataSource_expressionAttributeNames
--- PASS: TestAccDynamoDBTableItemDataSource_basic (34.27s)
=== CONT  TestAccDynamoDBTableItemDataSource_projectionExpression
--- PASS: TestAccDynamoDBTableItemDataSource_expressionAttributeNames (35.07s)
--- PASS: TestAccDynamoDBTableItemDataSource_projectionExpression (28.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	71.183s

@ewbankkit ewbankkit merged commit 3e6d85f into main Nov 7, 2022
@ewbankkit ewbankkit deleted the f-ddb-item-ds branch November 7, 2022 13:19
@github-actions github-actions bot added this to the v4.39.0 milestone Nov 7, 2022
github-actions bot pushed a commit that referenced this pull request Nov 7, 2022
@github-actions
Copy link

This functionality has been released in v4.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/dynamodb Issues and PRs that pertain to the dynamodb service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Source for aws_dynamodb_table_item
2 participants