-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resources: aws_lightsail_disk
and aws_lightsail_disk_attachment
#27537
New Resources: aws_lightsail_disk
and aws_lightsail_disk_attachment
#27537
Conversation
Community NoteVoting for Prioritization
For Submitters
|
* remove unnecessary use of fmt.Sprintf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccLightsailDisk' PKG=lightsail ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 2 -run=TestAccLightsailDisk -timeout 180m
=== RUN TestAccLightsailDiskAttachment_basic
=== PAUSE TestAccLightsailDiskAttachment_basic
=== RUN TestAccLightsailDiskAttachment_disappears
=== PAUSE TestAccLightsailDiskAttachment_disappears
=== RUN TestAccLightsailDisk_basic
=== PAUSE TestAccLightsailDisk_basic
=== RUN TestAccLightsailDisk_Tags
=== PAUSE TestAccLightsailDisk_Tags
=== RUN TestAccLightsailDisk_disappears
=== PAUSE TestAccLightsailDisk_disappears
=== CONT TestAccLightsailDiskAttachment_basic
=== CONT TestAccLightsailDisk_Tags
--- PASS: TestAccLightsailDisk_Tags (86.56s)
=== CONT TestAccLightsailDisk_basic
--- PASS: TestAccLightsailDisk_basic (54.32s)
=== CONT TestAccLightsailDisk_disappears
--- PASS: TestAccLightsailDiskAttachment_basic (187.45s)
=== CONT TestAccLightsailDiskAttachment_disappears
--- PASS: TestAccLightsailDisk_disappears (49.41s)
--- PASS: TestAccLightsailDiskAttachment_disappears (192.76s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lightsail 384.399s
@brittandeyoung Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR provides the following two resources:
aws_lightsail_disk
andaws_lightsail_disk_attachment
Users will be able to manage lightsail disks and attaching them to instances with terraform.
This is a revive of the #9975 pull request. I was unable to pull in commits from that PR as i received an access denied error when attempting.
Relations
Closes #9975
References
Output from Acceptance Testing