aws_s3_bucket: Remove optional from arn and hosted_zone_id

[cgetzen]

Description

Currently, the arn and hosted_zone_id attributes are marked as optional, hinting that they can be set within a resource block (as opposed to being solely computed attributes).

However, arn and hosted_zone_id should never be set with user-generated values. arn is derived from other attributes, and hosted_zone_id is looked up here.

Relations

n/a

References

https://discuss.hashicorp.com/t/providers-schema-how-to-distinguish-attributes-from-arguments/5029/3

Output from Acceptance Testing

$ make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Hey @cgetzen 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

[cgetzen]

This PR is from a github organization.

Who can use this feature
People with push access to the upstream repository of a fork owned by a personal account can commit to the forked branches.

It looks like I can only allow changes from personal account fork.
I'm happy to recreate the PR on a personal fork, or apply feedback from maintainers to this PR.

[gdavison]

Great catch, @cgetzen! That's been there for a long time

[github-actions]

This functionality has been released in v4.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[apmovamo]

I think the Documentation about the AWS S3 bucket should be changed. It still shows for the last terraform version that the hosted_zone_id is an attribute.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.