Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redshift endpoint authorization resource #27654

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

DrFaust92
Copy link
Collaborator

Description

Relations

Closes #27593

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccRedshiftEndpointAuthorization_ PKG=redshift

--- PASS: TestAccRedshiftEndpointAuthorization_basic (453.30s)
--- PASS: TestAccRedshiftEndpointAuthorization_vpcs (453.57s)
--- PASS: TestAccRedshiftEndpointAuthorization_disappears (458.41s)
--- PASS: TestAccRedshiftEndpointAuthorization_disappears_cluster (461.93s)

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/redshift Issues and PRs that pertain to the redshift service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Nov 4, 2022
@DrFaust92 DrFaust92 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 4, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review November 4, 2022 19:41
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRedshiftEndpointAuthorization_' PKG=redshift ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 2  -run=TestAccRedshiftEndpointAuthorization_ -timeout 180m
=== RUN   TestAccRedshiftEndpointAuthorization_basic
=== PAUSE TestAccRedshiftEndpointAuthorization_basic
=== RUN   TestAccRedshiftEndpointAuthorization_vpcs
=== PAUSE TestAccRedshiftEndpointAuthorization_vpcs
=== RUN   TestAccRedshiftEndpointAuthorization_disappears
=== PAUSE TestAccRedshiftEndpointAuthorization_disappears
=== RUN   TestAccRedshiftEndpointAuthorization_disappears_cluster
=== PAUSE TestAccRedshiftEndpointAuthorization_disappears_cluster
=== CONT  TestAccRedshiftEndpointAuthorization_basic
=== CONT  TestAccRedshiftEndpointAuthorization_disappears
--- PASS: TestAccRedshiftEndpointAuthorization_basic (282.44s)
=== CONT  TestAccRedshiftEndpointAuthorization_disappears_cluster
--- PASS: TestAccRedshiftEndpointAuthorization_disappears (404.98s)
=== CONT  TestAccRedshiftEndpointAuthorization_vpcs
--- PASS: TestAccRedshiftEndpointAuthorization_disappears_cluster (451.27s)
--- PASS: TestAccRedshiftEndpointAuthorization_vpcs (365.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	774.378s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6544fda into hashicorp:main Nov 7, 2022
@github-actions github-actions bot added this to the v4.39.0 milestone Nov 7, 2022
@github-actions
Copy link

This functionality has been released in v4.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/redshift Issues and PRs that pertain to the redshift service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New]: Support for Redshift aws_redshift_authorize_endpoint_access Resource
2 participants