-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cognito identity pool - Dont update unrelated changes on tag changes #27669
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCognitoIdentityPool_' PKG=cognitoidentity ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidentity/... -v -count 1 -parallel 2 -run=TestAccCognitoIdentityPool_ -timeout 180m
=== RUN TestAccCognitoIdentityPool_basic
=== PAUSE TestAccCognitoIdentityPool_basic
=== RUN TestAccCognitoIdentityPool_DeveloperProviderName
=== PAUSE TestAccCognitoIdentityPool_DeveloperProviderName
=== RUN TestAccCognitoIdentityPool_supportedLoginProviders
=== PAUSE TestAccCognitoIdentityPool_supportedLoginProviders
=== RUN TestAccCognitoIdentityPool_openidConnectProviderARNs
=== PAUSE TestAccCognitoIdentityPool_openidConnectProviderARNs
=== RUN TestAccCognitoIdentityPool_samlProviderARNs
=== PAUSE TestAccCognitoIdentityPool_samlProviderARNs
=== RUN TestAccCognitoIdentityPool_cognitoIdentityProviders
=== PAUSE TestAccCognitoIdentityPool_cognitoIdentityProviders
=== RUN TestAccCognitoIdentityPool_addingNewProviderKeepsOldProvider
--- PASS: TestAccCognitoIdentityPool_addingNewProviderKeepsOldProvider (42.01s)
=== RUN TestAccCognitoIdentityPool_tags
=== PAUSE TestAccCognitoIdentityPool_tags
=== RUN TestAccCognitoIdentityPool_disappears
=== PAUSE TestAccCognitoIdentityPool_disappears
=== CONT TestAccCognitoIdentityPool_basic
=== CONT TestAccCognitoIdentityPool_samlProviderARNs
--- PASS: TestAccCognitoIdentityPool_basic (29.76s)
=== CONT TestAccCognitoIdentityPool_tags
--- PASS: TestAccCognitoIdentityPool_samlProviderARNs (42.72s)
=== CONT TestAccCognitoIdentityPool_disappears
--- PASS: TestAccCognitoIdentityPool_disappears (12.78s)
=== CONT TestAccCognitoIdentityPool_supportedLoginProviders
--- PASS: TestAccCognitoIdentityPool_tags (41.52s)
=== CONT TestAccCognitoIdentityPool_openidConnectProviderARNs
--- PASS: TestAccCognitoIdentityPool_supportedLoginProviders (40.97s)
=== CONT TestAccCognitoIdentityPool_cognitoIdentityProviders
--- PASS: TestAccCognitoIdentityPool_openidConnectProviderARNs (40.54s)
=== CONT TestAccCognitoIdentityPool_DeveloperProviderName
--- PASS: TestAccCognitoIdentityPool_cognitoIdentityProviders (42.60s)
--- PASS: TestAccCognitoIdentityPool_DeveloperProviderName (32.13s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity 190.469s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #27564
References
Output from Acceptance Testing