Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cognito identity pool - Dont update unrelated changes on tag changes #27669

Merged
merged 5 commits into from
Nov 7, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Nov 6, 2022

Description

Relations

Closes #27564

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccCognitoIdentityPool_ PKG=cognitoidentity

--- PASS: TestAccCognitoIdentityPool_addingNewProviderKeepsOldProvider (80.16s)
--- PASS: TestAccCognitoIdentityPool_disappears (21.48s)
--- PASS: TestAccCognitoIdentityPool_basic (51.54s)
--- PASS: TestAccCognitoIdentityPool_DeveloperProviderName (51.71s)
--- PASS: TestAccCognitoIdentityPool_cognitoIdentityProviders (71.08s)
--- PASS: TestAccCognitoIdentityPool_supportedLoginProviders (71.27s)
--- PASS: TestAccCognitoIdentityPool_openidConnectProviderARNs (72.18s)
--- PASS: TestAccCognitoIdentityPool_tags (72.86s)
--- PASS: TestAccCognitoIdentityPool_samlProviderARNs (81.89s)

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Nov 6, 2022
@DrFaust92 DrFaust92 added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 6, 2022
@DrFaust92 DrFaust92 changed the title Dont update unrelated changes on tag changes Cognito identity pool - Dont update unrelated changes on tag changes Nov 6, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review November 6, 2022 09:47
Copy link
Collaborator

@kamilturek kamilturek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCognitoIdentityPool_' PKG=cognitoidentity ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidentity/... -v -count 1 -parallel 2  -run=TestAccCognitoIdentityPool_ -timeout 180m
=== RUN   TestAccCognitoIdentityPool_basic
=== PAUSE TestAccCognitoIdentityPool_basic
=== RUN   TestAccCognitoIdentityPool_DeveloperProviderName
=== PAUSE TestAccCognitoIdentityPool_DeveloperProviderName
=== RUN   TestAccCognitoIdentityPool_supportedLoginProviders
=== PAUSE TestAccCognitoIdentityPool_supportedLoginProviders
=== RUN   TestAccCognitoIdentityPool_openidConnectProviderARNs
=== PAUSE TestAccCognitoIdentityPool_openidConnectProviderARNs
=== RUN   TestAccCognitoIdentityPool_samlProviderARNs
=== PAUSE TestAccCognitoIdentityPool_samlProviderARNs
=== RUN   TestAccCognitoIdentityPool_cognitoIdentityProviders
=== PAUSE TestAccCognitoIdentityPool_cognitoIdentityProviders
=== RUN   TestAccCognitoIdentityPool_addingNewProviderKeepsOldProvider
--- PASS: TestAccCognitoIdentityPool_addingNewProviderKeepsOldProvider (42.01s)
=== RUN   TestAccCognitoIdentityPool_tags
=== PAUSE TestAccCognitoIdentityPool_tags
=== RUN   TestAccCognitoIdentityPool_disappears
=== PAUSE TestAccCognitoIdentityPool_disappears
=== CONT  TestAccCognitoIdentityPool_basic
=== CONT  TestAccCognitoIdentityPool_samlProviderARNs
--- PASS: TestAccCognitoIdentityPool_basic (29.76s)
=== CONT  TestAccCognitoIdentityPool_tags
--- PASS: TestAccCognitoIdentityPool_samlProviderARNs (42.72s)
=== CONT  TestAccCognitoIdentityPool_disappears
--- PASS: TestAccCognitoIdentityPool_disappears (12.78s)
=== CONT  TestAccCognitoIdentityPool_supportedLoginProviders
--- PASS: TestAccCognitoIdentityPool_tags (41.52s)
=== CONT  TestAccCognitoIdentityPool_openidConnectProviderARNs
--- PASS: TestAccCognitoIdentityPool_supportedLoginProviders (40.97s)
=== CONT  TestAccCognitoIdentityPool_cognitoIdentityProviders
--- PASS: TestAccCognitoIdentityPool_openidConnectProviderARNs (40.54s)
=== CONT  TestAccCognitoIdentityPool_DeveloperProviderName
--- PASS: TestAccCognitoIdentityPool_cognitoIdentityProviders (42.60s)
--- PASS: TestAccCognitoIdentityPool_DeveloperProviderName (32.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity	190.469s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 2d32774 into hashicorp:main Nov 7, 2022
@github-actions github-actions bot added this to the v4.39.0 milestone Nov 7, 2022
@github-actions
Copy link

This functionality has been released in v4.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Updating tags for aws_cognito_identity_pool deletes the identity pool
3 participants