-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_sesv2_email_identity_mail_from_attributes: new resource #27672
r/aws_sesv2_email_identity_mail_from_attributes: new resource #27672
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Type: schema.TypeString, | ||
Optional: true, | ||
Default: string(types.BehaviorOnMxFailureUseDefaultValue), | ||
ValidateDiagFunc: enum.Validate[types.BehaviorOnMxFailure](), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is really handy! Thanks, TIL! 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
$ make testacc PKG=sesv2 TESTS=TestAccSESV2EmailIdentityMailFromAttributes
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2EmailIdentityMailFromAttributes' -timeout 180m
=== RUN TestAccSESV2EmailIdentityMailFromAttributes_basic
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributes_basic
=== RUN TestAccSESV2EmailIdentityMailFromAttributes_disappears
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributes_disappears
=== RUN TestAccSESV2EmailIdentityMailFromAttributes_disappearsEmailIdentity
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributes_disappearsEmailIdentity
=== RUN TestAccSESV2EmailIdentityMailFromAttributes_behaviorOnMXFailure
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributes_behaviorOnMXFailure
=== RUN TestAccSESV2EmailIdentityMailFromAttributes_mailFromDomain
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributes_mailFromDomain
=== CONT TestAccSESV2EmailIdentityMailFromAttributes_basic
=== CONT TestAccSESV2EmailIdentityMailFromAttributes_behaviorOnMXFailure
=== CONT TestAccSESV2EmailIdentityMailFromAttributes_disappearsEmailIdentity
=== CONT TestAccSESV2EmailIdentityMailFromAttributes_mailFromDomain
=== CONT TestAccSESV2EmailIdentityMailFromAttributes_disappears
--- PASS: TestAccSESV2EmailIdentityMailFromAttributes_disappearsEmailIdentity (14.17s)
--- PASS: TestAccSESV2EmailIdentityMailFromAttributes_basic (19.28s)
--- PASS: TestAccSESV2EmailIdentityMailFromAttributes_disappears (19.63s)
--- PASS: TestAccSESV2EmailIdentityMailFromAttributes_mailFromDomain (29.73s)
--- PASS: TestAccSESV2EmailIdentityMailFromAttributes_behaviorOnMXFailure (30.46s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sesv2 33.155s
Thanks for your contribution @kamilturek! This was in great shape, just made a couple small adjustments:
|
This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR introduces the
aws_sesv2_email_identity_mail_from_attributes
resource.Relations
Relates #26796.
References
https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_PutEmailIdentityMailFromAttributes.html
Output from Acceptance Testing