Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_lightsail_lb_https_redirection_policy #27679

Merged

Conversation

brittandeyoung
Copy link
Collaborator

Description

This pull request adds the new aws_lightsail_lb_https_redirection_policy resource which allows you to manage http to https redirection on lightsail load balancers with terraform.

Relations

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccLightsailLoadBalancerHTTPSRedirectionPolicy' PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailLoadBalancerHTTPSRedirectionPolicy -timeout 180m
=== RUN   TestAccLightsailLoadBalancerHTTPSRedirectionPolicy_basic
=== PAUSE TestAccLightsailLoadBalancerHTTPSRedirectionPolicy_basic
=== CONT  TestAccLightsailLoadBalancerHTTPSRedirectionPolicy_basic
--- PASS: TestAccLightsailLoadBalancerHTTPSRedirectionPolicy_basic (109.47s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  111.485s

...

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/lightsail Issues and PRs that pertain to the lightsail service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 7, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Nov 7, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLightsailLoadBalancerHTTPSRedirectionPolicy_' PKG=lightsail ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 2  -run=TestAccLightsailLoadBalancerHTTPSRedirectionPolicy_ -timeout 180m
=== RUN   TestAccLightsailLoadBalancerHTTPSRedirectionPolicy_basic
=== PAUSE TestAccLightsailLoadBalancerHTTPSRedirectionPolicy_basic
=== CONT  TestAccLightsailLoadBalancerHTTPSRedirectionPolicy_basic
--- PASS: TestAccLightsailLoadBalancerHTTPSRedirectionPolicy_basic (118.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	123.234s

@ewbankkit
Copy link
Contributor

@brittandeyoung Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b952909 into hashicorp:main Nov 7, 2022
@github-actions github-actions bot added this to the v4.39.0 milestone Nov 7, 2022
@github-actions
Copy link

This functionality has been released in v4.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/lightsail Issues and PRs that pertain to the lightsail service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants